refactor: remove unused includes and forward declarations from headers

Author: knst

src/evo/assetlocktx.h

@@ -6,9 +6,9 @@
 #define BITCOIN_EVO_ASSETLOCKTX_H
 
 #include <bls/bls_ies.h>
-#include <primitives/transaction.h>
+#include <consensus/amount.h>
 #include <gsl/pointers.h>
-
+#include <primitives/transaction.h>
 #include <serialize.h>
 #include <univalue.h>
 

src/evo/creditpool.h

@@ -5,21 +5,21 @@
 #ifndef BITCOIN_EVO_CREDITPOOL_H
 #define BITCOIN_EVO_CREDITPOOL_H
 
-#include <coins.h>
-
-#include <evo/assetlocktx.h>
-
+#include <consensus/amount.h>
 #include <saltedhasher.h>
 #include <serialize.h>
 #include <sync.h>
 #include <threadsafety.h>
 #include <unordered_lru_cache.h>
 #include <util/ranges_set.h>
 
+#include <evo/assetlocktx.h>
+
 #include <optional>
 #include <unordered_set>
 
 class BlockManager;
+class CBlock;
 class CBlockIndex;
 class BlockValidationState;
 class CEvoDB;

src/evo/deterministicmns.h

@@ -29,6 +29,7 @@
 class CBlock;
 class CBlockIndex;
 class CChainState;
+class CCoinsViewCache;
 class CConnman;
 class CEvoDB;
 class TxValidationState;

src/evo/dmnstate.h

@@ -5,12 +5,12 @@
 #ifndef BITCOIN_EVO_DMNSTATE_H
 #define BITCOIN_EVO_DMNSTATE_H
 
-#include <crypto/common.h>
 #include <bls/bls.h>
-#include <pubkey.h>
+#include <crypto/sha256.h>
+#include <evo/providertx.h>
 #include <netaddress.h>
+#include <pubkey.h>
 #include <script/script.h>
-#include <evo/providertx.h>
 
 #include <memory>
 #include <utility>

src/evo/mnauth.h

@@ -14,16 +14,12 @@ class CBlockIndex;
 class CChain;
 class CConnman;
 class CDataStream;
-class CDeterministicMN;
 class CDeterministicMNList;
 class CDeterministicMNListDiff;
-class CDeterministicMNManager;
 class CMasternodeMetaMan;
 class CMasternodeSync;
 class CNode;
 
-class UniValue;
-
 enum ServiceFlags : uint64_t;
 
 /**

src/evo/mnhftx.h

@@ -7,21 +7,20 @@
 
 #include <bls/bls.h>
 #include <gsl/pointers.h>
-#include <primitives/transaction.h>
 #include <sync.h>
 #include <threadsafety.h>
 #include <univalue.h>
 
 #include <optional>
 #include <saltedhasher.h>
-#include <unordered_map>
 #include <unordered_lru_cache.h>
 #include <versionbits.h>
 
 class BlockValidationState;
 class CBlock;
 class CBlockIndex;
 class CEvoDB;
+class CTransaction;
 class ChainstateManager;
 class TxValidationState;
 namespace llmq {

src/evo/providertx.h

@@ -17,8 +17,6 @@
 #include <univalue.h>
 #include <util/underlying.h>
 
-class CBlockIndex;
-class CCoinsViewCache;
 class TxValidationState;
 
 class CProRegTx

src/evo/simplifiedmns.h

@@ -6,18 +6,22 @@
 #define BITCOIN_EVO_SIMPLIFIEDMNS_H
 
 #include <bls/bls.h>
-#include <evo/deterministicmns.h>
 #include <evo/dmn_types.h>
 #include <merkleblock.h>
 #include <netaddress.h>
 #include <pubkey.h>
+#include <sync.h>
+#include <threadsafety.h>
 
 class UniValue;
 class CBlockIndex;
-class CDeterministicMNList;
 class CDeterministicMN;
+class CDeterministicMNList;
+class CDeterministicMNManager;
 class ChainstateManager;
 
+extern RecursiveMutex cs_main;
+
 namespace llmq {
 class CFinalCommitment;
 class CQuorumBlockProcessor;

src/evo/specialtx.h

@@ -11,7 +11,6 @@
 #include <uint256.h>
 #include <version.h>
 
-#include <string_view>
 #include <optional>
 #include <vector>
 

src/evo/specialtxman.h

@@ -5,7 +5,7 @@
 #ifndef BITCOIN_EVO_SPECIALTXMAN_H
 #define BITCOIN_EVO_SPECIALTXMAN_H
 
-#include <primitives/transaction.h>
+#include <consensus/amount.h>
 #include <sync.h>
 #include <threadsafety.h>
 
@@ -17,6 +17,7 @@ class CBlockIndex;
 class CCoinsViewCache;
 class CCreditPoolManager;
 class CDeterministicMNManager;
+class CTransaction;
 class ChainstateManager;
 class CMNHFManager;
 class TxValidationState;