Merge #6959: refactor: separate network and consensus logic 1/N [instantsend]

d4d64f6 fix: don't remove handlers too early (Konstantin Akimov)
a26a974 perf: std::move a shared_ptr with islock in ProcessMessage (Konstantin Akimov)
3c26523 fix: update log records from CInstantSendManager for NetInstantSend instead and tidy up them a bit (Konstantin Akimov)
90d7879 refactor: use NetHandler class to separate instantsend logic and network logic (Konstantin Akimov)
466e2a2 feat: introduce new bridge interface NetHandler to separate network logic and consensus (Konstantin Akimov)

Pull request description:

  ## Issue being fixed or feature implemented
  Separation of consensus & chain code and network & node in Dash Core is blocked by tight connection of network and consensus code; in components such as `llmq::CSigningManager`, `llmq::CSigSharesManager`, `coinjoin::client`, `coinjoin::server`, `governance/`, `llmq::CInstantSendManager`, etc.
  It blocks backport's of bitcoin related to 'kernel' project.

  This PR addresses 1st dependency of `llmq::CInstantSendManager` on `PeerManager`.

  It is a split from proof-of-concept PR #6934

  ## What was done?
  This PR introduces `NetHandler` which is a bridge interface between node/network related code and between consensus/chain code. In case if there is no need any network, objects that inherited by `NetHandler` are not created.

  ```
  class NetHandler
  {
  public:
      NetHandler(PeerManagerInternal* peer_manager) : m_peer_manager{Assert(peer_manager)} {}
      virtual ~NetHandler() {
          Interrupt();
          Stop();
      }

      virtual void Start() {}
      virtual void Stop() {}
      virtual void Interrupt() {}
      virtual void Schedule(CScheduler& scheduler, CConnman& connman) {}
      virtual void ProcessMessage(CNode& pfrom, const std::string& msg_type, CDataStream& vRecv) {}
  protected:
      PeerManagerInternal* m_peer_manager;
  };
  ```

  ## How Has This Been Tested?
  Run unit & functional tests.
  Run a linter `test/lint/lint-circular-dependencies.py`

  Overall conception is tested in #6934 as potentially successful to finish separation of network & consensus code.

  ## Breaking Changes
  N/A

  ## Checklist:
  - [x] I have performed a self-review of my own code
  - [x] I have commented my code, particularly in hard-to-understand areas
  - [ ] I have added or updated relevant unit/integration/functional/e2e tests
  - [ ] I have made corresponding changes to the documentation
  - [x] I have assigned this pull request to a milestone

Top commit has no ACKs.

Tree-SHA512: 5bf0a00f3b10b84019be5b70aa3e4baddd2c7735d4f177a6391ef362d34e62996438ae1ccbc106ea9966b539206b1694e9542a33cf9aca96f681f829f707b2cc

Author: PastaPastaPasta

src/Makefile.am

@@ -252,6 +252,7 @@ BITCOIN_CORE_H = \
   instantsend/db.h \
   instantsend/instantsend.h \
   instantsend/lock.h \
+  instantsend/net_instantsend.h \
   instantsend/signing.h \
   kernel/coinstats.h \
   key.h \
@@ -523,6 +524,7 @@ libbitcoin_node_a_SOURCES = \
   instantsend/db.cpp \
   instantsend/instantsend.cpp \
   instantsend/lock.cpp \
+  instantsend/net_instantsend.cpp \
   instantsend/signing.cpp \
   kernel/coinstats.cpp \
   llmq/blockprocessor.cpp \

src/init.cpp

@@ -87,6 +87,7 @@
 #include <flat-database.h>
 #include <governance/governance.h>
 #include <instantsend/instantsend.h>
+#include <instantsend/net_instantsend.h>
 #include <llmq/context.h>
 #include <llmq/dkgsessionmgr.h>
 #include <llmq/options.h>
@@ -250,6 +251,9 @@ void Interrupt(NodeContext& node)
     if (node.active_ctx) {
         node.active_ctx->Interrupt();
     }
+    if (node.peerman) {
+        node.peerman->InterruptHandlers();
+    }
     if (node.llmq_ctx) {
         node.llmq_ctx->Interrupt();
     }
@@ -285,7 +289,9 @@ void PrepareShutdown(NodeContext& node)
     StopREST();
     StopRPC();
     StopHTTPServer();
+
     if (node.active_ctx) node.active_ctx->Stop();
+    if (node.peerman) node.peerman->StopHandlers();
     if (node.llmq_ctx) node.llmq_ctx->Stop();
 
     for (const auto& client : node.chain_clients) {
@@ -2193,6 +2199,7 @@ bool AppInitMain(NodeContext& node, interfaces::BlockAndHeaderTipInfo* tip_info)
         g_active_notification_interface = std::make_unique<ActiveNotificationInterface>(*node.active_ctx, *node.mn_activeman);
         RegisterValidationInterface(g_active_notification_interface.get());
     }
+    node.peerman->AddExtraHandler(std::make_unique<NetInstantSend>(node.peerman.get(), *node.llmq_ctx->isman, *node.llmq_ctx->qman, chainman.ActiveChainstate()));
 
     // ********************************************************* Step 7d: Setup other Dash services
 
@@ -2288,6 +2295,7 @@ bool AppInitMain(NodeContext& node, interfaces::BlockAndHeaderTipInfo* tip_info)
     // ********************************************************* Step 10a: schedule Dash-specific tasks
 
     node.llmq_ctx->Start(*node.peerman);
+    node.peerman->StartHandlers();
     if (node.active_ctx) node.active_ctx->Start(*node.connman, *node.peerman);
 
     node.scheduler->scheduleEvery(std::bind(&CNetFulfilledRequestManager::DoMaintenance, std::ref(*node.netfulfilledman)), std::chrono::minutes{1});