Skip to content

Commit b359606

Browse files
authored
chore: update devcontainer to python 3.13, ubuntu 24, and add fish shell (#538)
* Update devcontainer to python 3.13 * Update devcontainer to Ubuntu noble * feat: add fish shell to devcontainer * chore: call python3 instead of specific version
1 parent 6a7e804 commit b359606

File tree

4 files changed

+35
-7
lines changed

4 files changed

+35
-7
lines changed

.devcontainer/devcontainer.json

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,15 @@
33
{
44
"name": "Ubuntu",
55
// Or use a Dockerfile or Docker Compose file. More info: https://containers.dev/guide/dockerfile
6-
"image": "mcr.microsoft.com/devcontainers/base:jammy",
6+
"image": "mcr.microsoft.com/devcontainers/base:noble",
77
// Features to add to the dev container. More info: https://containers.dev/features.
8-
"features": {
9-
"ghcr.io/devcontainers/features/github-cli:1": {},
10-
"ghcr.io/devcontainers/features/python:1": {}
11-
},
8+
"features": {
9+
"ghcr.io/devcontainers/features/github-cli:1": {},
10+
"ghcr.io/devcontainers/features/python:1": {
11+
"version": "3.13"
12+
},
13+
"./features/fish": {}
14+
},
1215

1316
// Use 'forwardPorts' to make a list of ports inside the container available locally.
1417
// "forwardPorts": [],
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
{
2+
"id": "fish",
3+
"version": "1.0.0",
4+
"name": "Fish shell",
5+
"description": "Installs the fish shell from the Ubuntu package manager.",
6+
"options": {},
7+
"installsAfter": [
8+
"ghcr.io/devcontainers/features/common-utils"
9+
]
10+
}
Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
#!/usr/bin/env bash
2+
set -euo pipefail
3+
4+
echo "Installing fish from distro package manager..."
5+
6+
if command -v apt-get >/dev/null 2>&1; then
7+
apt-get update
8+
DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends fish
9+
rm -rf /var/lib/apt/lists/*
10+
else
11+
echo "Unsupported base image: expected apt-get (Ubuntu/Debian)." >&2
12+
exit 1
13+
fi
Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,12 @@
1-
#/!bin/sh
1+
#!/bin/sh
2+
3+
set -eu
24

35
# Command to run during postCreateCommand
46
# Done in script because when done via object the commands are run in parallel
57
# (which isn't always desirable)
68
# https://containers.dev/implementors/spec/#parallel-exec
79
# https://containers.dev/implementors/json_reference/#formatting-string-vs-array-properties
810

9-
pip install -r requirements.txt
11+
python3 -m pip install -r requirements.txt
1012
make html

0 commit comments

Comments
 (0)