review comments addressed

Author: ZocoLini

dash-spv/src/storage/disk/segments.rs

@@ -246,9 +246,8 @@ impl<I: Persistable> SegmentCache<I> {
     }
 
     pub async fn get_items(&mut self, height_range: Range<u32>) -> StorageResult<Vec<I>> {
-        if height_range.start > height_range.end {
-            panic!("Invalid height range: start > end, {:?}", height_range);
-        }
+        debug_assert!(height_range.start <= height_range.end);
+
         let storage_start_idx = self.height_to_index(height_range.start);
         let storage_end_idx = self.height_to_index(height_range.end);
 

dash-spv/tests/segmented_storage_test.rs

@@ -27,7 +27,6 @@ fn create_test_header(height: u32) -> BlockHeader {
 fn create_test_filter_header(height: u32) -> FilterHeader {
     // Create unique filter headers
     let mut bytes = [0u8; 32];
-    // This is made to avoid having a header
     bytes[0..4].copy_from_slice(&height.to_le_bytes());
     FilterHeader::from_raw_hash(dashcore_hashes::sha256d::Hash::from_byte_array(bytes))
 }