removed fork detector and fork structs since they are no longer used after las removal

Author: ZocoLini

dash-spv/src/chain/fork_detector.rs

@@ -1,7 +1,6 @@
 //! Chain management module with reorganization support
 //!
 //! This module provides functionality for managing blockchain state including:
-//! - Fork detection and handling
 //! - Chain reorganization
 //! - Multiple chain tip tracking
 //! - Chain work calculation
@@ -11,9 +10,7 @@ pub mod chain_tip;
 pub mod chain_work;
 pub mod chainlock_manager;
 pub mod checkpoints;
-pub mod fork_detector;
 pub mod orphan_pool;
-pub mod reorg;
 
 #[cfg(test)]
 mod checkpoint_test;
@@ -24,25 +21,4 @@ pub use chain_tip::{ChainTip, ChainTipManager};
 pub use chain_work::ChainWork;
 pub use chainlock_manager::{ChainLockEntry, ChainLockManager, ChainLockStats};
 pub use checkpoints::{Checkpoint, CheckpointManager};
-pub use fork_detector::{ForkDetectionResult, ForkDetector};
 pub use orphan_pool::{OrphanBlock, OrphanPool, OrphanPoolStats};
-pub use reorg::ReorgEvent;
-
-use dashcore::{BlockHash, Header as BlockHeader};
-
-/// Represents a potential chain fork
-#[derive(Debug, Clone)]
-pub struct Fork {
-    /// The block hash where the fork diverges from the main chain
-    pub fork_point: BlockHash,
-    /// The height of the fork point
-    pub fork_height: u32,
-    /// The tip of the forked chain
-    pub tip_hash: BlockHash,
-    /// The height of the fork tip
-    pub tip_height: u32,
-    /// Headers in the fork (from fork point to tip)
-    pub headers: Vec<BlockHeader>,
-    /// Cumulative chain work of this fork
-    pub chain_work: ChainWork,
-}

dash-spv/src/chain/mod.rs

@@ -7,7 +7,7 @@ use dashcore::{
 use dashcore_hashes::Hash;
 
 use crate::chain::checkpoints::{mainnet_checkpoints, testnet_checkpoints, CheckpointManager};
-use crate::chain::{ChainTip, ChainTipManager, ChainWork, ForkDetector};
+use crate::chain::{ChainTip, ChainTipManager, ChainWork};
 use crate::client::ClientConfig;
 use crate::error::{SyncError, SyncResult};
 use crate::network::NetworkManager;
@@ -47,7 +47,6 @@ pub struct HeaderSyncManager<S: StorageManager, N: NetworkManager> {
     _phantom_s: std::marker::PhantomData<S>,
     _phantom_n: std::marker::PhantomData<N>,
     config: ClientConfig,
-    fork_detector: ForkDetector,
     tip_manager: ChainTipManager,
     checkpoint_manager: CheckpointManager,
     reorg_config: ReorgConfig,
@@ -83,8 +82,6 @@ impl<S: StorageManager + Send + Sync + 'static, N: NetworkManager + Send + Sync
 
         Ok(Self {
             config: config.clone(),
-            fork_detector: ForkDetector::new(reorg_config.max_forks)
-                .map_err(|e| SyncError::InvalidState(e.to_string()))?,
             tip_manager: ChainTipManager::new(reorg_config.max_forks),
             checkpoint_manager,
             reorg_config,
@@ -842,10 +839,6 @@ impl<S: StorageManager + Send + Sync + 'static, N: NetworkManager + Send + Sync
         // Reset sync state
         self.syncing_headers = false;
         self.last_sync_progress = std::time::Instant::now();
-        // Clear any fork tracking state that shouldn't persist across restarts
-        self.fork_detector = ForkDetector::new(self.reorg_config.max_forks).map_err(|e| {
-            SyncError::InvalidState(format!("Failed to create fork detector: {}", e))
-        })?;
         tracing::debug!("Reset header sync pending requests");
         Ok(())
     }