refactor: Don't add a dummy in mark_filter_received (#222)

The processing parts already does the same checks as the "dummy adding" parts.

Author: xdustinface

dash-spv/src/sync/filters/download.rs

@@ -205,9 +205,9 @@ impl<S: StorageManager + Send + Sync + 'static, N: NetworkManager + Send + Sync
         &mut self,
         block_hash: BlockHash,
         storage: &S,
-    ) -> SyncResult<Vec<(u32, u32)>> {
+    ) -> SyncResult<()> {
         if !self.flow_control_enabled {
-            return Ok(Vec::new());
+            return Ok(());
         }
 
         // Record the received filter
@@ -241,18 +241,7 @@ impl<S: StorageManager + Send + Sync + 'static, N: NetworkManager + Send + Sync
             }
         }
 
-        // Always return at least one "completion" to trigger queue processing
-        // This ensures we continuously utilize available slots instead of waiting for 100% completion
-        if completed_requests.is_empty() && !self.pending_filter_requests.is_empty() {
-            // If we have available slots and pending requests, trigger processing
-            let available_slots =
-                MAX_CONCURRENT_FILTER_REQUESTS.saturating_sub(self.active_filter_requests.len());
-            if available_slots > 0 {
-                completed_requests.push((0, 0)); // Dummy completion to trigger processing
-            }
-        }
-
-        Ok(completed_requests)
+        Ok(())
     }
 
     async fn is_request_complete(&self, start: u32, end: u32) -> SyncResult<bool> {

dash-spv/src/sync/sequential/message_handlers.rs

@@ -640,32 +640,26 @@ impl<
         }
 
         // Handle filter message tracking
-        let completed_ranges =
-            self.filter_sync.mark_filter_received(cfilter.block_hash, storage).await?;
-
-        // Process any newly completed ranges
-        if !completed_ranges.is_empty() {
-            tracing::debug!("Completed {} filter request ranges", completed_ranges.len());
-
-            // Send more filter requests from the queue if we have available slots
-            if self.filter_sync.has_pending_filter_requests() {
-                let available_slots = self.filter_sync.get_available_request_slots();
-                if available_slots > 0 {
-                    tracing::debug!(
-                        "Sending more filter requests: {} slots available, {} pending",
-                        available_slots,
-                        self.filter_sync.pending_download_count()
-                    );
-                    self.filter_sync.send_next_filter_batch(network).await?;
-                } else {
-                    tracing::trace!(
-                        "No available slots for more filter requests (all {} slots in use)",
-                        self.filter_sync.active_request_count()
-                    );
-                }
+        self.filter_sync.mark_filter_received(cfilter.block_hash, storage).await?;
+
+        // Send more filter requests from the queue if we have available slots
+        if self.filter_sync.has_pending_filter_requests() {
+            let available_slots = self.filter_sync.get_available_request_slots();
+            if available_slots > 0 {
+                tracing::debug!(
+                    "Sending more filter requests: {} slots available, {} pending",
+                    available_slots,
+                    self.filter_sync.pending_download_count()
+                );
+                self.filter_sync.send_next_filter_batch(network).await?;
             } else {
-                tracing::trace!("No more pending filter requests in queue");
+                tracing::trace!(
+                    "No available slots for more filter requests (all {} slots in use)",
+                    self.filter_sync.active_request_count()
+                );
             }
+        } else {
+            tracing::trace!("No more pending filter requests in queue");
         }
 
         // Update phase state