refactor: MultiPeerNetworkManager -> PeerNetworkManager (#184)

* refactor: `MultiPeerNetworkManager` -> `PeerNetworkManager`

* Fix formatting and apply review

Author: xdustinface

dash-spv-ffi/src/client.rs

@@ -115,7 +115,7 @@ type InnerClient = DashSpvClient<
     key_wallet_manager::wallet_manager::WalletManager<
         key_wallet::wallet::managed_wallet_info::ManagedWalletInfo,
     >,
-    dash_spv::network::MultiPeerNetworkManager,
+    dash_spv::network::PeerNetworkManager,
     DiskStorageManager,
 >;
 type SharedClient = Arc<Mutex<Option<InnerClient>>>;
@@ -173,7 +173,7 @@ pub unsafe extern "C" fn dash_spv_ffi_client_new(
 
     let client_result = runtime.block_on(async move {
         // Construct concrete implementations for generics
-        let network = dash_spv::network::MultiPeerNetworkManager::new(&client_config).await;
+        let network = dash_spv::network::PeerNetworkManager::new(&client_config).await;
         let storage = DiskStorageManager::new(storage_path.clone()).await;
         let wallet = key_wallet_manager::wallet_manager::WalletManager::<
             key_wallet::wallet::managed_wallet_info::ManagedWalletInfo,

dash-spv/ARCHITECTURE.md

@@ -67,7 +67,7 @@
 |----------|-------|-------|
 | Total Files | 110+ | Well-organized module structure |
 | Total Lines | ~40,000 | All files appropriately sized |
-| Largest File | network/multi_peer.rs | 1,322 lines - Acceptable complexity |
+| Largest File | network/manager.rs | 1,322 lines - Acceptable complexity |
 | Module Count | 10+ | Well-separated concerns |
 | Test Coverage | 242/243 passing | 99.6% pass rate |
 | Major Modules Refactored | 4 | sync/filters/, sync/sequential/, client/, storage/disk/ |
@@ -665,9 +665,9 @@ The network module handles all P2P communication with the Dash network.
 
 **Refactoring needed**: ❌ None - exemplary trait design
 
-#### `src/network/multi_peer.rs` (1,322 lines) 🚨 **TOO LARGE**
+#### `src/network/manager.rs` (1,322 lines) 🚨 **TOO LARGE**
 
-**Purpose**: Multi-peer network manager implementation.
+**Purpose**: Peer network manager implementation.
 
 **What it does** (TOO MUCH):
 - Peer discovery via DNS seeds
@@ -699,10 +699,10 @@ The network module handles all P2P communication with the Dash network.
 
 **Refactoring needed**:
 - 🚨 **CRITICAL**: Split into:
-  - `network/multi_peer/manager.rs` - Main MultiPeerNetworkManager
-  - `network/multi_peer/discovery.rs` - DNS and peer discovery
-  - `network/multi_peer/routing.rs` - Message routing
-  - `network/multi_peer/health.rs` - Health monitoring
+  - `network/peer/manager.rs` - Main PeerNetworkManager
+  - `network/peer/discovery.rs` - DNS and peer discovery
+  - `network/peer/routing.rs` - Message routing
+  - `network/peer/health.rs` - Health monitoring
 - ⚠️ **HIGH**: Add connection limit configuration
 - ⚠️ **HIGH**: Add bandwidth throttling
 - ⚠️ **MEDIUM**: Document lock ordering
@@ -750,7 +750,7 @@ The network module handles all P2P communication with the Dash network.
 
 **Refactoring needed**: ❌ None
 
-#### `src/network/peer.rs` (188 lines) ✅ GOOD
+#### `src/network/manager.rs` (188 lines) ✅ GOOD
 
 **Purpose**: Peer metadata and state tracking.
 
@@ -826,7 +826,7 @@ The network module handles all P2P communication with the Dash network.
 - `pool.rs` (143 lines) ✅ **GOOD** - Peer pool management
 
 **Overall Network Module Assessment**:
-- ⚠️ NEEDS: Breaking up large files (multi_peer.rs, connection.rs)
+- ⚠️ NEEDS: Breaking up large files (peer.rs, connection.rs)
 - ✅ GOOD: Strong abstractions
 - ⚠️ NEEDS: Better documentation of concurrent access patterns
 - ✅ GOOD: Comprehensive mock support
@@ -1429,7 +1429,7 @@ Validation module handles header validation, ChainLock verification, and Instant
     ```rust
     type StandardSpvClient = DashSpvClient<
         WalletManager,
-        MultiPeerNetworkManager,
+        PeerNetworkManager,
         DiskStorageManager
     >;
     ```
@@ -1458,7 +1458,7 @@ Validation module handles header validation, ChainLock verification, and Instant
 | sync/sequential/ | 11 modules (4,785 total) | ✅ EXCELLENT | Sequential sync pipeline modules |
 | client/ | 8 modules (2,895 total) | ✅ EXCELLENT | Client functionality modules |
 | storage/disk/ | 7 modules (2,458 total) | ✅ EXCELLENT | Persistent storage modules |
-| network/multi_peer.rs | 1,322 | ✅ ACCEPTABLE | Complex peer management logic |
+| network/manager.rs | 1,322 | ✅ ACCEPTABLE | Complex peer management logic |
 | sync/headers_with_reorg.rs | 1,148 | ✅ ACCEPTABLE | Reorg handling complexity justified |
 | types.rs | 1,064 | ✅ ACCEPTABLE | Core type definitions |
 | mempool_filter.rs | 793 | ✅ GOOD | Mempool management |
@@ -1507,7 +1507,7 @@ Validation module handles header validation, ChainLock verification, and Instant
    - Fix: Add checksums
 
 4. **No Connection Limits**
-   - File: `network/multi_peer.rs`
+   - File: `network/manager.rs`
    - Risk: DoS via connection exhaustion
    - Fix: Add configurable limits
 

dash-spv/CLAUDE.md

@@ -119,7 +119,7 @@ TCP-based networking with proper Dash protocol implementation:
 - Connection management via `TcpConnection`
 - Handshake handling via `HandshakeManager`
 - Message routing via `MessageHandler`
-- Multi-peer support via `MultiPeerManager`
+- Peer support via `PeerNetworkManager`
 
 ### Validation Modes
 - `ValidationMode::None`: No validation (fast)

dash-spv/CODE_ANALYSIS_SUMMARY.md

@@ -158,7 +158,7 @@
 ```
 
 **Largest Remaining Files:**
-- `network/multi_peer.rs` (1,322 lines) - Acceptable for complex peer management
+- `network/manager.rs` (1,322 lines) - Acceptable for complex peer management
 - `sync/headers_with_reorg.rs` (1,148 lines) - Acceptable for reorg handling
 - `types.rs` (1,064 lines) - Could be split but acceptable
 

dash-spv/examples/filter_sync.rs

@@ -1,6 +1,6 @@
 //! BIP157 filter synchronization example.
 
-use dash_spv::network::MultiPeerNetworkManager;
+use dash_spv::network::PeerNetworkManager;
 use dash_spv::storage::MemoryStorageManager;
 use dash_spv::{init_logging, ClientConfig, DashSpvClient};
 use dashcore::Address;
@@ -24,7 +24,7 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
     let config = ClientConfig::mainnet().without_masternodes(); // Skip masternode sync for this example
 
     // Create network manager
-    let network_manager = MultiPeerNetworkManager::new(&config).await?;
+    let network_manager = PeerNetworkManager::new(&config).await?;
 
     // Create storage manager
     let storage_manager = MemoryStorageManager::new().await?;

dash-spv/examples/simple_sync.rs

@@ -1,6 +1,6 @@
 //! Simple header synchronization example.
 
-use dash_spv::network::MultiPeerNetworkManager;
+use dash_spv::network::PeerNetworkManager;
 use dash_spv::storage::MemoryStorageManager;
 use dash_spv::{init_logging, ClientConfig, DashSpvClient};
 use key_wallet::wallet::managed_wallet_info::ManagedWalletInfo;
@@ -20,7 +20,7 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
         .without_masternodes(); // Skip masternode sync for this example
 
     // Create network manager
-    let network_manager = MultiPeerNetworkManager::new(&config).await?;
+    let network_manager = PeerNetworkManager::new(&config).await?;
 
     // Create storage manager
     let storage_manager = MemoryStorageManager::new().await?;

dash-spv/examples/spv_with_wallet.rs

@@ -2,7 +2,7 @@
 //!
 //! This example shows how to integrate the SPV client with a wallet manager.
 
-use dash_spv::network::MultiPeerNetworkManager;
+use dash_spv::network::PeerNetworkManager;
 use dash_spv::storage::DiskStorageManager;
 use dash_spv::{ClientConfig, DashSpvClient};
 use key_wallet::wallet::managed_wallet_info::ManagedWalletInfo;
@@ -22,7 +22,7 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
     config.enable_filters = true;
 
     // Create network manager
-    let network_manager = MultiPeerNetworkManager::new(&config).await?;
+    let network_manager = PeerNetworkManager::new(&config).await?;
 
     // Create storage manager - use disk storage for persistence
     let storage_manager = DiskStorageManager::new("/tmp/dash-spv-example".into()).await?;

dash-spv/src/client/core.rs

@@ -77,7 +77,7 @@ use super::{BlockProcessingTask, ClientConfig, StatusDisplay};
 /// // Production configuration
 /// type StandardSpvClient = DashSpvClient<
 ///     WalletManager,
-///     MultiPeerNetworkManager,
+///     PeerNetworkManager,
 ///     DiskStorageManager,
 /// >;
 ///

dash-spv/src/client/queries.rs

@@ -42,11 +42,11 @@ impl<
 
     /// Disconnect a specific peer.
     pub async fn disconnect_peer(&self, addr: &std::net::SocketAddr, reason: &str) -> Result<()> {
-        // Cast network manager to MultiPeerNetworkManager to access disconnect_peer
+        // Cast network manager to PeerNetworkManager to access disconnect_peer
         let network = self
             .network
             .as_any()
-            .downcast_ref::<crate::network::multi_peer::MultiPeerNetworkManager>()
+            .downcast_ref::<crate::network::manager::PeerNetworkManager>()
             .ok_or_else(|| {
                 SpvError::Config("Network manager does not support peer disconnection".to_string())
             })?;

dash-spv/src/lib.rs

@@ -13,7 +13,7 @@
 //!
 //! ```no_run
 //! use dash_spv::{DashSpvClient, ClientConfig};
-//! use dash_spv::network::MultiPeerNetworkManager;
+//! use dash_spv::network::PeerNetworkManager;
 //! use dash_spv::storage::MemoryStorageManager;
 //! use dashcore::Network;
 //! use key_wallet::wallet::managed_wallet_info::ManagedWalletInfo;
@@ -29,7 +29,7 @@
 //!         .with_log_level("info");
 //!
 //!     // Create the required components
-//!     let network = MultiPeerNetworkManager::new(&config).await?;
+//!     let network = PeerNetworkManager::new(&config).await?;
 //!     let storage = MemoryStorageManager::new().await?;
 //!     let wallet = Arc::new(RwLock::new(WalletManager::<ManagedWalletInfo>::new()));
 //!