Fix clippy-workspace checks

Author: xdustinface

dash/examples/ecdsa-psbt.rs

@@ -255,7 +255,7 @@ impl WatchOnly {
 
         let sigs: Vec<_> = psbt.inputs[0].partial_sigs.values().collect();
         let mut script_witness: Witness = Witness::new();
-        script_witness.push(&sigs[0].to_vec());
+        script_witness.push(sigs[0].to_vec());
         script_witness.push(self.input_xpub.to_pub().to_bytes());
 
         psbt.inputs[0].final_script_witness = Some(script_witness);

dash/examples/taproot-psbt.rs

@@ -398,10 +398,10 @@ impl BenefactorWallet {
         if let ChildNumber::Normal {
             index,
         } = self.next
+            && index > 0
+            && self.current_spend_info.is_some()
         {
-            if index > 0 && self.current_spend_info.is_some() {
-                return Err("Transaction already exists, use refresh_inheritance_timelock to refresh the timelock".into());
-            }
+            return Err("Transaction already exists, use refresh_inheritance_timelock to refresh the timelock".into());
         }
         // We use some other derivation path in this example for our inheritance protocol. The important thing is to ensure
         // that we use an unhardened path so we can make use of xpubs.
@@ -473,7 +473,6 @@ impl BenefactorWallet {
 
         let input = Input {
             witness_utxo: {
-                let script_pubkey = script_pubkey;
                 let amount = Amount::from_sat(value);
 
                 Some(TxOut {

hashes/benches/hashes.rs

@@ -128,7 +128,6 @@ fn bench_siphash24(c: &mut Criterion) {
     for (size, label) in [(1024, "1k"), (65536, "64k"), (1048576, "1m")] {
         group.throughput(Throughput::Bytes(size as u64));
         group.bench_with_input(BenchmarkId::from_parameter(label), &size, |b, &size| {
-            let key = [0u8; 16];
             let bytes = vec![1u8; size];
             b.iter(|| {
                 let hash =
@@ -217,26 +216,26 @@ fn bench_slice_comparisons(c: &mut Criterion) {
     group.bench_function("32b_ne", |b| {
         let hash_a = sha256::Hash::hash(&[0; 1]);
         let hash_b = sha256::Hash::hash(&[1; 1]);
-        b.iter(|| &hash_a[..] == &hash_b[..]);
+        b.iter(|| hash_a[..] == hash_b[..]);
     });
 
     group.bench_function("32b_eq", |b| {
         let hash_a = sha256::Hash::hash(&[0; 1]);
         let hash_b = sha256::Hash::hash(&[0; 1]);
-        b.iter(|| &hash_a[..] == &hash_b[..]);
+        b.iter(|| hash_a[..] == hash_b[..]);
     });
 
     // 64-byte comparisons (SHA512)
     group.bench_function("64b_ne", |b| {
         let hash_a = sha512::Hash::hash(&[0; 1]);
         let hash_b = sha512::Hash::hash(&[1; 1]);
-        b.iter(|| &hash_a[..] == &hash_b[..]);
+        b.iter(|| hash_a[..] == hash_b[..]);
     });
 
     group.bench_function("64b_eq", |b| {
         let hash_a = sha512::Hash::hash(&[0; 1]);
         let hash_b = sha512::Hash::hash(&[0; 1]);
-        b.iter(|| &hash_a[..] == &hash_b[..]);
+        b.iter(|| hash_a[..] == hash_b[..]);
     });
 
     group.finish();

key-wallet-manager/examples/wallet_creation.rs

@@ -5,7 +5,6 @@
 //! - Creating wallets from mnemonics
 //! - Managing wallet accounts and addresses
 
-use hex;
 use key_wallet::account::StandardAccountType;
 use key_wallet::wallet::initialization::WalletAccountCreationOptions;
 use key_wallet::wallet::managed_wallet_info::transaction_building::AccountTypePreference;

rpc-client/examples/connect_to_masternode.rs

@@ -73,7 +73,7 @@ fn main() {
     println!("\nQuorum list: \n{:?}", quorum_list);
 
     let quorum_hashes = quorum_list.quorums_by_type.get(&QuorumType::LlmqTest).unwrap();
-    let quorum_hash = quorum_hashes.get(0);
+    let quorum_hash = quorum_hashes.first();
 
     // Get Quorum info
     let quorum_info =
@@ -83,7 +83,7 @@ fn main() {
     let quorum_listextended = rpc.get_quorum_listextended(Some(quorum_info.height)).unwrap();
     println!("\n\nQuorum list extended \n{:?}", quorum_listextended);
 
-    let mn0 = quorum_info.members.get(0).unwrap();
+    let mn0 = quorum_info.members.first().unwrap();
     let mn0_pro_tx_hash = mn0.to_owned().pro_tx_hash;
 
     // Get Quorum DKG status

rpc-client/src/client.rs

@@ -841,6 +841,7 @@ pub trait RpcApi: Sized {
         self.call("getchaintips", &[])
     }
 
+    #[allow(clippy::too_many_arguments)]
     fn send_to_address(
         &self,
         address: &Address,
@@ -995,7 +996,7 @@ pub trait RpcApi: Sized {
     /// # Arguments
     ///
     /// 1. `timeout`: Time in milliseconds to wait for a response. 0
-    /// indicates no timeout.
+    ///    indicates no timeout.
     fn wait_for_new_block(&self, timeout: u64) -> Result<json::BlockRef> {
         self.call("waitfornewblock", &[into_json(timeout)?])
     }
@@ -1007,7 +1008,7 @@ pub trait RpcApi: Sized {
     ///
     /// 1. `blockhash`: Block hash to wait for.
     /// 2. `timeout`: Time in milliseconds to wait for a response. 0
-    /// indicates no timeout.
+    ///    indicates no timeout.
     fn wait_for_block(
         &self,
         blockhash: &dashcore::BlockHash,
@@ -1452,6 +1453,7 @@ pub trait RpcApi: Sized {
     }
 
     /// Creates a ProRegTx referencing an existing collateral and and sends it to the network
+    #[allow(clippy::too_many_arguments)]
     fn get_protx_register(
         &self,
         collateral_hash: &str,
@@ -1482,6 +1484,7 @@ pub trait RpcApi: Sized {
     }
 
     /// Creates and funds a ProRegTx with the 1,000 DASH necessary for a masternode and then sends it to the network
+    #[allow(clippy::too_many_arguments)]
     fn get_protx_register_fund(
         &self,
         collateral_address: &str,
@@ -1510,6 +1513,7 @@ pub trait RpcApi: Sized {
     }
 
     /// Creates an unsigned ProTx and a message that must be signed externally
+    #[allow(clippy::too_many_arguments)]
     fn get_protx_register_prepare(
         &self,
         collateral_hash: &str,
@@ -1730,7 +1734,6 @@ fn log_response(cmd: &str, resp: &Result<jsonrpc::Response>) {
 #[cfg(test)]
 mod tests {
     use super::*;
-    use serde_json;
 
     #[test]
     fn test_raw_tx() {

rpc-integration-test/src/main.rs

@@ -115,6 +115,7 @@ fn btc<F: Into<f64>>(btc: F) -> Amount {
 }
 
 /// Quickly create a signed BTC amount.
+#[allow(dead_code)]
 fn sbtc<F: Into<f64>>(btc: F) -> SignedAmount {
     SignedAmount::from_btc(btc.into()).unwrap()
 }
@@ -422,6 +423,7 @@ fn test_dump_private_key(cl: &Client) {
     assert_eq!(addr.to_string(), Address::p2pkh(&sk.public_key(&SECP), *NET).to_string());
 }
 
+#[allow(dead_code)]
 fn test_get_balance_generate_to_address(cl: &Client) {
     let initial = cl.get_balance(None, None).unwrap();
 
@@ -464,6 +466,7 @@ fn test_get_block_hash(cl: &Client) {
     assert_eq!(cl.get_block_hash(h).unwrap(), cl.get_best_block_hash().unwrap());
 }
 
+#[allow(dead_code)]
 fn test_get_block(cl: &Client) {
     let tip = cl.get_best_block_hash().unwrap();
     let block = cl.get_block(&tip).unwrap();
@@ -515,7 +518,7 @@ fn test_get_address_info(cl: &Client) {
 fn test_set_label(cl: &Client) {
     let addr = cl.get_new_address(Some("label")).unwrap().require_network(*NET).unwrap();
     let info = cl.get_address_info(&addr).unwrap();
-    if wallet_node_version() >= 0_20_00_00 {
+    if wallet_node_version() >= 20_00_00 {
         assert!(info.label.is_none());
         assert_eq!(info.labels[0], json::GetAddressInfoResultLabel::Simple("label".into()));
     } else {
@@ -531,7 +534,7 @@ fn test_set_label(cl: &Client) {
 
     cl.set_label(&addr, "other").unwrap();
     let info = cl.get_address_info(&addr).unwrap();
-    if wallet_node_version() >= 0_20_00_00 {
+    if wallet_node_version() >= 20_00_00 {
         assert!(info.label.is_none());
         assert_eq!(info.labels[0], json::GetAddressInfoResultLabel::Simple("other".into()));
     } else {
@@ -677,6 +680,7 @@ fn test_get_tx_out(cl: &Client) {
     let _ = cl.get_tx_out(&txid, 0, None).unwrap();
 }
 
+#[allow(dead_code)]
 fn test_get_tx_out_proof(cl: &Client) {
     let txid1 = cl
         .send_to_address(&RANDOM_ADDRESS, btc(1), None, None, None, None, None, None, None, None)
@@ -713,6 +717,7 @@ fn test_lock_unspent_unlock_unspent(cl: &Client) {
     assert!(cl.unlock_unspent_all().unwrap());
 }
 
+#[allow(dead_code)]
 fn test_get_block_filter(cl: &Client) {
     let addr = &cl.get_new_address(None).unwrap().require_network(*NET).unwrap();
     let blocks = cl.generate_to_address(7, addr).unwrap();
@@ -1340,6 +1345,7 @@ fn test_getblocktemplate(cl: &Client) {
     cl.generate_to_address(2, &RANDOM_ADDRESS).unwrap();
 }
 
+#[allow(dead_code)]
 fn test_stop(cl: &Client) {
     println!("Stopping: '{}'", cl.stop().unwrap());
 }
@@ -1357,6 +1363,7 @@ fn test_get_masternode_list(cl: &Client) {
     let _masternode_list = cl.get_masternode_list(Some("json"), None).unwrap();
 }
 
+#[allow(dead_code)]
 fn test_get_masternode_outputs(cl: &Client) {
     let _masternode_outputs = cl.get_masternode_outputs().unwrap();
 }
@@ -1425,6 +1432,7 @@ fn test_get_quorum_sign(cl: &Client, _wallet_client: &Client) {
         .unwrap();
 }
 
+#[allow(dead_code)]
 fn test_get_quorum_getrecsig(cl: &Client) {
     let list = cl.get_quorum_list(Some(1)).unwrap();
     let quorum_type = list.quorums_by_type.keys().next().unwrap().to_owned();
@@ -1458,6 +1466,7 @@ fn test_get_quorum_isconflicting(cl: &Client) {
         .unwrap();
 }
 
+#[allow(dead_code)]
 fn test_get_quorum_memberof(cl: &Client) {
     let pro_tx_hash =
         ProTxHash::from_str("39c07d2c9c6d0ead56f52726b63c15e295cb5c3ecf7fe1fefcfb23b2e3cfed1f")
@@ -1466,6 +1475,7 @@ fn test_get_quorum_memberof(cl: &Client) {
     assert!(quorum_memberof.0[0].height > 0);
 }
 
+#[allow(dead_code)]
 fn test_get_quorum_rotationinfo(cl: &Client) {
     let block_hash =
         BlockHash::from_str("0000012197b7ca6360af3756c6a49c217dbbdf8b595fd55e0fcef7ffcd546044")
@@ -1482,6 +1492,7 @@ fn test_get_quorum_selectquorum(cl: &Client) {
         .unwrap();
 }
 
+#[allow(dead_code)]
 fn test_get_quorum_verify(cl: &Client) {
     let _quorum_verify = cl.get_quorum_verify(
         LlmqTest,
@@ -1513,6 +1524,7 @@ fn test_get_protx_diff(cl: &Client) {
     let _protx_diff = cl.get_protx_diff(1000, 1000).unwrap();
 }
 
+#[allow(dead_code)]
 fn test_get_protx_info(cl: &Client) {
     let pro_tx_hash =
         ProTxHash::from_str("000000000c9eddd5d2a707281b7e30d5aac974dac600ff10f01937e1ca36066f")
@@ -1538,6 +1550,7 @@ fn test_get_protx_list(cl: &Client) {
         cl.get_protx_list(Some(ProTxListType::Valid), Some(true), Some(1000)).unwrap();
 }
 
+#[allow(dead_code)]
 fn test_get_protx_register(cl: &Client) {
     let _protx_register = cl.get_protx_register(
         "8b2eab3413abb6e04d17d1defe2b71039ba6b6f72ea1e5dab29bb10e7b745948",
@@ -1553,11 +1566,13 @@ fn test_get_protx_register(cl: &Client) {
     ).unwrap();
 }
 
+#[allow(dead_code)]
 fn test_get_protx_register_fund(cl: &Client) {
     let _protx_register_fund = cl.get_protx_register_fund("yakx4mMRptKhgfjedNzX5FGQq7kSSBF2e7", "3.4.5.6:3456", "yURczr3qY31xkQZfFu8eZvKz19eAEPQxsd", "0e02146e9c34cfbcb3f3037574a1abb35525e2ca0c3c6901dbf82ac591e30218d1711223b7ca956edf39f3d984d06d51", "yURczr3qY31xkQZfFu8eZvKz19eAEPQxsd",
                                                           5.0, "yUYTxqjpCfAAK4vgxXtBPywRBtZqsxN7Vy", Some("yRMFHxcJ2aS2vfo5whhE2Gg73dfQVm8LAF"), Some(false)).unwrap();
 }
 
+#[allow(dead_code)]
 fn test_get_protx_register_prepare(cl: &Client) {
     let owner_address = Address::<NetworkUnchecked>::from_str("yemjhGQ99V5ayJMjoyGGPtxteahii6G1Jz")
         .unwrap()
@@ -1589,13 +1604,15 @@ fn test_get_protx_register_prepare(cl: &Client) {
     ).unwrap();
 }
 
+#[allow(dead_code)]
 fn test_get_protx_register_submit(cl: &Client) {
     let _protx_register_submit = cl.get_protx_register_submit(
         "03000100012d988526d5d1efd32320023c92eff09c2963dcb021b0de9761",
         "H90IvqVtFjZkwLJb08yMEgGixs0/FpcdvwImBcir4cYLJhD3pdX+lKD2GsPl6KNxghVXNk5/HpOdBoWAHo9u++Y=",
     ).unwrap();
 }
 
+#[allow(dead_code)]
 fn test_get_protx_revoke(cl: &Client) {
     let _protx_revoke = cl
         .get_protx_revoke(
@@ -1607,6 +1624,7 @@ fn test_get_protx_revoke(cl: &Client) {
         .unwrap();
 }
 
+#[allow(dead_code)]
 fn test_get_protx_update_registrar(cl: &Client) {
     let voting_address =
         Address::<NetworkUnchecked>::from_str("yX2cDS4kcJ4LK4uq9Hd4TG7kURV3sGLZrw")
@@ -1623,6 +1641,7 @@ fn test_get_protx_update_registrar(cl: &Client) {
     ).unwrap();
 }
 
+#[allow(dead_code)]
 fn test_get_protx_update_service(cl: &Client) {
     let _protx_update_service = cl
         .get_protx_update_service(
@@ -1635,6 +1654,7 @@ fn test_get_protx_update_service(cl: &Client) {
         .unwrap();
 }
 
+#[allow(dead_code)]
 fn test_get_verifychainlock(cl: &Client) {
     let _verifychainlock = cl.get_verifychainlock("00000036d5c520be6e9a32d3829efc983a7b5e88052bf138f80a2b3988689a24", "97ec34efd1615b84af62495e54024880752f57790cf450ae974b80002440963592d96826e24f109e6c149411b70bb9a0035443752368590adae60365cf4251464e0423c1263e9c56a33eae9be9e9c79a117151b2173bcee93497008cace8d793", None).unwrap();
 }
@@ -1645,6 +1665,7 @@ fn test_get_asset_unlock_statuses(cl: &Client) {
     let _statuses = cl.get_asset_unlock_statuses(&indices, height);
 }
 
+#[allow(dead_code)]
 fn test_get_verifyislock(cl: &Client) {
     let _verifychainlock = cl.get_verifyislock("d0b1a9c70fdfff6bf7f6cbe3d1fe33a4ca44ceb17059b6381a4ac25d9c9b6495", "8b5174d0e95b5642ebec23c3fe8f0bbf8f6993502f4210322871bba0e818ff3b", "97ec34efd1615b84af62495e54024880752f57790cf450ae974b80002440963592d96826e24f109e6c149411b70bb9a0035443752368590adae60365cf4251464e0423c1263e9c56a33eae9be9e9c79a117151b2173bcee93497008cace8d793", None).unwrap();
 }

rpc-json/src/lib.rs

@@ -3270,10 +3270,10 @@ mod tests {
         }
 
         let json = r#"{"field": 1}"#;
-        let result: Test = serde_json::from_str(&json).unwrap();
+        let result: Test = serde_json::from_str(json).unwrap();
         assert_eq!(result.field, Some(1));
         let json = r#"{"field": -1}"#;
-        let result: Test = serde_json::from_str(&json).unwrap();
+        let result: Test = serde_json::from_str(json).unwrap();
         assert_eq!(result.field, None);
     }
 
@@ -3294,7 +3294,7 @@ mod tests {
         let result: ExtendedQuorumListResult =
             serde_json::from_str(json_list).expect("expected to deserialize json");
         let first_type = result.quorums_by_type.get(&QuorumType::Llmq50_60).unwrap();
-        let first_quorum = first_type.into_iter().nth(0).unwrap();
+        let first_quorum = first_type.iter().next().unwrap();
 
         assert_eq!(
             first_quorum.0.to_byte_array(),
@@ -3424,7 +3424,7 @@ mod tests {
               ]
             }"#;
         let result: MasternodeListDiff =
-            serde_json::from_str(&json).expect("expected to deserialize json");
+            serde_json::from_str(json).expect("expected to deserialize json");
         println!("{:#?}", result);
         assert_eq!(32, result.added_mns[0].pro_tx_hash.as_byte_array().len());