renamed and removed old documentation for store_headers_impl

Author: ZocoLini

dash-spv/src/storage/disk/headers.rs

@@ -35,12 +35,8 @@ impl DiskStorageManager {
 
         Ok(())
     }
-    /// Store headers with optional precomputed hashes for performance optimization.
-    ///
-    /// This is a performance optimization for hot paths that have already computed header hashes.
-    /// When called from header sync with CachedHeader wrappers, passing precomputed hashes avoids
-    /// recomputing the expensive X11 hash for indexing (saves ~35% of CPU during sync).
-    pub async fn store_headers_internal(&mut self, headers: &[BlockHeader]) -> StorageResult<()> {
+
+    pub async fn store_headers(&mut self, headers: &[BlockHeader]) -> StorageResult<()> {
         let height = self.block_headers.read().await.next_height();
         self.store_headers_at_height(headers, height).await
     }

dash-spv/src/storage/disk/state.rs

@@ -28,7 +28,7 @@ impl DiskStorageManager {
             // Store headers starting at the checkpoint height
             self.store_headers_at_height(&state.headers, state.sync_base_height).await?;
         } else {
-            self.store_headers_internal(&state.headers).await?;
+            self.store_headers(&state.headers).await?;
         }
 
         // Store filter headers
@@ -528,7 +528,7 @@ impl StorageManager for DiskStorageManager {
     }
 
     async fn store_headers(&mut self, headers: &[BlockHeader]) -> StorageResult<()> {
-        self.store_headers_internal(headers).await
+        self.store_headers(headers).await
     }
 
     async fn load_headers(&self, range: std::ops::Range<u32>) -> StorageResult<Vec<BlockHeader>> {

dash-spv/src/sync/headers/manager.rs

@@ -258,7 +258,7 @@ impl<S: StorageManager + Send + Sync + 'static, N: NetworkManager + Send + Sync
             storage.as_any_mut().downcast_mut::<crate::storage::disk::DiskStorageManager>()
         {
             disk_storage
-                .store_headers_internal(&headers)
+                .store_headers(&headers)
                 .await
                 .map_err(|e| SyncError::Storage(format!("Failed to store headers batch: {}", e)))?;
         } else {