chore: Drop persistent sync state (#279)

* removed version from PersistentSyncState

* removed persist and recovery logic of teh ChainState

* dropped dead code in sync_state

* removed logic to store sync state

* sync_state.rs deleted

* ffi docs udpated

Author: ZocoLini

dash-spv-ffi/FFI_API.md

@@ -4,7 +4,7 @@ This document provides a comprehensive reference for all FFI (Foreign Function I
 
 **Auto-generated**: This documentation is automatically generated from the source code. Do not edit manually.
 
-**Total Functions**: 71
+**Total Functions**: 70
 
 ## Table of Contents
 
@@ -68,12 +68,11 @@ Functions: 27
 
 ### Synchronization
 
-Functions: 8
+Functions: 7
 
 | Function | Description | Module |
 |----------|-------------|--------|
 | `dash_spv_ffi_client_cancel_sync` | Cancels the sync operation | client |
-| `dash_spv_ffi_client_clear_sync_state` | Clear only the persisted sync-state snapshot | client |
 | `dash_spv_ffi_client_get_sync_progress` | Get the current sync progress snapshot | client |
 | `dash_spv_ffi_client_is_filter_sync_available` | Check if compact filter sync is currently available | client |
 | `dash_spv_ffi_client_sync_to_tip` | Sync the SPV client to the chain tip | client |
@@ -664,22 +663,6 @@ The client pointer must be valid and non-null.
 
 ---
 
-#### `dash_spv_ffi_client_clear_sync_state`
-
-```c
-dash_spv_ffi_client_clear_sync_state(client: *mut FFIDashSpvClient,) -> i32
-```
-
-**Description:**
-Clear only the persisted sync-state snapshot.  # Safety - `client` must be a valid, non-null pointer.
-
-**Safety:**
-- `client` must be a valid, non-null pointer.
-
-**Module:** `client`
-
----
-
 #### `dash_spv_ffi_client_get_sync_progress`
 
 ```c

dash-spv-ffi/include/dash_spv_ffi.h

@@ -457,14 +457,6 @@ int32_t dash_spv_ffi_client_sync_to_tip_with_progress(struct FFIDashSpvClient *c
  */
  int32_t dash_spv_ffi_client_clear_storage(struct FFIDashSpvClient *client) ;
 
-/**
- * Clear only the persisted sync-state snapshot.
- *
- * # Safety
- * - `client` must be a valid, non-null pointer.
- */
- int32_t dash_spv_ffi_client_clear_sync_state(struct FFIDashSpvClient *client) ;
-
 /**
  * Check if compact filter sync is currently available.
  *

dash-spv-ffi/src/client.rs

@@ -1222,45 +1222,6 @@ pub unsafe extern "C" fn dash_spv_ffi_client_clear_storage(client: *mut FFIDashS
     }
 }
 
-/// Clear only the persisted sync-state snapshot.
-///
-/// # Safety
-/// - `client` must be a valid, non-null pointer.
-#[no_mangle]
-pub unsafe extern "C" fn dash_spv_ffi_client_clear_sync_state(
-    client: *mut FFIDashSpvClient,
-) -> i32 {
-    null_check!(client);
-
-    let client = &(*client);
-    let inner = client.inner.clone();
-
-    let result = client.runtime.block_on(async {
-        let mut spv_client = {
-            let mut guard = inner.lock().unwrap();
-            match guard.take() {
-                Some(c) => c,
-                None => {
-                    return Err(dash_spv::SpvError::Config("Client not initialized".to_string()))
-                }
-            }
-        };
-
-        let res = spv_client.clear_sync_state().await;
-        let mut guard = inner.lock().unwrap();
-        *guard = Some(spv_client);
-        res
-    });
-
-    match result {
-        Ok(_) => FFIErrorCode::Success as i32,
-        Err(e) => {
-            set_last_error(&e.to_string());
-            FFIErrorCode::from(e) as i32
-        }
-    }
-}
-
 /// Check if compact filter sync is currently available.
 ///
 /// # Safety

dash-spv/src/client/core.rs

@@ -144,7 +144,6 @@ pub struct DashSpvClient<W: WalletInterface, N: NetworkManager, S: StorageManage
     pub(super) event_rx: Option<mpsc::UnboundedReceiver<SpvEvent>>,
     pub(super) mempool_state: Arc<RwLock<MempoolState>>,
     pub(super) mempool_filter: Option<Arc<MempoolFilter>>,
-    pub(super) last_sync_state_save: Arc<RwLock<u64>>,
 }
 
 impl<
@@ -272,12 +271,6 @@ impl<
         Ok(())
     }
 
-    /// Clear only the persisted sync state snapshot (keep headers/filters).
-    pub async fn clear_sync_state(&mut self) -> Result<()> {
-        let mut storage = self.storage.lock().await;
-        storage.clear_sync_state().await.map_err(SpvError::Storage)
-    }
-
     /// Clear all stored filter headers and compact filters while keeping other data intact.
     pub async fn clear_filters(&mut self) -> Result<()> {
         {

dash-spv/src/client/lifecycle.rs

@@ -95,7 +95,6 @@ impl<
             event_rx: Some(event_rx),
             mempool_state,
             mempool_filter: None,
-            last_sync_state_save: Arc::new(RwLock::new(0)),
         })
     }
 
@@ -163,29 +162,6 @@ impl<
             tracing::info!("📊 Sequential sync mode: filter processing handled internally");
         }
 
-        // Try to restore sync state from persistent storage
-        if self.config.enable_persistence {
-            match self.restore_sync_state().await {
-                Ok(restored) => {
-                    if restored {
-                        tracing::info!(
-                            "✅ Successfully restored sync state from persistent storage"
-                        );
-                    } else {
-                        tracing::info!("No previous sync state found, starting fresh sync");
-                    }
-                }
-                Err(e) => {
-                    tracing::error!("Failed to restore sync state: {}", e);
-                    tracing::warn!("Starting fresh sync due to state restoration failure");
-                    // Clear any corrupted state
-                    if let Err(clear_err) = self.storage.lock().await.clear_sync_state().await {
-                        tracing::error!("Failed to clear corrupted sync state: {}", clear_err);
-                    }
-                }
-            }
-        }
-
         // Initialize genesis block if not already present
         self.initialize_genesis_block().await?;
 
@@ -262,14 +238,6 @@ impl<
             }
         }
 
-        // Save sync state before shutting down
-        if let Err(e) = self.save_sync_state().await {
-            tracing::error!("Failed to save sync state during shutdown: {}", e);
-            // Continue with shutdown even if state save fails
-        } else {
-            tracing::info!("Sync state saved successfully during shutdown");
-        }
-
         // Disconnect from network
         self.network.disconnect().await?;