add ffi-c-tests github workflow with the validation headers job

Author: ZocoLini

.github/workflows/build-and-test.yml

@@ -90,3 +90,8 @@ jobs:
           path: ${{ runner.temp }}/dashd-test-logs/
           retention-days: 7
           if-no-files-found: ignore
+      - name: Validate headers
+        if: matrix.group == 'ffi' && inputs.os == 'ubuntu-latest'
+        run: |
+          sudo apt update && sudo apt install -y build-essential
+          bash ffi-c-tests/validate-headers.sh

ffi-c-tests/test.sh ffi-c-tests/validate-headers.shffi-c-tests/test.sh renamed to ffi-c-tests/validate-headers.sh

@@ -11,17 +11,17 @@ HEADER_TESTS_DIR="$SCRIPT_DIR/header-tests"
 TARGET_DIR="$SCRIPT_DIR/../target"
 LIB_DIR="$TARGET_DIR/debug"
 
-# Build FFI crates to generate static libraries and header files
-cargo build -p dash-spv-ffi --profile dev
-cargo build -p key-wallet-ffi --profile dev
+# Build FFI crates to generate static libraries and header files if they dont yet exist
+cargo rustc -p dash-spv-ffi --lib --crate-type staticlib
+cargo rustc -p key-wallet-ffi --lib --crate-type staticlib
 
 # Move to ffi-c-tests directory, where the script lives, and run tests
 cd "$SCRIPT_DIR" || exit 1
 
 EXIT_CODE=0
 
 for file in "$HEADER_TESTS_DIR"/*.c; do
-    if gcc "$file" -o test.bin -g -L"$LIB_DIR" -ldash_spv_ffi -lkey_wallet_ffi; then
+    if gcc "$file" -o test.bin -g -L"$LIB_DIR" -ldash_spv_ffi -lkey_wallet_ffi -lm; then
       echo -e "${GREEN}Passed: $file${NC}"
     else
       echo -e "${RED}Failed: $file${NC}"

key-wallet-ffi/src/transaction.rs

@@ -1003,9 +1003,13 @@ impl From<FFIAssetLockFundingType> for AssetLockFundingType {
         match ffi {
             FFIAssetLockFundingType::IdentityRegistrationFundingType => Self::IdentityRegistration,
             FFIAssetLockFundingType::IdentityTopUpFundingType => Self::IdentityTopUp,
-            FFIAssetLockFundingType::IdentityTopUpNotBoundFundingType => Self::IdentityTopUpNotBound,
+            FFIAssetLockFundingType::IdentityTopUpNotBoundFundingType => {
+                Self::IdentityTopUpNotBound
+            }
             FFIAssetLockFundingType::IdentityInvitationFundingType => Self::IdentityInvitation,
-            FFIAssetLockFundingType::AssetLockAddressTopUpFundingType => Self::AssetLockAddressTopUp,
+            FFIAssetLockFundingType::AssetLockAddressTopUpFundingType => {
+                Self::AssetLockAddressTopUp
+            }
             FFIAssetLockFundingType::AssetLockShieldedAddressTopUpFundingType => {
                 Self::AssetLockShieldedAddressTopUp
             }