fix: correct confirmations for UTXOs in wallet FFI

Author: xdustinface

key-wallet-ffi/src/utxo.rs

@@ -1,12 +1,12 @@
 //! UTXO management
 
+use crate::error::{FFIError, FFIErrorCode};
+use crate::managed_wallet::FFIManagedWalletInfo;
+use key_wallet::wallet::managed_wallet_info::wallet_info_interface::WalletInfoInterface;
 use std::ffi::CString;
 use std::os::raw::c_char;
 use std::ptr;
 
-use crate::error::{FFIError, FFIErrorCode};
-use crate::managed_wallet::FFIManagedWalletInfo;
-
 /// UTXO structure for FFI
 #[repr(C)]
 pub struct FFIUTXO {
@@ -119,9 +119,9 @@ pub unsafe extern "C" fn managed_wallet_get_utxos(
             // Get script bytes
             let script_bytes = utxo.txout.script_pubkey.as_bytes().to_vec();
 
-            // Calculate confirmations (0 if unconfirmed)
-            let confirmations = if utxo.is_confirmed {
-                1
+            let current_height = managed_info.inner().synced_height();
+            let confirmations = if utxo.is_confirmed && utxo.height > 0 {
+                current_height.saturating_sub(utxo.height) + 1
             } else {
                 0
             };

key-wallet-ffi/src/utxo_tests.rs

@@ -229,8 +229,8 @@ mod utxo_tests {
 
         managed_info.accounts.insert(bip44_account);
 
-        let ffi_managed_info = FFIManagedWalletInfo::new(managed_info);
-
+        let mut ffi_managed_info = FFIManagedWalletInfo::new(managed_info);
+        ffi_managed_info.inner_mut().update_chain_height(300);
         let result = unsafe {
             managed_wallet_get_utxos(&ffi_managed_info, &mut utxos_out, &mut count_out, error)
         };
@@ -249,19 +249,21 @@ mod utxo_tests {
             assert_eq!(utxos[0].vout, 0);
             assert_eq!(utxos[0].amount, 50000);
             assert_eq!(utxos[0].height, 100);
-            assert_eq!(utxos[0].confirmations, 1);
+            assert_eq!(utxos[0].confirmations, 201);
 
             // Check second UTXO
             assert_eq!(utxos[1].txid[0], 1);
             assert_eq!(utxos[1].vout, 1);
             assert_eq!(utxos[1].amount, 100000);
             assert_eq!(utxos[1].height, 101);
+            assert_eq!(utxos[1].confirmations, 200);
 
             // Check third UTXO
             assert_eq!(utxos[2].txid[0], 2);
             assert_eq!(utxos[2].vout, 2);
             assert_eq!(utxos[2].amount, 150000);
             assert_eq!(utxos[2].height, 102);
+            assert_eq!(utxos[2].confirmations, 199);
         }
 
         // Clean up