fix: address Windows filename issues

Use underscore instead of colon or dots since they are not allowed in filenames in Windows.

This is are some of the fixes required for Windows support which gets introduced/tested in the CI overhaul PR #253.

Author: xdustinface

dash-spv/src/chain/chainlock_manager.rs

@@ -333,7 +333,7 @@ impl ChainLockManager {
         }
 
         // Store persistently
-        let key = format!("chainlock:{}", chain_lock.block_height);
+        let key = format!("chainlock_{}", chain_lock.block_height);
         let data = bincode::serialize(&chain_lock)
             .map_err(|e| StorageError::Serialization(e.to_string()))?;
         storage.store_metadata(&key, &data).await?;
@@ -414,7 +414,7 @@ impl ChainLockManager {
         let mut chain_locks = Vec::new();
 
         for height in start_height..=end_height {
-            let key = format!("chainlock:{}", height);
+            let key = format!("chainlock_{}", height);
             if let Some(data) = storage.load_metadata(&key).await? {
                 match bincode::deserialize::<ChainLock>(&data) {
                     Ok(chain_lock) => {

dash-spv/src/storage/io.rs

@@ -14,7 +14,7 @@ fn get_temp_path(path: &Path) -> PathBuf {
     let file_name = path.file_name().and_then(|n| n.to_str()).unwrap_or("temp");
     let unique_id = COUNTER.fetch_add(1, Ordering::Relaxed);
     let pid = std::process::id();
-    temp_path.set_file_name(format!(".{}.{}.{}.tmp", file_name, pid, unique_id));
+    temp_path.set_file_name(format!("tmp_{}_{}_{}_.tmp", file_name, pid, unique_id));
     temp_path
 }
 
@@ -75,10 +75,10 @@ mod tests {
         // Check temp file is in same directory as original
         assert_eq!(temp1.parent(), path.parent());
 
-        // Check temp file name starts with dot and ends with .tmp
+        // Check temp file name starts with tmp_ and ends with .tmp
         let file_name = temp1.file_name().unwrap().to_string_lossy();
-        assert!(file_name.starts_with(".file.dat."));
-        assert!(file_name.ends_with(".tmp"));
+        assert!(file_name.starts_with("tmp_file.dat_"));
+        assert!(file_name.ends_with("_.tmp"));
     }
 
     #[tokio::test]