feat: migrate from bls-signatures to blsful library

- Replace bls-signatures with blsful (dashpay/agora-blsful) for BLS operations
- Add support for legacy BLS format in quorum validation
- Update verify_aggregated_commitment_signature to use blsful API
- Remove all bls-signatures dependencies and error types
- Add comprehensive tests for BLS format compatibility

The migration uses dashpay/agora-blsful with main branch
to maintain compatibility with both legacy and modern BLS key formats.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

Author: 2 people

Cargo.toml

@@ -8,5 +8,8 @@ version = "0.39.6"
 [patch.crates-io.dashcore_hashes]
 path = "hashes"
 
+[patch.crates-io]
+blsful = { git = "https://github.com/dashpay/agora-blsful", rev = "5f017aa1a0452ebc73e47f219f50c906522df4ea" }
+
 
 

dash/Cargo.toml

@@ -30,7 +30,7 @@ signer = ["secp-recovery", "rand", "base64"]
 core-block-hash-use-x11 = ["dashcore_hashes/x11"]
 bls = ["blsful"]
 eddsa = ["ed25519-dalek"]
-quorum_validation = ["bls", "bls-signatures"]
+quorum_validation = ["bls"]
 message_verification = ["bls"]
 bincode = [ "dep:bincode", "dep:bincode_derive", "dashcore_hashes/bincode", "dash-network/bincode" ]
 
@@ -66,12 +66,11 @@ hex = { version= "0.4" }
 bincode = { version= "=2.0.0-rc.3", optional = true }
 bincode_derive = { version= "=2.0.0-rc.3", optional = true }
 bitflags = "2.9.0"
-blsful = { version = "3.0.0-pre8", optional = true }
+blsful = { git = "https://github.com/dashpay/agora-blsful", rev = "5f017aa1a0452ebc73e47f219f50c906522df4ea", optional = true }
 ed25519-dalek = { version = "2.1", features = ["rand_core"], optional = true }
 blake3 = "1.8.1"
 thiserror = "2"
-# version 1.3.5 is 0bb5c5b03249c463debb5cef5f7e52ee66f3aaab
-bls-signatures = { git = "https://github.com/dashpay/bls-signatures", rev = "0bb5c5b03249c463debb5cef5f7e52ee66f3aaab", optional = true }
+# bls-signatures removed during migration to agora-blsful
 
 [dev-dependencies]
 serde_json = "1.0.140"

dash/src/base58.rs

@@ -52,9 +52,6 @@ pub enum Error {
     // TODO: Remove this as part of crate-smashing, there should not be any key related errors in this module
     Hex(hex::Error),
 
-    /// bls signatures related error
-    #[cfg(feature = "bls-signatures")]
-    BLSError(String),
     /// edwards 25519 related error
     #[cfg(feature = "ed25519-dalek")]
     Ed25519Dalek(String),
@@ -80,8 +77,6 @@ impl fmt::Display for Error {
             Error::TooShort(_) => write!(f, "base58ck data not even long enough for a checksum"),
             Error::Secp256k1(ref e) => fmt::Display::fmt(&e, f),
             Error::Hex(ref e) => write!(f, "Hexadecimal decoding error: {}", e),
-            #[cfg(feature = "bls-signatures")]
-            Error::BLSError(ref e) => write!(f, "BLS error: {}", e),
             #[cfg(feature = "ed25519-dalek")]
             Error::Ed25519Dalek(ref e) => write!(f, "Ed25519-Dalek error: {}", e),
             Error::NotSupported(ref e) => write!(f, "Not supported: {}", e),

dash/src/crypto/key.rs

@@ -43,9 +43,6 @@ pub enum Error {
     Base58(base58::Error),
     /// secp256k1-related error
     Secp256k1(secp256k1::Error),
-    /// bls signatures related error
-    #[cfg(feature = "bls-signatures")]
-    BLSError(String),
     /// edwards 25519 related error
     #[cfg(feature = "ed25519-dalek")]
     Ed25519Dalek(String),
@@ -72,8 +69,6 @@ impl fmt::Display for Error {
             Error::NotSupported(string) => {
                 write!(f, "{}", string.as_str())
             }
-            #[cfg(feature = "bls-signatures")]
-            Error::BLSError(string) => write!(f, "{}", string.as_str()),
             #[cfg(feature = "ed25519-dalek")]
             Error::Ed25519Dalek(string) => write!(f, "{}", string.as_str()),
         }
@@ -91,8 +86,6 @@ impl std::error::Error for Error {
             Hex(e) => Some(e),
             InvalidKeyPrefix(_) | InvalidHexLength(_) => None,
             NotSupported(_) => None,
-            #[cfg(feature = "bls-signatures")]
-            BLSError(_) => None,
             #[cfg(feature = "ed25519-dalek")]
             Ed25519Dalek(_) => None,
         }

dash/src/lib.rs

@@ -76,8 +76,6 @@ pub extern crate bitcoinconsensus;
 pub extern crate dashcore_hashes as hashes;
 pub extern crate secp256k1;
 
-#[cfg(feature = "bls-signatures")]
-pub use bls_signatures;
 #[cfg(feature = "blsful")]
 pub use blsful;
 #[cfg(feature = "ed25519-dalek")]