chore: Remove MemoryStorageManager (#275)

* removed in memory storage manager

* tests related to on memory storage removed, we understand that it taste the same operations as the diskstoragemanager. next time use generics pls

* storage with tempo dir constructor renamed

* using different storage folders in examples

Author: ZocoLini

dash-spv/CLAUDE.md

@@ -107,9 +107,8 @@ The `SyncManager` coordinates all synchronization through a phase-based approach
 Each phase must complete before the next begins, ensuring consistency and simplifying error recovery.
 
 ### Storage Backends
-Two storage implementations via the `StorageManager` trait:
-- `MemoryStorageManager`: In-memory storage for testing
-- `DiskStorageManager`: Persistent disk storage for production
+One storage implementation via the `StorageManager` trait:
+- `DiskStorageManager`: Persistent disk storage
 
 ### Network Layer
 TCP-based networking with proper Dash protocol implementation:

dash-spv/CODE_ANALYSIS_SUMMARY.md

@@ -215,7 +215,7 @@
 **Test Types:**
 - **Unit Tests**: Individual functions/modules (in-file with `#[cfg(test)]`)
 - **Integration Tests**: Cross-module interactions (`tests/` directory)
-- **Mock Tests**: Use MockNetworkManager, MemoryStorageManager
+- **Mock Tests**: Use MockNetworkManager, DiskStorageManager::new_tmp
 - **Property Tests**: Invariant testing (could add more with proptest)
 
 ---

dash-spv/examples/filter_sync.rs

@@ -1,7 +1,7 @@
 //! BIP157 filter synchronization example.
 
 use dash_spv::network::PeerNetworkManager;
-use dash_spv::storage::MemoryStorageManager;
+use dash_spv::storage::DiskStorageManager;
 use dash_spv::{init_console_logging, ClientConfig, DashSpvClient, LevelFilter};
 use dashcore::Address;
 use key_wallet::wallet::managed_wallet_info::ManagedWalletInfo;
@@ -28,7 +28,8 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
     let network_manager = PeerNetworkManager::new(&config).await?;
 
     // Create storage manager
-    let storage_manager = MemoryStorageManager::new().await?;
+    let storage_manager =
+        DiskStorageManager::new("./.tmp/filter-sync-example-storage".into()).await?;
 
     // Create wallet manager
     let wallet = Arc::new(RwLock::new(WalletManager::<ManagedWalletInfo>::new()));

dash-spv/examples/simple_sync.rs

@@ -1,7 +1,7 @@
 //! Simple header synchronization example.
 
 use dash_spv::network::PeerNetworkManager;
-use dash_spv::storage::MemoryStorageManager;
+use dash_spv::storage::DiskStorageManager;
 use dash_spv::{init_console_logging, ClientConfig, DashSpvClient, LevelFilter};
 use key_wallet::wallet::managed_wallet_info::ManagedWalletInfo;
 
@@ -24,7 +24,8 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
     let network_manager = PeerNetworkManager::new(&config).await?;
 
     // Create storage manager
-    let storage_manager = MemoryStorageManager::new().await?;
+    let storage_manager =
+        DiskStorageManager::new("./.tmp/simple-sync-example-storage".into()).await?;
 
     // Create wallet manager
     let wallet = Arc::new(RwLock::new(WalletManager::<ManagedWalletInfo>::new()));

dash-spv/examples/spv_with_wallet.rs

@@ -26,7 +26,8 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
     let network_manager = PeerNetworkManager::new(&config).await?;
 
     // Create storage manager - use disk storage for persistence
-    let storage_manager = DiskStorageManager::new("/tmp/dash-spv-example".into()).await?;
+    let storage_manager =
+        DiskStorageManager::new("./.tmp/spv-with-wallet-example-storage".into()).await?;
 
     // Create wallet manager
     let wallet = Arc::new(RwLock::new(WalletManager::<ManagedWalletInfo>::new()));

dash-spv/src/chain/chainlock_test.rs

@@ -1,16 +1,15 @@
 #[cfg(test)]
 mod tests {
     use super::super::*;
-    use crate::storage::MemoryStorageManager;
-    use crate::types::ChainState;
+    use crate::{storage::DiskStorageManager, types::ChainState};
     use dashcore::{BlockHash, ChainLock, Network};
     use dashcore_hashes::Hash;
 
     #[tokio::test]
     async fn test_chainlock_processing() {
         // Create storage and ChainLock manager
         let mut storage =
-            MemoryStorageManager::new().await.expect("Failed to create memory storage");
+            DiskStorageManager::with_temp_dir().await.expect("Failed to create tmp storage");
         let chainlock_manager = ChainLockManager::new(true);
         let chain_state = ChainState::new_for_network(Network::Testnet);
 
@@ -43,7 +42,7 @@ mod tests {
     #[tokio::test]
     async fn test_chainlock_superseding() {
         let mut storage =
-            MemoryStorageManager::new().await.expect("Failed to create memory storage");
+            DiskStorageManager::with_temp_dir().await.expect("Failed to create tmp storage");
         let chainlock_manager = ChainLockManager::new(true);
         let chain_state = ChainState::new_for_network(Network::Testnet);
 
@@ -83,7 +82,7 @@ mod tests {
         let chainlock_manager = ChainLockManager::new(true);
         let chain_state = ChainState::new_for_network(Network::Testnet);
         let mut storage =
-            MemoryStorageManager::new().await.expect("Failed to create memory storage");
+            DiskStorageManager::with_temp_dir().await.expect("Failed to create tmp storage");
 
         // Add ChainLocks at heights 1000, 2000, 3000
         for height in [1000, 2000, 3000] {

dash-spv/src/client/block_processor_test.rs

@@ -4,8 +4,7 @@
 mod tests {
     use crate::client::block_processor::{BlockProcessingTask, BlockProcessor};
 
-    use crate::storage::memory::MemoryStorageManager;
-    use crate::storage::StorageManager;
+    use crate::storage::DiskStorageManager;
     use crate::types::{SpvEvent, SpvStats};
     use dashcore::{blockdata::constants::genesis_block, Block, Network, Transaction};
 
@@ -92,17 +91,19 @@ mod tests {
     }
 
     async fn setup_processor() -> (
-        BlockProcessor<MockWallet, MemoryStorageManager>,
+        BlockProcessor<MockWallet, DiskStorageManager>,
         mpsc::UnboundedSender<BlockProcessingTask>,
         mpsc::UnboundedReceiver<SpvEvent>,
         Arc<RwLock<MockWallet>>,
-        Arc<Mutex<MemoryStorageManager>>,
+        Arc<Mutex<DiskStorageManager>>,
     ) {
         let (task_tx, task_rx) = mpsc::unbounded_channel();
         let (event_tx, event_rx) = mpsc::unbounded_channel();
         let stats = Arc::new(RwLock::new(SpvStats::default()));
         let wallet = Arc::new(RwLock::new(MockWallet::new()));
-        let storage = Arc::new(Mutex::new(MemoryStorageManager::new().await.unwrap()));
+        let storage = Arc::new(Mutex::new(
+            DiskStorageManager::with_temp_dir().await.expect("Failed to create tmp storage"),
+        ));
         let processor = BlockProcessor::new(
             task_rx,
             wallet.clone(),
@@ -305,7 +306,9 @@ mod tests {
         let (event_tx, mut event_rx) = mpsc::unbounded_channel();
         let stats = Arc::new(RwLock::new(SpvStats::default()));
         let wallet = Arc::new(RwLock::new(NonMatchingWallet {}));
-        let storage = Arc::new(Mutex::new(MemoryStorageManager::new().await.unwrap()));
+        let storage = Arc::new(Mutex::new(
+            DiskStorageManager::with_temp_dir().await.expect("Failed to create tmp storage"),
+        ));
 
         let processor =
             BlockProcessor::new(task_rx, wallet, storage, stats, event_tx, Network::Dash);

dash-spv/src/client/core.rs

@@ -52,7 +52,7 @@ use super::{BlockProcessingTask, ClientConfig, StatusDisplay};
 /// - Essential for a reusable library
 ///
 /// ### 4. **Testing Without Mocks** 🧪
-/// - Test implementations (`MockNetworkManager`, `MemoryStorageManager`) are
+/// - Test implementations (`MockNetworkManager`) are
 ///   first-class types, not runtime injections
 /// - No conditional compilation or feature flags needed for tests
 /// - Type system ensures test and production code are compatible
@@ -84,7 +84,7 @@ use super::{BlockProcessingTask, ClientConfig, StatusDisplay};
 /// type TestSpvClient = DashSpvClient<
 ///     WalletManager,
 ///     MockNetworkManager,
-///     MemoryStorageManager,
+///     DiskStorageManager,
 /// >;
 /// ```
 ///

dash-spv/src/client/message_handler_test.rs

@@ -9,7 +9,6 @@ mod tests {
     use crate::mempool_filter::MempoolFilter;
     use crate::network::mock::MockNetworkManager;
     use crate::network::NetworkManager;
-    use crate::storage::memory::MemoryStorageManager;
     use crate::storage::StorageManager;
     use crate::sync::filters::FilterNotificationSender;
     use crate::sync::SyncManager;
@@ -41,11 +40,11 @@ mod tests {
     ) {
         let network = Box::new(MockNetworkManager::new()) as Box<dyn NetworkManager>;
         let storage =
-            Box::new(MemoryStorageManager::new().await.unwrap()) as Box<dyn StorageManager>;
+            Box::new(DiskStorageManager::with_temp_dir().await.expect("Failed to create tmp storage")) as Box<dyn StorageManager>;
         let config = ClientConfig::default();
         let stats = Arc::new(RwLock::new(SpvStats::default()));
         let (block_tx, _block_rx) = mpsc::unbounded_channel();
-        let wallet_storage = Arc::new(RwLock::new(MemoryStorageManager::new().await.unwrap()));
+        let wallet_storage = Arc::new(RwLock::new(DiskStorageManager::with_temp_dir().await.expect("Failed to create tmp storage")));
         let wallet = Arc::new(RwLock::new(Wallet::new(wallet_storage)));
         let mempool_state = Arc::new(RwLock::new(MempoolState::default()));
         let (event_tx, _event_rx) = mpsc::unbounded_channel();

dash-spv/src/client/mod.rs

@@ -70,9 +70,8 @@ mod message_handler_test;
 #[cfg(test)]
 mod tests {
     use super::{ClientConfig, DashSpvClient};
-    use crate::network::mock::MockNetworkManager;
-    use crate::storage::MemoryStorageManager;
     use crate::types::UnconfirmedTransaction;
+    use crate::{network::mock::MockNetworkManager, storage::DiskStorageManager};
     use dashcore::{Amount, Network, Transaction, TxOut};
     use key_wallet::wallet::managed_wallet_info::ManagedWalletInfo;
     use key_wallet_manager::wallet_manager::WalletManager;
@@ -96,7 +95,8 @@ mod tests {
         };
 
         let network_manager = MockNetworkManager::new();
-        let storage = MemoryStorageManager::new().await.expect("memory storage should initialize");
+        let storage =
+            DiskStorageManager::with_temp_dir().await.expect("Failed to create tmp storage");
         let wallet = Arc::new(RwLock::new(WalletManager::<ManagedWalletInfo>::new()));
 
         let client = DashSpvClient::new(config, network_manager, storage, wallet)
@@ -123,7 +123,8 @@ mod tests {
         };
 
         let network_manager = MockNetworkManager::new();
-        let storage = MemoryStorageManager::new().await.expect("memory storage should initialize");
+        let storage =
+            DiskStorageManager::with_temp_dir().await.expect("Failed to create tmp storage");
         let wallet = Arc::new(RwLock::new(WalletManager::<ManagedWalletInfo>::new()));
 
         let mut client = DashSpvClient::new(config, network_manager, storage, wallet)