Skip to content

Commit d3f0ef8

Browse files
jonded94Jonas Dedden
andauthored
Implement new container env mechanism also for Dask Jobs (#879)
* Implement new container env mechanism also for Dask Jobs * Black fixes --------- Co-authored-by: Jonas Dedden <[email protected]>
1 parent 93fe171 commit d3f0ef8

File tree

1 file changed

+12
-10
lines changed

1 file changed

+12
-10
lines changed

dask_kubernetes/operator/controller/controller.py

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -197,17 +197,19 @@ def build_job_pod_spec(job_name, cluster_name, namespace, spec, annotations, lab
197197
},
198198
"spec": copy.deepcopy(spec),
199199
}
200-
env = [
201-
{
202-
"name": "DASK_SCHEDULER_ADDRESS",
203-
"value": f"tcp://{cluster_name}-scheduler.{namespace}.svc.cluster.local:8786",
204-
},
205-
]
200+
scheduler_env = {
201+
"name": "DASK_SCHEDULER_ADDRESS",
202+
"value": f"tcp://{cluster_name}-scheduler.{namespace}.svc.cluster.local:8786",
203+
}
206204
for container in pod_spec["spec"]["containers"]:
207-
if "env" in container:
208-
container["env"].extend(env)
209-
else:
210-
container["env"] = env
205+
if "env" not in container:
206+
container["env"] = [scheduler_env]
207+
continue
208+
209+
container_env_names = [env_item["name"] for env_item in container["env"]]
210+
211+
if "DASK_SCHEDULER_ADDRESS" not in container_env_names:
212+
container["env"].append(scheduler_env)
211213
return pod_spec
212214

213215

0 commit comments

Comments
 (0)