pyright

Author: lucascolley

pixi.lock

@@ -290,7 +290,7 @@ reportImportCycles = false
 reportUnknownLambdaType = false
 
 executionEnvironments = [
-  { root = "tests", reportPrivateUsage = false },
+  { root = "tests", reportPrivateUsage = false, reportUnknownArgumentType = false },
   { root = "src" },
 ]
 

pyproject.toml

@@ -37,13 +37,13 @@ def library(request: pytest.FixtureRequest) -> Backend:  # numpydoc ignore=PR01,
         ("xfail_xp_backend", partial(xfail, request), {"reason", "strict"}),
     ):
         for marker in request.node.iter_markers(marker_name):
-            if len(marker.args) != 1:  # pyright: ignore[reportUnknownArgumentType]
+            if len(marker.args) != 1:
                 msg = f"Expected exactly one positional argument; got {marker.args}"
                 raise TypeError(msg)
             if not isinstance(marker.args[0], Backend):
                 msg = f"Argument of {marker_name} must be a Backend enum"
                 raise TypeError(msg)
-            if invalid_kwargs := set(marker.kwargs) - allow_kwargs:  # pyright: ignore[reportUnknownArgumentType]
+            if invalid_kwargs := set(marker.kwargs) - allow_kwargs:
                 msg = f"Unexpected kwarg(s): {invalid_kwargs}"
                 raise TypeError(msg)
 
@@ -52,9 +52,9 @@ def library(request: pytest.FixtureRequest) -> Backend:  # numpydoc ignore=PR01,
             strict: bool | None = marker.kwargs.get("strict", None)
 
             if library == elem:
-                reason = f"{library}: {reason}" if reason else str(library)  # pyright: ignore[reportUnknownArgumentType]
+                reason = f"{library}: {reason}" if reason else str(library)
                 kwargs = {"strict": strict} if strict is not None else {}
-                skip_or_xfail(reason=reason, **kwargs)  # pyright: ignore[reportUnknownArgumentType]
+                skip_or_xfail(reason=reason, **kwargs)
 
     return elem
 
@@ -98,7 +98,7 @@ def as_readonly(o: T) -> T:  # numpydoc ignore=PR01,RT01
 
             # This works with namedtuples too
             if isinstance(o, tuple | list):
-                return type(o)(*(as_readonly(i) for i in o))  # type: ignore[arg-type,return-value] # pyright: ignore[reportArgumentType,reportUnknownArgumentType]
+                return type(o)(*(as_readonly(i) for i in o))  # type: ignore[arg-type,return-value] # pyright: ignore[reportArgumentType]
 
             return o
 

tests/conftest.py

@@ -94,8 +94,8 @@ def test_broadcast(self, xp: ModuleType):
         actual = apply_where(
             cond,
             (x, y),
-            lambda x, _: x,  # pyright: ignore[reportUnknownArgumentType]
-            lambda _, y: y,  # pyright: ignore[reportUnknownArgumentType]
+            lambda x, _: x,
+            lambda _, y: y,
         )
         expect = xp.where(cond, x, y)
         xp_assert_equal(actual, expect)
@@ -115,7 +115,7 @@ def test_dtype_propagation(self, xp: ModuleType, library: Backend):
             cond,
             (x, y),
             self.f1,
-            lambda x, y: mxp.astype(x - y, xp.int64),  # pyright: ignore[reportArgumentType,reportUnknownArgumentType]
+            lambda x, y: mxp.astype(x - y, xp.int64),
         )
         assert actual.dtype == xp.int64
 
@@ -162,8 +162,8 @@ def test_dont_run_on_false(self, xp: ModuleType):
         actual = apply_where(
             x == 0,
             (x, y),
-            lambda x, y: x / y,  # pyright: ignore[reportUnknownArgumentType]
-            lambda x, y: y / x,  # pyright: ignore[reportUnknownArgumentType]
+            lambda x, y: x / y,
+            lambda x, y: y / x,
         )
         xp_assert_equal(actual, xp.asarray([0.0, 1.5, 0.0]))
 

tests/test_funcs.py

@@ -234,7 +234,7 @@ def test_device(self, xp: ModuleType, library: Backend, device: Device):
 
             # Test that we're accepting anything that is accepted by the
             # device= parameter in other functions
-            actual = capabilities(xp, device=device.type)  # type: ignore[attr-defined]  # pyright: ignore[reportUnknownArgumentType,reportAttributeAccessIssue]
+            actual = capabilities(xp, device=device.type)  # type: ignore[attr-defined]  # pyright: ignore[reportAttributeAccessIssue]
 
 
 class Wrapper(Generic[T]):  # noqa: PLW1641
@@ -331,16 +331,16 @@ def test_flattened_stream(self):
         obj2 = [Wrapper(2), Wrapper(3)]
         instances1, rest1 = pickle_flatten(obj1, Wrapper)
         instances2, rest2 = pickle_flatten(obj2, Wrapper)
-        it = iter(instances1 + instances2 + [Wrapper(4)])  # pyright: ignore[reportUnknownArgumentType]
-        assert pickle_unflatten(it, rest1) == obj1  # pyright: ignore[reportUnknownArgumentType]
-        assert pickle_unflatten(it, rest2) == obj2  # pyright: ignore[reportUnknownArgumentType]
-        assert list(it) == [Wrapper(4)]  # pyright: ignore[reportUnknownArgumentType]
+        it = iter(instances1 + instances2 + [Wrapper(4)])
+        assert pickle_unflatten(it, rest1) == obj1
+        assert pickle_unflatten(it, rest2) == obj2
+        assert list(it) == [Wrapper(4)]
 
     def test_too_short(self):
         obj = [Wrapper(1), Wrapper(2)]
         instances, rest = pickle_flatten(obj, Wrapper)
         with pytest.raises(ValueError, match="Not enough"):
-            pickle_unflatten(instances[:1], rest)  # pyright: ignore[reportUnknownArgumentType]
+            pickle_unflatten(instances[:1], rest)
 
     def test_recursion(self):
         obj: list[object] = [Wrapper(1)]
@@ -349,7 +349,7 @@ def test_recursion(self):
         instances, rest = pickle_flatten(obj, Wrapper)
         assert instances == [Wrapper(1)]
 
-        obj2 = pickle_unflatten(instances, rest)  # pyright: ignore[reportUnknownArgumentType]
+        obj2 = pickle_unflatten(instances, rest)
         assert len(obj2) == 2
         assert obj2[0] is obj[0]
         assert obj2[1] is obj2
@@ -403,7 +403,7 @@ def f(x: object) -> object:
         assert isinstance(out, Wrapper)
         assert out.x[0] is winp.x[0]
         assert out.x[1] is not winp.x[1]
-        xp_assert_equal(out.x[1], winp.x[1])  # pyright: ignore[reportUnknownArgumentType]
+        xp_assert_equal(out.x[1], winp.x[1])
 
     def test_arraylikes_are_static(self):
         pytest.importorskip("jax")

tests/test_helpers.py

@@ -187,8 +187,8 @@ def f(x: Array) -> Array:
         return x + 1
 
     y = lazy_apply(f, x_da)
-    assert array_namespace(y._meta) is cp  # type: ignore[attr-defined]  # pyright: ignore[reportUnknownArgumentType,reportAttributeAccessIssue]
-    xp_assert_equal(y.compute(), x_cp + 1)  # type: ignore[attr-defined]  # pyright: ignore[reportUnknownArgumentType,reportAttributeAccessIssue]
+    assert array_namespace(y._meta) is cp  # type: ignore[attr-defined]  # pyright: ignore[reportAttributeAccessIssue]
+    xp_assert_equal(y.compute(), x_cp + 1)  # type: ignore[attr-defined]  # pyright: ignore[reportAttributeAccessIssue]
 
 
 def test_dask_key(da: ModuleType):
@@ -396,7 +396,7 @@ def test_lazy_apply_kwargs(xp: ModuleType, library: Backend, as_numpy: bool):
     with numpy arrays, and leave the rest untouched."""
     x = xp.asarray(0)
     expect_cls = np.ndarray if as_numpy or library is Backend.DASK else type(x)
-    actual = check_lazy_apply_kwargs(x, expect_cls, as_numpy)  # pyright: ignore[reportUnknownArgumentType]
+    actual = check_lazy_apply_kwargs(x, expect_cls, as_numpy)
     xp_assert_equal(actual, x + 1)
 
 

tests/test_lazy.py

@@ -296,7 +296,7 @@ def test_lazy_xp_function_deprecated_static_argnames():
     # scipy.special.erf.
     from scipy.special._ufuncs import erf  # type: ignore[import-untyped]
 
-    lazy_xp_function(erf)  # pyright: ignore[reportUnknownArgumentType]
+    lazy_xp_function(erf)
 except ImportError:
     erf = None
 

tests/test_testing.py

@@ -1,4 +1,5 @@
 """This file is a hook imported by `src/array_api_extra/_lib/_compat.py`."""
+# pyright: reportUnknownParameterType=false, reportMissingParameterType=false
 
 from .array_api_compat import *  # noqa: F403
 from .array_api_compat import array_namespace as array_namespace_compat

vendor_tests/_array_api_compat_vendor.py

@@ -1,3 +1,7 @@
+# pyright: reportAttributeAccessIssue=false
+
+from typing import Any
+
 import array_api_strict as xp
 from numpy.testing import assert_array_equal
 
@@ -59,7 +63,7 @@ def test_vendor_extra():
 def test_vendor_extra_testing():
     from .array_api_extra.testing import lazy_xp_function
 
-    def f(x):
+    def f(x: Any) -> Any:
         return x
 
     lazy_xp_function(f)