lint

Author: lucascolley

.pre-commit-config.yaml

@@ -6,7 +6,7 @@ exclude: ^.cruft.json|.copier-answers.yml$
 
 repos:
   - repo: https://github.com/adamchainz/blacken-docs
-    rev: "1.18.0"
+    rev: "1.19.1"
     hooks:
       - id: blacken-docs
         additional_dependencies: [black==24.*]
@@ -35,21 +35,21 @@ repos:
       - id: rst-inline-touching-normal
 
   - repo: https://github.com/rbubley/mirrors-prettier
-    rev: "v3.4.2"
+    rev: "v3.6.2"
     hooks:
       - id: prettier
         types_or: [yaml, markdown, html, css, scss, javascript, json]
         args: [--prose-wrap=always]
 
   - repo: https://github.com/astral-sh/ruff-pre-commit
-    rev: "v0.8.2"
+    rev: "v0.12.1"
     hooks:
       - id: ruff-format
       - id: ruff
         args: ["--fix", "--show-fixes"]
 
   - repo: https://github.com/codespell-project/codespell
-    rev: "v2.3.0"
+    rev: "v2.4.1"
     hooks:
       - id: codespell
         exclude: pixi.lock
@@ -68,17 +68,17 @@ repos:
         exclude: .pre-commit-config.yaml
 
   - repo: https://github.com/abravalheri/validate-pyproject
-    rev: "v0.23"
+    rev: "v0.24.1"
     hooks:
       - id: validate-pyproject
         additional_dependencies: ["validate-pyproject-schema-store[all]"]
 
   - repo: https://github.com/python-jsonschema/check-jsonschema
-    rev: "0.30.0"
+    rev: "0.33.1"
     hooks:
       - id: check-github-workflows
 
   - repo: https://github.com/numpy/numpydoc
-    rev: "v1.8.0"
+    rev: "v1.9.0"
     hooks:
       - id: numpydoc-validation

pixi.lock

@@ -65,17 +65,17 @@ array-api-strict = ">=2.3.1"
 numpy = ">=2.1.3"
 pytest = ">=8.4.0"
 hypothesis = ">=6.131.28"
-dask-core = ">=2025.5.1"  # No distributed, tornado, etc.
+dask-core = ">=2025.5.1"     # No distributed, tornado, etc.
 # NOTE: don't add cupy, jax, pytorch, or sparse here,
 # as they slow down mypy and are not portable across target OSs
 
 [tool.pixi.feature.lint.tasks]
-pre-commit-install = { cmd = "pre-commit install", description = "Install pre-commit"}
-pre-commit = { cmd = "pre-commit run --all-files", description = "Run pre-commit"}
-mypy = { cmd = "mypy", description="Type check with mypy"}
-pylint = { cmd = "pylint array_api_extra", cwd = "src" , description = "Lint using pylint"}
-pyright = { cmd = "basedpyright", description = "Type check with basedpyright"}
-lint = { depends-on = ["pre-commit", "pylint", "mypy", "pyright"] , description = "Run pre-commit, pylint, mypy, and pyright"}
+pre-commit-install = { cmd = "pre-commit install", description = "Install pre-commit" }
+pre-commit = { cmd = "pre-commit run --all-files", description = "Run pre-commit" }
+mypy = { cmd = "mypy", description = "Type check with mypy" }
+pylint = { cmd = "pylint array_api_extra", cwd = "src", description = "Lint using pylint" }
+pyright = { cmd = "basedpyright", description = "Type check with basedpyright" }
+lint = { depends-on = ["pre-commit", "pylint", "mypy", "pyright"], description = "Run pre-commit, pylint, mypy, and pyright" }
 
 [tool.pixi.feature.tests.dependencies]
 pytest = ">=8.4.0"
@@ -85,18 +85,18 @@ array-api-strict = ">=2.3.1"
 numpy = ">=1.22.0"
 
 [tool.pixi.feature.tests.tasks]
-tests = { cmd = "pytest -v", description = "Run tests"}
-tests-cov = { cmd="pytest -v -ra --cov --cov-report=xml --cov-report=term --durations=20", description = "Run tests with coverage"}
+tests = { cmd = "pytest -v", description = "Run tests" }
+tests-cov = { cmd = "pytest -v -ra --cov --cov-report=xml --cov-report=term --durations=20", description = "Run tests with coverage" }
 
-clean-vendor-compat = { cmd = "rm -rf vendor_tests/array_api_compat", description = "Delete the existing vendored version of array-api-compat"}
-clean-vendor-extra = { cmd = "rm -rf vendor_tests/array_api_extra" , description = "Delete the existing vendored version of array-api-extra"}
-copy-vendor-compat = { cmd = "cp -r $(python -c 'import site; print(site.getsitepackages()[0])')/array_api_compat vendor_tests/", depends-on = ["clean-vendor-compat"] , description = "Vendor a clean copy of array-api-compat"}
-copy-vendor-extra = { cmd = "cp -r src/array_api_extra vendor_tests/", depends-on = ["clean-vendor-extra"] , description = "Vendor a clean copy of array-api-extra"}
-tests-vendor = { cmd = "pytest -v vendor_tests", depends-on = ["copy-vendor-compat", "copy-vendor-extra"] , description = "Check that array-api-extra and array-api-compat can be vendored together" }
+clean-vendor-compat = { cmd = "rm -rf vendor_tests/array_api_compat", description = "Delete the existing vendored version of array-api-compat" }
+clean-vendor-extra = { cmd = "rm -rf vendor_tests/array_api_extra", description = "Delete the existing vendored version of array-api-extra" }
+copy-vendor-compat = { cmd = "cp -r $(python -c 'import site; print(site.getsitepackages()[0])')/array_api_compat vendor_tests/", depends-on = ["clean-vendor-compat"], description = "Vendor a clean copy of array-api-compat" }
+copy-vendor-extra = { cmd = "cp -r src/array_api_extra vendor_tests/", depends-on = ["clean-vendor-extra"], description = "Vendor a clean copy of array-api-extra" }
+tests-vendor = { cmd = "pytest -v vendor_tests", depends-on = ["copy-vendor-compat", "copy-vendor-extra"], description = "Check that array-api-extra and array-api-compat can be vendored together" }
 
-tests-ci = { depends-on = ["tests-cov", "tests-vendor"] , description = "Run tests with coverage and vendor tests"}
-coverage = { cmd = "coverage html", depends-on = ["tests-cov"], description = "Generate test coverage html report"}
-open-coverage = { cmd = "open htmlcov/index.html", depends-on = ["coverage"] , description = "Open test coverage report"}
+tests-ci = { depends-on = ["tests-cov", "tests-vendor"], description = "Run tests with coverage and vendor tests" }
+coverage = { cmd = "coverage html", depends-on = ["tests-cov"], description = "Generate test coverage html report" }
+open-coverage = { cmd = "open htmlcov/index.html", depends-on = ["coverage"], description = "Open test coverage report" }
 
 [tool.pixi.feature.docs.dependencies]
 sphinx = ">=7.4.7"
@@ -105,20 +105,20 @@ myst-parser = ">=4.0.1"
 sphinx-copybutton = ">=0.5.2"
 sphinx-autodoc-typehints = ">=1.25.3"
 # Needed to import parsed modules with autodoc
-dask-core = ">=2025.5.1"  # No distributed, tornado, etc.
+dask-core = ">=2025.5.1"       # No distributed, tornado, etc.
 pytest = ">=8.4.0"
 typing-extensions = ">=4.14.0"
 numpy = ">=2.1.3"
 
 [tool.pixi.feature.docs.tasks]
-docs = { cmd = "sphinx-build -E -W . build/", cwd = "docs" , description = "Build docs"}
-open-docs = { cmd = "open build/index.html", cwd = "docs", depends-on = ["docs"] , description = "Open the generated docs"}
+docs = { cmd = "sphinx-build -E -W . build/", cwd = "docs", description = "Build docs" }
+open-docs = { cmd = "open build/index.html", cwd = "docs", depends-on = ["docs"], description = "Open the generated docs" }
 
 [tool.pixi.feature.dev.dependencies]
 ipython = ">=7.33.0"
 
 [tool.pixi.feature.dev.tasks]
-ipython = { cmd = "ipython" , description = "Launch ipython"}
+ipython = { cmd = "ipython", description = "Launch ipython" }
 
 [tool.pixi.feature.py310.dependencies]
 python = "~=3.10.0"
@@ -135,7 +135,7 @@ numpy = "=1.22.0"
 # Note: JAX and PyTorch will install CPU variants.
 [tool.pixi.feature.backends.dependencies]
 pytorch = ">=2.7.0"
-dask-core = ">=2025.5.1"  # No distributed, tornado, etc.
+dask-core = ">=2025.5.1" # No distributed, tornado, etc.
 sparse = ">=0.17.0"
 
 [tool.pixi.feature.backends.target.linux-64.dependencies]
@@ -184,7 +184,7 @@ python-freethreading = "~=3.13.0"
 pytest-run-parallel = ">=0.4.4"
 numpy = ">=2.3.0"
 # pytorch = "*"  # Not available on Python 3.13t yet
-dask-core = ">=2025.5.1"  # No distributed, tornado, etc.
+dask-core = ">=2025.5.1" # No distributed, tornado, etc.
 # sparse = "*"  # numba not available on Python 3.13t yet
 # jax = "*"  # ml_dtypes not available on Python 3.13t yet
 
@@ -245,7 +245,7 @@ ignore_missing_imports = true
 
 [[tool.mypy.overrides]]
 module = ["tests/*"]
-disable_error_code = ["no-untyped-def"]  # test(...) without -> None
+disable_error_code = ["no-untyped-def"] # test(...) without -> None
 
 # pyright
 
@@ -322,6 +322,7 @@ ignore = [
   "N801",    # Class name should use CapWords convention
   "N802",    # Function name should be lowercase
   "N806",    # Variable in function should be lowercase
+  "PLC0415", # `import` should be at the top-level of a file
 ]
 
 

pyproject.toml

@@ -325,13 +325,15 @@ def quantile(
     xp = array_namespace(x, q) if xp is None else xp
 
     try:
-        import scipy
+        import scipy  # type: ignore[import-untyped]
         from packaging import version
 
         # The quantile function in scipy 1.16 supports array API directly, no need
         # to delegate
-        if version.parse(scipy.__version__) >= version.parse("1.16"):
-            from scipy.stats import quantile as scipy_quantile
+        if version.parse(scipy.__version__) >= version.parse("1.16"):  # pyright: ignore[reportUnknownArgumentType]
+            from scipy.stats import (  # type: ignore[import-untyped]
+                quantile as scipy_quantile,
+            )
 
             return scipy_quantile(x, p=q, axis=axis, keepdims=keepdims, method=method)
     except (ImportError, AttributeError):

src/array_api_extra/_delegation.py

@@ -268,7 +268,7 @@ def broadcast_shapes(*shapes: tuple[float | None, ...]) -> tuple[int | None, ...
     for axis in range(-ndim, 0):
         sizes = {shape[axis] for shape in shapes if axis >= -len(shape)}
         # Dask uses NaN for unknown shape, which predates the Array API spec for None
-        none_size = None in sizes or math.nan in sizes
+        none_size = None in sizes or math.nan in sizes  # noqa: PLW0177
         sizes -= {1, None, math.nan}
         if len(sizes) > 1:
             msg = (

src/array_api_extra/_lib/_funcs.py

@@ -1,6 +1,7 @@
 """Quantile implementation."""
 
 from types import ModuleType
+from typing import cast
 
 from ._at import at
 from ._utils import _compat
@@ -14,7 +15,7 @@ def quantile(
     /,
     *,
     axis: int | None = None,
-    keepdims: bool = None,  # noqa: RUF013
+    keepdims: bool | None = None,
     method: str = "linear",
     xp: ModuleType | None = None,
 ) -> Array:  # numpydoc ignore=PR01,RT01
@@ -25,26 +26,27 @@ def quantile(
     q_is_scalar = isinstance(q, int | float)
     if q_is_scalar:
         q = xp.asarray(q, dtype=xp.float64, device=_compat.device(x))
+    q_arr = cast(Array, q)
 
     if not xp.isdtype(x.dtype, ("integral", "real floating")):
         raise ValueError("`x` must have real dtype.")  # noqa: EM101
-    if not xp.isdtype(q.dtype, "real floating"):
+    if not xp.isdtype(q_arr.dtype, "real floating"):
         raise ValueError("`q` must have real floating dtype.")  # noqa: EM101
 
     # Promote to common dtype
     x = xp.astype(x, xp.float64)
-    q = xp.astype(q, xp.float64)
-    q = xp.asarray(q, device=_compat.device(x))
+    q_arr = xp.astype(q_arr, xp.float64)
+    q_arr = xp.asarray(q_arr, device=_compat.device(x))
 
     dtype = x.dtype
     axis_none = axis is None
-    ndim = max(x.ndim, q.ndim)
+    ndim = max(x.ndim, q_arr.ndim)
 
     if axis_none:
         x = xp.reshape(x, (-1,))
-        q = xp.reshape(q, (-1,))
+        q_arr = xp.reshape(q_arr, (-1,))
         axis = 0
-    elif not isinstance(axis, int):
+    elif not isinstance(axis, int):  # pyright: ignore[reportUnnecessaryIsInstance]
         raise ValueError("`axis` must be an integer or None.")  # noqa: EM101
     elif axis >= ndim or axis < -ndim:
         raise ValueError("`axis` is not compatible with the shapes of the inputs.")  # noqa: EM101
@@ -63,15 +65,15 @@ def quantile(
 
     # Move axis to the end for easier processing
     y = xp.moveaxis(y, axis, -1)
-    if not (q_is_scalar or q.ndim == 0):
-        q = xp.moveaxis(q, axis, -1)
+    if not (q_is_scalar or q_arr.ndim == 0):
+        q_arr = xp.moveaxis(q_arr, axis, -1)
 
     n = xp.asarray(y.shape[-1], dtype=dtype, device=_compat.device(y))
 
-    res = _quantile_hf(y, q, n, method, xp)
+    res = _quantile_hf(y, q_arr, n, method, xp)
 
     # Handle NaN output for invalid q values
-    p_mask = (q > 1) | (q < 0) | xp.isnan(q)
+    p_mask = (q_arr > 1) | (q_arr < 0) | xp.isnan(q_arr)
     if xp.any(p_mask):
         res = xp.asarray(res, copy=True)
         res = at(res, p_mask).set(xp.nan)
@@ -100,7 +102,7 @@ def _quantile_hf(
     y: Array, p: Array, n: Array, method: str, xp: ModuleType
 ) -> Array:  # numpydoc ignore=PR01,RT01
     """Helper function for Hyndman-Fan quantile method."""
-    ms = {
+    ms: dict[str, Array | int | float] = {
         "inverted_cdf": 0,
         "averaged_inverted_cdf": 0,
         "closest_observation": -0.5,

src/array_api_extra/_lib/_quantile.py

@@ -297,9 +297,9 @@ def temp_setattr(mod: ModuleType, name: str, func: object) -> None:
         # Enable using patch_lazy_xp_function not as a context manager
         temp_setattr = monkeypatch.setattr  # type: ignore[assignment]  # pyright: ignore[reportAssignmentType]
 
-    def iter_tagged() -> (
-        Iterator[tuple[ModuleType, str, Callable[..., Any], dict[str, Any]]]
-    ):
+    def iter_tagged() -> Iterator[
+        tuple[ModuleType, str, Callable[..., Any], dict[str, Any]]
+    ]:
         for mod in mods:
             for name, func in mod.__dict__.items():
                 tags: dict[str, Any] | None = None

src/array_api_extra/testing.py

@@ -237,7 +237,7 @@ def test_device(self, xp: ModuleType, library: Backend, device: Device):
             actual = capabilities(xp, device=device.type)  # type: ignore[attr-defined]  # pyright: ignore[reportUnknownArgumentType,reportAttributeAccessIssue]
 
 
-class Wrapper(Generic[T]):
+class Wrapper(Generic[T]):  # noqa: PLW1641
     """Trivial opaque wrapper. Must be pickleable."""
 
     x: T
@@ -263,7 +263,7 @@ def __reduce__(self) -> tuple[object, ...]:
 
         # Note: NotHashable() instances can be reduced to an
         # unserializable local class
-        class NotHashable:
+        class NotHashable:  # noqa: PLW1641
             @override
             def __eq__(self, other: object) -> bool:
                 return isinstance(other, type(self)) and other.__dict__ == self.__dict__

tests/test_helpers.py

@@ -459,7 +459,7 @@ def test_patch_lazy_xp_functions_deprecated_monkeypatch(
     y = non_materializable5(x)
     xp_assert_equal(y, x)
 
-    with pytest.warns(DeprecationWarning):
+    with pytest.warns(DeprecationWarning, match="`monkeypatch` parameter"):
         _ = patch_lazy_xp_functions(request, monkeypatch, xp=xp)
 
     with pytest.raises(AssertionError, match=r"dask\.compute.* 1 times"):