Make xp mandatory

Author: paddyroddy

src/array_api_extra/_lib/_funcs.py

@@ -741,9 +741,9 @@ def kron(
 def nan_to_num(
     x: Array,
     /,
-    *,
     fill_value: int | float | complex = 0.0,
-    xp: ModuleType | None = None,
+    *,
+    xp: ModuleType,
 ) -> Array:
     """See docstring in `array_api_extra._delegation.py`."""
     xp = array_namespace(x) if xp is None else xp

tests/test_funcs.py

@@ -946,7 +946,7 @@ def test_xp(self, xp: ModuleType):
 class TestNumToNan:
     def test_bool(self, xp: ModuleType) -> None:
         a = xp.asarray([True])
-        xp_assert_equal(nan_to_num(a), a)
+        xp_assert_equal(nan_to_num(a, xp=xp), a)
 
     def test_scalar_pos_inf(self, xp: ModuleType, infinity: float) -> None:
         a = xp.inf
@@ -963,7 +963,7 @@ def test_scalar_nan(self, xp: ModuleType) -> None:
     def test_real(self, xp: ModuleType, infinity: float) -> None:
         a = xp.asarray([xp.inf, -xp.inf, xp.nan, -128, 128])
         xp_assert_equal(
-            nan_to_num(a),
+            nan_to_num(a, xp=xp),
             xp.asarray(
                 [
                     infinity,