Skip to content

Commit 1a47f4d

Browse files
authored
Merge pull request #1063 from rvsia/commonSelectTests
Add tests for common select
2 parents 5122e22 + 1913d5f commit 1a47f4d

File tree

4 files changed

+765
-6
lines changed

4 files changed

+765
-6
lines changed

packages/common/src/select/reducer.js

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,6 @@ const reducer = (state, { type, payload, options = [] }) => {
77
isLoading: false,
88
promises: {}
99
};
10-
case 'loaded':
11-
return {
12-
...state,
13-
isLoading: false
14-
};
1510
case 'startLoading':
1611
return {
1712
...state,

packages/common/src/select/select.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,8 @@ const Select = ({
128128
})
129129
.catch((error) => {
130130
dispatch({ type: 'setPromises', payload: { [inputValue]: false } });
131-
throw error;
131+
// eslint-disable-next-line no-console
132+
console.error(error);
132133
});
133134
}
134135
};
Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
import { parseInternalValue } from '../../select';
2+
3+
describe('parseInternalValue', () => {
4+
let value;
5+
let isMulti;
6+
7+
it('single', () => {
8+
value = 'cats';
9+
isMulti = undefined;
10+
expect(parseInternalValue(value, isMulti)).toEqual('cats');
11+
});
12+
13+
it('multi and array', () => {
14+
value = ['cats', { value: 'dogs' }];
15+
isMulti = true;
16+
expect(parseInternalValue(value, isMulti)).toEqual(['cats', 'dogs']);
17+
});
18+
19+
it('single and array', () => {
20+
value = ['cats', { value: 'dogs' }];
21+
isMulti = false;
22+
expect(parseInternalValue(value, isMulti)).toEqual('cats');
23+
});
24+
25+
it('single and array - object', () => {
26+
value = [{ value: 'dogs' }];
27+
isMulti = false;
28+
expect(parseInternalValue(value, isMulti)).toEqual('dogs');
29+
});
30+
31+
it('single and undefined', () => {
32+
value = [];
33+
isMulti = false;
34+
expect(parseInternalValue(value, isMulti)).toEqual(undefined);
35+
});
36+
});

0 commit comments

Comments
 (0)