Skip to content

Commit 2266db8

Browse files
authored
Merge pull request #1299 from data-driven-forms/fix-carbon-imports
fix(carbon): do not use absolute import paths
2 parents 5f6b046 + 3d2bd8f commit 2266db8

File tree

4 files changed

+19
-107
lines changed

4 files changed

+19
-107
lines changed

packages/carbon-component-mapper/src/dual-list-select/dual-list-select.js

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,20 @@ import DualListSelectCommon from '@data-driven-forms/common/dual-list-select';
44
import clsx from 'clsx';
55
import { createUseStyles } from 'react-jss';
66

7-
import { Grid, Row, Column, Button, FormGroup, Search, TooltipIcon } from 'carbon-components-react';
8-
import { CheckmarkFilled16, ChevronRight32, ChevronLeft32, CaretSortDown32, CaretSortUp32 } from '@carbon/icons-react';
9-
107
import {
8+
Grid,
9+
Row,
10+
Column,
11+
Button,
12+
FormGroup,
13+
Search,
1114
StructuredListWrapper,
1215
StructuredListRow,
1316
StructuredListBody,
1417
StructuredListCell,
15-
} from 'carbon-components-react/lib/components/StructuredList/StructuredList';
18+
TooltipIcon,
19+
} from 'carbon-components-react';
20+
import { CheckmarkFilled16, ChevronRight32, ChevronLeft32, CaretSortDown32, CaretSortUp32 } from '@carbon/icons-react';
1621

1722
import { buildLabel } from '../prepare-props';
1823

packages/common/babel.config.js

Lines changed: 0 additions & 97 deletions
Original file line numberDiff line numberDiff line change
@@ -164,101 +164,6 @@ const createAntTransform = (env) => [
164164
`ant-${env}`
165165
];
166166

167-
const carbonMapper = (importName) =>
168-
({
169-
StructuredListWrapper: 'StructuredList',
170-
StructuredListBody: 'StructuredList',
171-
StructuredListRow: 'StructuredList',
172-
StructuredListCell: 'StructuredList',
173-
ProgressStep: 'ProgressIndicator'
174-
}[importName] || importName);
175-
176-
const createCarbonCJSTransform = (env) => [
177-
'transform-imports',
178-
{
179-
'carbon-components-react': {
180-
transform: (importName) => {
181-
let res;
182-
const files = glob.sync(
183-
path.resolve(__dirname, `../{..,carbon-component-mapper}/node_modules/carbon-components-react/${env === 'cjs' ? 'lib' : 'es'}/**/${carbonMapper(importName)}.js`)
184-
).filter(path => !path.includes('/next/'));
185-
if (files.length > 0) {
186-
res = files[0];
187-
} else {
188-
throw new Error(`File with importName ${importName} does not exist`);
189-
}
190-
191-
res = res.replace(/^.*node_modules\//, '');
192-
res = res.replace(/^\//, '');
193-
return res;
194-
},
195-
preventFullImport: false,
196-
skipDefaultConversion: false
197-
},
198-
'carbon-components-react/lib/components/StructuredList/StructuredList': {
199-
transform: (importName) => {
200-
let res;
201-
const files = glob.sync(
202-
path.resolve(__dirname, `../{..,carbon-component-mapper}/node_modules/carbon-components-react/${env === 'cjs' ? 'lib' : 'es'}/**/${carbonMapper(importName)}.js`)
203-
).filter(path => !path.includes('/next/'));
204-
if (files.length > 0) {
205-
res = files[0];
206-
} else {
207-
throw new Error(`File with importName ${importName} does not exist`);
208-
}
209-
210-
res = res.replace(/^.*node_modules\//, '');
211-
res = res.replace(/^\//, '');
212-
return res;
213-
},
214-
preventFullImport: false,
215-
skipDefaultConversion: true
216-
},
217-
'carbon-components-react/lib/components/ProgressIndicator/ProgressIndicator': {
218-
transform: (importName) => {
219-
let res;
220-
const files = glob.sync(
221-
path.resolve(__dirname, `../{..,carbon-component-mapper}/node_modules/carbon-components-react/${env === 'cjs' ? 'lib' : 'es'}/**/${carbonMapper(importName)}.js`)
222-
).filter(path => !path.includes('/next/'));
223-
if (files.length > 0) {
224-
res = files[0];
225-
} else {
226-
throw new Error(`File with importName ${importName} does not exist`);
227-
}
228-
229-
res = res.replace(/^.*node_modules\//, '');
230-
res = res.replace(/^\//, '');
231-
return res;
232-
},
233-
preventFullImport: false,
234-
skipDefaultConversion: true
235-
},
236-
'@carbon/icons-react': {
237-
transform: (importName) => {
238-
let size = importName.match(/\d+/)[0];
239-
let iconName = pascalToKebabCaseCarbonIcons(importName.replace(/\d+/, ''));
240-
241-
let res;
242-
const files = glob.sync(
243-
path.resolve(__dirname, `../{..,carbon-component-mapper}/node_modules/@carbon/icons-react/${env === 'cjs' ? 'lib' : 'es'}/${iconName}/${size}.js`)
244-
);
245-
if (files.length > 0) {
246-
res = files[0];
247-
} else {
248-
throw new Error(`File with importName ${importName} does not exist`);
249-
}
250-
251-
res = res.replace(/^.*node_modules\//, '');
252-
res = res.replace(/^\//, '');
253-
return res;
254-
},
255-
preventFullImport: false,
256-
skipDefaultConversion: false
257-
}
258-
},
259-
`carbon-components-react-${env}`
260-
];
261-
262167
const createReactJSSTransform = (env) => [
263168
'transform-imports',
264169
{
@@ -298,7 +203,6 @@ module.exports = {
298203
createPfReactTransform('js'),
299204
createBluePrintTransform('cjs'),
300205
createAntTransform('cjs'),
301-
createCarbonCJSTransform('cjs'),
302206
createReactJSSTransform('cjs')
303207
]
304208
},
@@ -310,7 +214,6 @@ module.exports = {
310214
createPfReactTransform('esm'),
311215
createBluePrintTransform('esm'),
312216
createAntTransform('esm'),
313-
createCarbonCJSTransform('esm'),
314217
createReactJSSTransform('esm')
315218
]
316219
}

packages/mui-component-mapper/src/date-picker/date-picker.d.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@ type InternalDatePickerProps<TInputDate, TDate> = MuiDatePickerProps<TInputDate,
66
}
77

88
export type DatePickerProps<TInputDate, TDate> = InternalDatePickerProps<TInputDate, TDate> & UseFieldApiComponentConfig;
9+
<<<<<<< Updated upstream
10+
=======
11+
12+
>>>>>>> Stashed changes
913
declare const DatePicker: React.ComponentType<DatePickerProps<any, any>>;
1014

1115
export default DatePicker;

yarn.lock

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2945,9 +2945,9 @@
29452945
react-is "^17.0.2"
29462946

29472947
"@mui/utils@^5.4.1":
2948-
version "5.9.1"
2949-
resolved "https://registry.yarnpkg.com/@mui/utils/-/utils-5.9.1.tgz#2b2c9dadbf8ba6561e145b5688fb7df5ef15a934"
2950-
integrity sha512-8+4adOR3xusyJwvbnZxcjqcmbWvl7Og+260ZKIrSvwnFs0aLubL+8MhiceeDDGcmb0bTKxfUgRJ96j32Jb7P+A==
2948+
version "5.9.3"
2949+
resolved "https://registry.yarnpkg.com/@mui/utils/-/utils-5.9.3.tgz#a11e0824f00b7ea40257b390060ce167fe861d02"
2950+
integrity sha512-l0N5bcrenE9hnwZ/jPecpIRqsDFHkPXoFUcmkgysaJwVZzJ3yQkGXB47eqmXX5yyGrSc6HksbbqXEaUya+siew==
29512951
dependencies:
29522952
"@babel/runtime" "^7.17.2"
29532953
"@types/prop-types" "^15.7.5"
@@ -2956,9 +2956,9 @@
29562956
react-is "^18.2.0"
29572957

29582958
"@mui/x-date-pickers@^5.0.0-beta.0":
2959-
version "5.0.0-beta.1"
2960-
resolved "https://registry.yarnpkg.com/@mui/x-date-pickers/-/x-date-pickers-5.0.0-beta.1.tgz#d681249066c81d73f6ca88d500f77e922ae2e7c5"
2961-
integrity sha512-Vx/mxnCDTQ8a5tMcRpku49+YgDl91XS5FJ0ZjPWR7JQOW8EEurDmVreNESrrIugTzQhSUp4eJXdGmncwxzwI9A==
2959+
version "5.0.0-beta.3"
2960+
resolved "https://registry.yarnpkg.com/@mui/x-date-pickers/-/x-date-pickers-5.0.0-beta.3.tgz#e9fbd85fd787f80502de8bbc29398121aedcf627"
2961+
integrity sha512-SrcGhwbyXal039I00+/8xNh8qGp0Y/iqWhhRqWk7Dy2lBpxIchNDUAvWtG27QfesxSRmhspo51dotpoG04u41A==
29622962
dependencies:
29632963
"@babel/runtime" "^7.18.6"
29642964
"@date-io/core" "^2.14.0"

0 commit comments

Comments
 (0)