fix(manager): errors/warnings rewrites each other

Author: rvsia

packages/form-state-manager/src/tests/utils/manager-api.test.js

@@ -2091,6 +2091,36 @@ describe('managerApi', () => {
       expect(managerApi().getFieldState('field').meta.error).toEqual(undefined);
     });
 
+    it('warning should rewrite error - sync', () => {
+      const managerApi = createManagerApi({});
+      managerApi().registerField({
+        name: 'field',
+        initialValue: 'warning',
+        validate: (value) => (value === 'warning' ? { type: 'warning', error: someError } : 'error'),
+        render,
+        internalId: 1
+      });
+
+      expect(managerApi().getFieldState('field').meta.warning).toEqual(someError);
+      expect(managerApi().getFieldState('field').meta.error).toEqual(undefined);
+      expect(managerApi().getFieldState('field').meta.valid).toEqual(true);
+      expect(managerApi().getFieldState('field').meta.invalid).toEqual(false);
+
+      managerApi().change('field', 'error');
+
+      expect(managerApi().getFieldState('field').meta.warning).toEqual(undefined);
+      expect(managerApi().getFieldState('field').meta.error).toEqual('error');
+      expect(managerApi().getFieldState('field').meta.valid).toEqual(false);
+      expect(managerApi().getFieldState('field').meta.invalid).toEqual(true);
+
+      managerApi().change('field', 'warning');
+
+      expect(managerApi().getFieldState('field').meta.warning).toEqual(someError);
+      expect(managerApi().getFieldState('field').meta.error).toEqual(undefined);
+      expect(managerApi().getFieldState('field').meta.valid).toEqual(true);
+      expect(managerApi().getFieldState('field').meta.invalid).toEqual(false);
+    });
+
     it('should save type: warning as warning - async', (done) => {
       expect.assertions(2);
 
@@ -2105,6 +2135,52 @@ describe('managerApi', () => {
         done();
       });
     });
+
+    it('warning should rewrite error - async', (done) => {
+      expect.assertions(18);
+
+      const asyncValidate = jest
+        .fn()
+        .mockImplementation((value) => Promise.reject(value === 'warning' ? { type: 'warning', error: someError } : 'error'));
+
+      const managerApi = createManagerApi({});
+      managerApi().registerField({ name: 'field', initialValue: 'warning', validate: asyncValidate, render, internalId: 1 });
+
+      expect(managerApi().getFieldState('field').meta.validating).toEqual(true);
+
+      setImmediate(() => {
+        expect(managerApi().getFieldState('field').meta.warning).toEqual(someError);
+        expect(managerApi().getFieldState('field').meta.error).toEqual(undefined);
+        expect(managerApi().getFieldState('field').meta.valid).toEqual(true);
+        expect(managerApi().getFieldState('field').meta.invalid).toEqual(false);
+        expect(managerApi().getFieldState('field').meta.validating).toEqual(false);
+
+        managerApi().change('field', 'error');
+
+        expect(managerApi().getFieldState('field').meta.validating).toEqual(true);
+
+        setImmediate(() => {
+          expect(managerApi().getFieldState('field').meta.warning).toEqual(undefined);
+          expect(managerApi().getFieldState('field').meta.error).toEqual('error');
+          expect(managerApi().getFieldState('field').meta.valid).toEqual(false);
+          expect(managerApi().getFieldState('field').meta.invalid).toEqual(true);
+          expect(managerApi().getFieldState('field').meta.validating).toEqual(false);
+
+          managerApi().change('field', 'warning');
+
+          expect(managerApi().getFieldState('field').meta.validating).toEqual(true);
+
+          setImmediate(() => {
+            expect(managerApi().getFieldState('field').meta.warning).toEqual(someError);
+            expect(managerApi().getFieldState('field').meta.error).toEqual(undefined);
+            expect(managerApi().getFieldState('field').meta.valid).toEqual(true);
+            expect(managerApi().getFieldState('field').meta.invalid).toEqual(false);
+            expect(managerApi().getFieldState('field').meta.validating).toEqual(false);
+            done();
+          });
+        });
+      });
+    });
   });
 
   describe('invalid submit', () => {

packages/form-state-manager/src/utils/manager-api.ts

@@ -291,15 +291,16 @@ const createManagerApi: CreateManagerApi = ({
     runFormValidation = false;
   }
 
-  function handleFieldError(name: string, isValid: boolean, error: string | undefined = undefined) {
+  function handleFieldError(name: string, isValid: boolean, error: string | undefined = undefined, validating = false) {
     setFieldState(name, (prev: FieldState) => ({
       ...prev,
       meta: {
         ...prev.meta,
         error,
         valid: isValid,
         invalid: !isValid,
-        validating: false
+        validating,
+        warning: undefined
       }
     }));
 
@@ -322,7 +323,7 @@ const createManagerApi: CreateManagerApi = ({
       if (validators.length > 0) {
         const result = composeValidators(validators as Validator[])(value, state.values);
         if (isPromise(result)) {
-          handleFieldError(name, true);
+          handleFieldError(name, true, undefined, true);
           (result as Promise<string | undefined>)
             .then(() => handleFieldError(name, true))
             .catch((response) => {
@@ -331,7 +332,11 @@ const createManagerApi: CreateManagerApi = ({
                   ...prev,
                   meta: {
                     ...prev.meta,
-                    warning: response.error
+                    warning: response.error,
+                    error: undefined,
+                    valid: true,
+                    invalid: false,
+                    validating: false
                   }
                 }));
               } else {
@@ -345,7 +350,11 @@ const createManagerApi: CreateManagerApi = ({
               ...prev,
               meta: {
                 ...prev.meta,
-                warning: (result as WarningObject)?.error
+                warning: (result as WarningObject)?.error,
+                error: undefined,
+                valid: true,
+                invalid: false,
+                validating: false
               }
             }));
           } else {