Merge pull request #575 from rvsia/removeTabItem

fix(renderer): tab children do not need component anymore

Author: Hyperkid123

packages/pf4-component-mapper/demo/demo-schemas/sandbox.js

@@ -133,8 +133,7 @@ const output = {
               ],
               component: components.SUB_FORM
             }
-          ],
-          component: components.TAB_ITEM
+          ]
         },
         {
           title: 'Tab 2',
@@ -240,8 +239,7 @@ const output = {
               ],
               component: components.SUB_FORM
             }
-          ],
-          component: components.TAB_ITEM
+          ]
         },
         {
           title: 'Tab 3',
@@ -418,8 +416,7 @@ const output = {
               ],
               component: components.SUB_FORM
             }
-          ],
-          component: components.TAB_ITEM
+          ]
         },
         {
           title: 'Tab 4',
@@ -464,8 +461,7 @@ const output = {
               ],
               component: components.SUB_FORM
             }
-          ],
-          component: components.TAB_ITEM
+          ]
         },
         {
           title: 'Mixed',
@@ -555,8 +551,7 @@ const output = {
               ],
               component: components.SUB_FORM
             }
-          ],
-          component: components.TAB_ITEM
+          ]
         }
       ],
       component: components.TABS,

packages/react-form-renderer/src/files/default-schema-validator.js

@@ -245,7 +245,7 @@ const iterateOverFields = (fields, componentMapper, validatorTypes, actionTypes,
       return iterateOverFields(field, componentMapper, validatorTypes, actionTypes, schemaValidatorMapper);
     }
 
-    if (parent.component !== componentTypes.WIZARD) {
+    if (![componentTypes.WIZARD, componentTypes.TABS].includes(parent.component)) {
       if (parent.component !== componentTypes.WIZARD && !field.hasOwnProperty('component')) {
         throw new DefaultSchemaError(`Each fields item must have "component" property!`);
       }

packages/react-renderer-demo/src/components/navigation/examples-definitions.js

@@ -48,7 +48,7 @@ export const baseExamples = [
   {
     component: componentTypes.TABS,
     link: componentTypes.TABS,
-    linkText: 'Tabs / Tab item'
+    linkText: 'Tabs'
   },
   {
     component: componentTypes.SUB_FORM,

packages/react-renderer-demo/src/pages/component-example/tabs.js

@@ -12,7 +12,6 @@ const schema = {
       name: 'tabs',
       fields: [
         {
-          component: componentTypes.TAB_ITEM,
           validateFields: ['apple'],
           name: '1',
           title: 'Fruits',
@@ -32,7 +31,6 @@ const schema = {
           ]
         },
         {
-          component: componentTypes.TAB_ITEM,
           name: '2',
           title: 'Vegetables',
           description: 'Here you can find vegetables',

packages/react-renderer-demo/src/pages/renderer/component-mapping.md

@@ -23,7 +23,6 @@ const componentTypes = {
   [componentTypes.SUB_FORM]: 'sub-form',
   [componentTypes.RADIO]: 'radio',
   [componentTypes.TABS]: 'tabs',
-  [componentTypes.TAB_ITEM]: 'tab-item',
   [componentTypes.DATE_PICKER]: 'date-picker',
   [componentTypes.TIME_PICKER]: 'time-picker',
   [componentTypes.WIZARD]: 'wizard',