Merge pull request #183 from data-driven-forms/fix-data-type-array-validation

fix(renderer): data-type validation for arrays.

Author: rvsia

packages/react-form-renderer/src/tests/validators/validators.test.js

@@ -189,6 +189,41 @@ describe('New validators', () => {
     it('should return numberValidator and fail', () => {
       expect(dataTypeValidator('integer')({ message: 'Should be super interger' })('Foo')).toEqual('Should be super interger');
     });
+
+    describe('data-type arrays', () => {
+      it('should pass validation of an array of strings', () => {
+        expect(dataTypeValidator('string')()([ 'Foo', 'Bar', 'Baz' ])).toBeUndefined();
+      });
+
+      it('should fail validation of an array of strings', () => {
+        expect(dataTypeValidator('string')()([ 'Foo', 'Bar', 2 ])).toBe('Field value has to be string');
+      });
+
+      it('should pass validation of an array of integers', () => {
+        expect(dataTypeValidator('integer')()([ 1, 2, 3 ])).toBeUndefined();
+      });
+
+      it('should fail validation of an array of strings', () => {
+        expect(dataTypeValidator('integer')()([ 1, 2, 2.1 ])).toBe('Value must be integer');
+        expect(dataTypeValidator('integer')()([ 1, 2, 'foo' ])).toBe('Value must be integer');
+      });
+
+      it('should pass validation of an array of numbers', () => {
+        expect(dataTypeValidator('number')()([ 1, 2, 3.1 ])).toBeUndefined();
+      });
+
+      it('should fail validation of an array of numbers', () => {
+        expect(dataTypeValidator('number')()([ 1, 2, 'foo' ])).toBe('Values must be number');
+      });
+
+      it('should pass validation of an array of booleans', () => {
+        expect(dataTypeValidator('boolean')()([ true, true, false, false ])).toBeUndefined();
+      });
+
+      it('should fail validation of an array of booleans', () => {
+        expect(dataTypeValidator('boolean')()([ 'foo', 2, true ])).toBe('Field value has to be boolean');
+      });
+    });
   });
   describe('Validators default messages overrides', () => {
     beforeAll(() => {

packages/react-form-renderer/src/validators/index.js

@@ -46,6 +46,15 @@ export const pattern = memoize(({ pattern, message } = {}) => {
       return;
     }
 
+    if (Array.isArray(value)) {
+      const error = value.find(item => {
+        const parsedValue = typeof item === 'string' ? item : item.toString();
+        return pattern && !parsedValue.match(verifiedPattern);
+      });
+      const msg = prepareMsg(message, 'pattern').defaultMessage;
+      return error ? typeof msg === 'string' ? msg : msg(pattern) : undefined;
+    }
+
     const parsedValue = typeof value === 'string' ? value : value.toString();
     if (pattern && !parsedValue.match(verifiedPattern)) {
       const msg = prepareMsg(message, 'pattern').defaultMessage;
@@ -133,6 +142,11 @@ const stringValidator = memoize(({ message } = {}) => {
       return;
     }
 
+    if (Array.isArray(value)) {
+      const error = value.find(item => typeof item !== 'string');
+      return error ? prepareMsg(message, 'mustBeString').defaultMessage : undefined;
+    }
+
     if (typeof value !== 'string') {
       return prepareMsg(message, 'mustBeString').defaultMessage;
     }
@@ -145,6 +159,11 @@ const booleanValidator = memoize(({ message } = {}) =>
       return;
     }
 
+    if (Array.isArray(value)) {
+      const error = value.find(item => typeof item !== 'boolean');
+      return error ? prepareMsg(message, 'mustBeBool').defaultMessage : undefined;
+    }
+
     if (typeof value !== 'boolean') {
       return prepareMsg(message, 'mustBeBool').defaultMessage;
     }