Skip to content

Commit 45254ef

Browse files
committed
Changes based on review.
1 parent a814d1f commit 45254ef

23 files changed

+1377
-2328
lines changed

README.md

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -36,13 +36,10 @@ Data Driven Forms is a React library used for rendering and managing forms with
3636
- [Material-UI Mapper](#material-ui-mapper)
3737
- [PatternFly 3 Mapper](#patternfly-3-mapper)
3838
- [PatternFly 4 Mapper](#patternfly-4-mapper)
39-
<<<<<<< HEAD
4039
- [BlueprintJS Mapper](#blueprintjs-mapper)
4140
- [Semantic UI Mapper](#semantic-ui-mapper)
42-
=======
4341
- [Material-UI Mapper](#material-ui-mapper)
4442
- [Ant Design Mapper](#ant-design-mapper)
45-
>>>>>>> Added wizard.js
4643
- [Usage](#usage)
4744
- [Custom mapper](#custom-mapper)
4845
- [Basic provided components](#basic-provided-components)
@@ -112,7 +109,6 @@ $ npm install @data-driven-forms/blueprint-component-mapper -S
112109
$ yarn add @data-driven-forms/blueprint-component-mapper
113110
```
114111

115-
<<<<<<< HEAD
116112
#### [Semantic UI Mapper](https://data-driven-forms.org/mappers/suir-component-mapper)
117113

118114
```console
@@ -125,7 +121,6 @@ $ yarn add @data-driven-forms/suir-component-mapper
125121

126122
Component libraries in mappers are external dependencies. Make sure to install them in your bundles.
127123

128-
=======
129124
#### [Ant Design Mapper](https://www.npmjs.com/package/@data-driven-forms/ant-component-mapper)
130125

131126
```console
@@ -136,7 +131,6 @@ $ npm install @data-driven-forms/ant-component-mapper -S
136131
$ yarn add @data-driven-forms/ant-component-mapper
137132
```
138133

139-
>>>>>>> Added wizard.js
140134
### Usage
141135

142136
In order to Data Driven Forms in your component you need the renderer and a component mapper, which provides component mapper and form template.

package.json

Lines changed: 21 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
]
4444
},
4545
"devDependencies": {
46-
"@babel/plugin-transform-runtime": "^7.9.0",
46+
"@babel/plugin-transform-runtime": "^7.10.3",
4747
"@babel/preset-typescript": "^7.9.0",
4848
"@khala/commit-analyzer-wildcard": "^2.4.1",
4949
"@khala/npm-release-monorepo": "^2.4.1",
@@ -64,31 +64,44 @@
6464
"eslint-config-react-app": "^5.2.0",
6565
"eslint-loader": "^3.0.3",
6666
"eslint-plugin-flowtype": "^4.6.0",
67-
"eslint-plugin-import": "^2.20.1",
68-
"eslint-plugin-jsx-a11y": "^6.2.3",
69-
"eslint-plugin-prettier": "^3.1.2",
70-
"eslint-plugin-react": "^7.18.3",
67+
"eslint-plugin-import": "^2.22.0",
68+
"eslint-plugin-jsx-a11y": "^6.3.1",
69+
"eslint-plugin-prettier": "^3.1.4",
70+
"eslint-plugin-react": "^7.20.1",
7171
"eslint-plugin-react-hooks": "^2.4.0",
7272
"glob": "^7.1.6",
7373
"identity-obj-proxy": "^3.0.0",
7474
"inquirer": "^7.1.0",
7575
"jest": "^24.8.0",
76-
"lerna": "^3.13.1",
76+
"lerna": "^3.22.1",
7777
"ncp": "^2.0.0",
7878
"prettier": "^1.19.1",
7979
"replace-in-file": "^6.0.0",
8080
"semantic-release": "^16.0.4",
8181
"source-map-loader": "^0.2.4",
8282
"strip-ansi": "^6.0.0",
83-
"terser-webpack-plugin": "^1.3.0",
83+
"terser-webpack-plugin": "^1.4.4",
8484
"ts-loader": "^7.0.5",
8585
"tslint": "^6.1.2",
8686
"tslint-config-prettier": "^1.18.0",
8787
"typescript": "^3.9.3"
8888
},
8989
"release": {
9090
"monorepo": "./packages",
91-
"branches": ["+([0-9])?(.{+([0-9]),x}).x", "master", "next", "next-major", {"name": "beta", "prerelease": true}, {"name": "alpha", "prerelease": true}],
91+
"branches": [
92+
"+([0-9])?(.{+([0-9]),x}).x",
93+
"master",
94+
"next",
95+
"next-major",
96+
{
97+
"name": "beta",
98+
"prerelease": true
99+
},
100+
{
101+
"name": "alpha",
102+
"prerelease": true
103+
}
104+
],
92105
"plugins": [
93106
"@khala/npm-release-monorepo",
94107
[

packages/ant-component-mapper/README.md

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,16 @@
1-
[![npm version](https://badge.fury.io/js/%40data-driven-forms%2Fmui-component-mapper.svg)](https://badge.fury.io/js/%40data-driven-forms%2Fmui-component-mapper)
1+
[![npm version](https://badge.fury.io/js/%40data-driven-forms%2Fant-component-mapper.svg)](https://badge.fury.io/js/%40data-driven-forms%2Fant-component-mapper)
22

33
[![Data Driven Form logo](images/logo.png)](https://data-driven-forms.org/)
44

55
Material-UI component mapper for [Data Driven Forms](https://github.com/data-driven-forms/react-forms).
66

77
:book: For more information please visit the [documentation](https://data-driven-forms.org/). :book:
88

9-
Used by [ManageIQ](http://manageiq.org/), Red Hat Cloud Services.
10-
119
**Table of Contents**
1210

1311
- [Installation](#installation)
1412
- [React Form Renderer](#react-form-renderer)
15-
- [MUI mapper](#mui-mapper)
13+
- [ANT mapper](#ant-mapper)
1614
- [Usage](#usage)
1715
- [Basic provided components](#basic-provided-components)
1816
- [Useful links](#useful-links)
@@ -39,14 +37,14 @@ $ yarn add @data-driven-forms/react-form-renderer
3937

4038
Optionally you can install one of provided mappers:
4139

42-
#### [MUI mapper](https://www.npmjs.com/package/@data-driven-forms/mui-component-mapper)
40+
#### [ANT mapper](https://www.npmjs.com/package/@data-driven-forms/ant-component-mapper)
4341

4442
```console
45-
$ npm install @data-driven-forms/mui-component-mapper -S
43+
$ npm install @data-driven-forms/ant-component-mapper -S
4644
```
4745

4846
```console
49-
$ yarn add @data-driven-forms/mui-component-mapper
47+
$ yarn add @data-driven-forms/ant-component-mapper
5048
```
5149

5250

@@ -57,7 +55,7 @@ For using Data Driven Forms in your component you need the renderer and a compon
5755
```jsx
5856
import React from 'react';
5957
import FormRenderer, { componentTypes } from '@data-driven-forms/react-form-renderer';
60-
import { componentMapper, layoutMapper } from '@data-driven-forms/mui-component-mapper';
58+
import { componentMapper, layoutMapper } from '@data-driven-forms/ant-component-mapper';
6159

6260
const schema = {
6361
fields: [{
@@ -100,7 +98,7 @@ Data Driven Forms supports all kinds of component, basic set is consisted of:
10098
- [Material-UI documentation](https://material-ui.com/)
10199
- NPM
102100
- [React Form Renderer](https://www.npmjs.com/package/@data-driven-forms/react-form-renderer)
103-
- [MaterialUI Mapper](https://www.npmjs.com/package/@data-driven-forms/mui-component-mapper)
101+
- [MaterialUI Mapper](https://www.npmjs.com/package/@data-driven-forms/ant-component-mapper)
104102

105103

106104
### Development setup
@@ -124,7 +122,7 @@ yarn build
124122
Each package has a small playground `package/demo`, where you can test your changes.
125123

126124
```console
127-
cd packages/mui-component-mapper
125+
cd packages/ant-component-mapper
128126
yarn start
129127
```
130128

@@ -144,7 +142,7 @@ Tests needed to be run from the core folder.
144142
```console
145143
yarn test
146144

147-
yarn test packages/mui-component-mapper
145+
yarn test packages/ant-component-mapper
148146
```
149147

150148
#### Commits
@@ -156,7 +154,7 @@ Format:
156154
```
157155
[type]([package]): message
158156
159-
fix(mui): title accepts node
157+
fix(ant): title accepts node
160158
```
161159

162160
Types:

packages/ant-component-mapper/demo/index.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@ import demoSchema from '@data-driven-forms/common/src/demoschema';
88
import { componentMapper, FormTemplate } from '../src';
99
import wizardSchema from './demo-schemas/wizard-schema';
1010

11-
12-
1311
const style = {
1412
position: 'relative',
1513
width:'70%',

packages/ant-component-mapper/package.json

Lines changed: 9 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -50,26 +50,7 @@
5050
"webpack": "^4.25.1",
5151
"webpack-cli": "^3.1.2",
5252
"webpack-dev-server": "^3.1.10",
53-
"webpack-merge": "^4.1.4"
54-
},
55-
"peerDependencies": {
56-
"@data-driven-forms/react-form-renderer": "^1.9.3",
57-
"react": "^16.13.0",
58-
"react-dom": "^16.13.0"
59-
},
60-
"release": {
61-
"prepare": [
62-
"@semantic-release/npm",
63-
{
64-
"path": "@semantic-release/git",
65-
"assets": [
66-
"package.json"
67-
],
68-
"message": "Release of new version: ${nextRelease.version} <no> [skip ci]"
69-
}
70-
]
71-
},
72-
"dependencies": {
53+
"webpack-merge": "^4.1.4",
7354
"@date-io/date-fns": "^1.0.1",
7455
"@date-io/moment": "^1.0.1",
7556
"classnames": "^2.2.6",
@@ -78,5 +59,13 @@
7859
"moment": "^2.23.0",
7960
"react-select": "^2.2.0"
8061
},
62+
"peerDependencies": {
63+
"@data-driven-forms/react-form-renderer": "^1.9.3",
64+
"antd": "^4.2.0",
65+
"react": "^16.13.0",
66+
"react-dom": "^16.13.0"
67+
},
68+
"dependencies": {
69+
},
8170
"postpublish": "export RELEASE_DEMO=true"
8271
}

packages/ant-component-mapper/rollup.config.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,9 @@ const antExternals = createFilter(
2020
'react-dom',
2121
'prop-types',
2222
'@data-driven-forms/react-form-renderer',
23-
'antd/**'
23+
'antd/**',
24+
'@data-driven-forms/react-form-renderer/**',
25+
'antd'
2426
],
2527
null,
2628
{ resolve: false }

packages/ant-component-mapper/scripts/update_demo.sh

Lines changed: 0 additions & 13 deletions
This file was deleted.

packages/ant-component-mapper/src/common/is-required.js

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,10 @@
11
import React from 'react';
22
import { childrenPropTypes } from '@data-driven-forms/common/src/prop-types-templates';
3-
4-
const styles = {
5-
color: '#ff4d4f',
6-
marginRight: '4px'
7-
};
3+
import './style.scss';
84

95
const IsRequired = ({ children }) => (
106
<React.Fragment>
11-
<span style={styles} aria-hidden="true">
7+
<span className="styles" aria-hidden="true">
128
*
139
</span>
1410
{children}
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
.styles {
2+
color: #ff4d4f;
3+
margin-right: 4px;
4+
}

packages/ant-component-mapper/src/files/checkbox.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import React from 'react';
22
import PropTypes from 'prop-types';
33
import { Checkbox as AntCheckbox } from 'antd';
4-
import { meta, input } from '@data-driven-forms/common/src/prop-types-templates';
54
import MultipleChoiceList from '../common/multiple-choice-list';
65
import { useFieldApi } from '@data-driven-forms/react-form-renderer';
76
import { validationError } from '../common/helpers';
@@ -31,8 +30,6 @@ export const SingleCheckbox = (props) => {
3130
};
3231

3332
SingleCheckbox.propTypes = {
34-
input,
35-
meta,
3633
isReadOnly: PropTypes.bool,
3734
isDisabled: PropTypes.bool,
3835
isRequired: PropTypes.bool,

0 commit comments

Comments
 (0)