Skip to content

Commit 50b70f8

Browse files
authored
Merge pull request #102 from rvsia/remove-core-js
Use lodash for flat in PF4 wizard
2 parents 9cb3876 + 62303a6 commit 50b70f8

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

package.json

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,7 @@
2323
"jest": {
2424
"verbose": true,
2525
"setupFiles": [
26-
"<rootDir>/config/jest.setup.js",
27-
"core-js"
26+
"<rootDir>/config/jest.setup.js"
2827
],
2928
"collectCoverageFrom": [
3029
"<rootDir>/packages/**/src/**/*.js",
@@ -41,7 +40,6 @@
4140
"@semantic-release/git": "^7.0.8",
4241
"@semantic-release/npm": "^5.1.4",
4342
"atob-lite": "^2.0.0",
44-
"core-js": "^3.2.1",
4543
"identity-obj-proxy": "^3.0.0",
4644
"jest": "^24.8.0",
4745
"lerna": "^3.13.1",

packages/pf4-component-mapper/src/form-fields/wizard/wizard.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import WizardStep from './wizard-step';
66
import './wizard-styles.scss';
77
import get from 'lodash/get';
88
import set from 'lodash/set';
9+
import flattenDeep from 'lodash/flattenDeep';
910

1011
const Modal = ({ children, container, inModal }) => inModal ? createPortal(<Backdrop>
1112
<Bullseye>
@@ -96,9 +97,9 @@ class Wizard extends React.Component {
9697
const finalObject = {};
9798

9899
// Find only visited fields
99-
Object.values([ ...visitedSteps, this.state.activeStep ]
100-
.reduce((obj, key) => ({ ...obj, [key]: finalRegisteredFieldsHistory[key] }), { }))
101-
.flat(Infinity).forEach((key) => set(finalObject, key, get(values, key)));
100+
flattenDeep(Object.values([ ...visitedSteps, this.state.activeStep ]
101+
.reduce((obj, key) => ({ ...obj, [key]: finalRegisteredFieldsHistory[key] }), { })))
102+
.forEach((key) => set(finalObject, key, get(values, key)));
102103

103104
return finalObject;
104105
}

0 commit comments

Comments
 (0)