Skip to content

Commit 55dc743

Browse files
authored
Merge pull request #1195 from rvsia/pf4rtlTests
Convert PF4 tests to RTL
2 parents 77953f0 + b7f36fa commit 55dc743

20 files changed

+829
-2385
lines changed

packages/pf4-component-mapper/config/jest.setup.js

Lines changed: 0 additions & 1 deletion
This file was deleted.

packages/pf4-component-mapper/src/form-group/form-group.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ const FormGroup = ({ label, isRequired, helperText, meta, validateOnMount, descr
99
isRequired={isRequired}
1010
label={!hideLabel && label}
1111
fieldId={id}
12-
helperText={(meta.touched && meta.warning) || helperText}
12+
helperText={((meta.touched || validateOnMount) && meta.warning) || helperText}
1313
helperTextInvalid={meta.error || meta.submitError}
1414
{...showError(meta, validateOnMount)}
1515
{...FormGroupProps}

packages/pf4-component-mapper/src/select/select/select.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ const itemToString = (value, isMulti, showMore, handleShowMore, handleChange) =>
3939
<span className="pf-c-chip__text" id={`pf-random-id-${index}-${label}`}>
4040
{label}
4141
</span>
42-
<button onClick={() => handleChange(item)} className="pf-c-button pf-m-plain" type="button">
42+
<button onClick={() => handleChange(item)} className="pf-c-button pf-m-plain" type="button" aria-label="remove option">
4343
<CloseIcon />
4444
</button>
4545
</div>

packages/pf4-component-mapper/src/tests/__snapshots__/form-fields.test.js.snap

Lines changed: 0 additions & 113 deletions
This file was deleted.

0 commit comments

Comments
 (0)