Skip to content

Commit 64c3302

Browse files
committed
Remove convertWarningToError function
1 parent ccd55b7 commit 64c3302

File tree

4 files changed

+2
-46
lines changed

4 files changed

+2
-46
lines changed

packages/react-form-renderer/src/files/use-field-api.d.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ export interface UseFieldApiConfig extends AnyObject {
1111
name: string;
1212
validate?: ValidatorType[];
1313
useWarnings?: boolean;
14-
convertWarningToError?: boolean;
1514
}
1615
export interface UseFieldApiComponentConfig extends UseFieldConfig<any> {
1716
name: string;

packages/react-form-renderer/src/files/use-field-api.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ const createFieldProps = (name, formOptions) => {
8484
};
8585
};
8686

87-
const useFieldApi = ({ name, initializeOnMount, component, render, validate, resolveProps, useWarnings, convertWarningToError, ...props }) => {
87+
const useFieldApi = ({ name, initializeOnMount, component, render, validate, resolveProps, useWarnings, ...props }) => {
8888
const { validatorMapper, formOptions } = useContext(RendererContext);
8989
const [warning, setWarning] = useState();
9090

@@ -216,8 +216,7 @@ const useFieldApi = ({ name, initializeOnMount, component, render, validate, res
216216
...(useWarnings && {
217217
meta: {
218218
...fieldProps.meta,
219-
warning,
220-
...(convertWarningToError && { error: warning })
219+
warning
221220
}
222221
}),
223222
input: {

packages/react-form-renderer/src/tests/form-renderer/validator.test.js

Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -110,34 +110,6 @@ describe('FormRenderer validator', () => {
110110
expect(wrapper.find('#warning').text()).toEqual('Required');
111111
});
112112

113-
it('should convert warning to error', async () => {
114-
await act(async () => {
115-
wrapper = mount(
116-
<FormRenderer
117-
FormTemplate={FormTemplate}
118-
componentMapper={{
119-
[componentTypes.TEXT_FIELD]: TextField
120-
}}
121-
schema={{
122-
fields: [
123-
{
124-
useWarnings: true,
125-
convertWarningToError: true,
126-
component: 'text-field',
127-
name: NAME,
128-
validate: [{ type: 'required', warning: true }]
129-
}
130-
]
131-
}}
132-
onSubmit={jest.fn()}
133-
/>
134-
);
135-
});
136-
wrapper.update();
137-
138-
expect(wrapper.find('#error').text()).toEqual('Required');
139-
});
140-
141113
it('should convert function validator to warning', async () => {
142114
const ERROR = 'SOME-ERROR';
143115

packages/react-renderer-demo/src/pages/schema/validator-warnings.md

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -58,18 +58,4 @@ const TextFieldWarning = (props) => {
5858
};
5959
```
6060

61-
### Convert to error
62-
63-
By default, Data Driven Forms mappers are not supporting showing warnings. However you can convert the warning into an error - set `convertWarningToError` to `true`. This will replace `meta.error` with `meta.warning`, but `valid` etc. will be unchanged.
64-
65-
```jsx
66-
{
67-
name: 'warning-as-error',
68-
component: 'text-field',
69-
useWarnings: true,
70-
convertWarningToError: true,
71-
validate: [{type: 'required', warning: true}]
72-
}
73-
```
74-
7561
</DocPage>

0 commit comments

Comments
 (0)