Skip to content

Commit b9675ef

Browse files
authored
Merge pull request #1193 from rvsia/suiTestsToRTL
Convert semantic tests to RTL
2 parents a6c0cfb + e10789e commit b9675ef

File tree

10 files changed

+361
-871
lines changed

10 files changed

+361
-871
lines changed

packages/suir-component-mapper/config/jest.setup.js

Lines changed: 0 additions & 1 deletion
This file was deleted.

packages/suir-component-mapper/src/dual-list-select/dual-list-select.js

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -163,6 +163,8 @@ const DualList = ({
163163
rightValues,
164164
handleValuesClick,
165165
validateOnMount,
166+
leftSortTitle,
167+
rightSortTitle,
166168
OptionsListProps,
167169
OptionProps,
168170
LabelProps: { className: labelClassName, error: labelError, ...LabelProps },
@@ -212,6 +214,7 @@ const DualList = ({
212214
value={state.filterOptions}
213215
placeholder={filterOptionsTitle}
214216
id={`${input.name}-options-toolbar`}
217+
sortTitle={leftSortTitle}
215218
{...ToolbarProps}
216219
/>
217220
</GridColumn>
@@ -296,6 +299,7 @@ const DualList = ({
296299
value={state.filterValue}
297300
placeholder={filterValueTitle}
298301
id={`${input.name}-value-toolbar`}
302+
sortTitle={rightSortTitle}
299303
{...ToolbarProps}
300304
/>
301305
</GridColumn>
@@ -355,6 +359,8 @@ DualList.propTypes = {
355359
rightValues: PropTypes.array,
356360
handleValuesClick: PropTypes.func,
357361
validateOnMount: PropTypes.bool,
362+
leftSortTitle: PropTypes.node,
363+
rightSortTitle: PropTypes.node,
358364
/** Sub components customization API */
359365
OptionsListProps: PropTypes.object,
360366
OptionProps: PropTypes.object,
@@ -384,6 +390,8 @@ DualList.defaultProps = {
384390
filterValueTitle: 'Filter selected value',
385391
filterOptionsText: 'Remove your filter to see all options',
386392
filterValueText: 'Remove your filter to see all selected',
393+
leftSortTitle: 'Sort options',
394+
rightSortTitle: 'Sort value',
387395
options: [],
388396
allToLeft: true,
389397
allToRight: true,

packages/suir-component-mapper/src/field-array/field-array.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -228,6 +228,7 @@ const DynamicArray = ({ ...props }) => {
228228
<Button
229229
icon="undo"
230230
className="ddorg__suir__mapper__field-array-undo"
231+
aria-label="undo"
231232
{...UndoButtonProps}
232233
type="button"
233234
disabled={state.index === 0}
@@ -236,6 +237,7 @@ const DynamicArray = ({ ...props }) => {
236237
<Button
237238
icon="redo"
238239
className="ddorg__suir__mapper__field-array-redo"
240+
aria-label="redo"
239241
{...RedoButtonProps}
240242
type="button"
241243
disabled={state.index === state.history.length}

0 commit comments

Comments
 (0)