Merge pull request #864 from rvsia/managerValidationErrors

fix(manager): compute hasValidationErrors

Author: rvsia

packages/form-state-manager/src/tests/utils/manager-api.test.js

@@ -602,6 +602,7 @@ describe('managerApi', () => {
     expect(managerApi().submitSucceeded).toEqual(false);
     expect(managerApi().submitErrors).toEqual(error);
     expect(managerApi().hasSubmitErrors).toEqual(true);
+    expect(managerApi().hasValidationErrors).toEqual(false);
   });
 
   it('onsubmit receives an error - form level', () => {
@@ -624,6 +625,7 @@ describe('managerApi', () => {
     expect(managerApi().submitSucceeded).toEqual(false);
     expect(managerApi().submitErrors).toEqual(error);
     expect(managerApi().hasSubmitErrors).toEqual(true);
+    expect(managerApi().hasValidationErrors).toEqual(false);
   });
 
   it('getField state should return correct field state', () => {
@@ -1071,6 +1073,7 @@ describe('managerApi', () => {
       expect(managerApi().getState().valid).toEqual(false);
       expect(managerApi().getState().invalid).toEqual(true);
       expect(managerApi().getState().validating).toEqual(false);
+      expect(managerApi().hasValidationErrors).toEqual(true);
     });
 
     it('should pass async level validation', () => {
@@ -1155,6 +1158,7 @@ describe('managerApi', () => {
         expect(managerApi().getState().valid).toEqual(false);
         expect(managerApi().getState().invalid).toEqual(true);
         expect(managerApi().getState().validating).toEqual(false);
+        expect(managerApi().hasValidationErrors).toEqual(true);
       });
     });
 
@@ -1173,13 +1177,15 @@ describe('managerApi', () => {
       expect(managerApi().getState().valid).toEqual(false);
       expect(managerApi().getState().invalid).toEqual(true);
       expect(managerApi().getState().validating).toEqual(false);
+      expect(managerApi().hasValidationErrors).toEqual(true);
 
       change('foo', 'ok');
 
       expect(managerApi().getState().errors).toEqual({});
       expect(managerApi().getState().valid).toEqual(true);
       expect(managerApi().getState().invalid).toEqual(false);
       expect(managerApi().getState().validating).toEqual(false);
+      expect(managerApi().hasValidationErrors).toEqual(false);
     });
 
     it('should fail and then pass async validation', () => {
@@ -1200,6 +1206,7 @@ describe('managerApi', () => {
         expect(managerApi().getState().valid).toEqual(false);
         expect(managerApi().getState().invalid).toEqual(true);
         expect(managerApi().getState().validating).toEqual(false);
+        expect(managerApi().hasValidationErrors).toEqual(true);
 
         change('foo', 'ok');
         jest.advanceTimersByTime(10);
@@ -1208,6 +1215,7 @@ describe('managerApi', () => {
           expect(managerApi().getState().valid).toEqual(true);
           expect(managerApi().getState().invalid).toEqual(false);
           expect(managerApi().getState().validating).toEqual(false);
+          expect(managerApi().hasValidationErrors).toEqual(false);
         });
       });
     });

packages/form-state-manager/src/utils/manager-api.ts

@@ -432,6 +432,7 @@ const createManagerApi: CreateManagerApi = ({
         .then(() => {
           if (!state.validating) {
             state.errors = {};
+            state.hasValidationErrors = false;
             state.valid = true;
             state.invalid = false;
             state.error = undefined;
@@ -440,6 +441,7 @@ const createManagerApi: CreateManagerApi = ({
         })
         .catch((errors) => {
           state.errors = errors;
+          state.hasValidationErrors = true;
           state.valid = false;
           state.invalid = true;
         });
@@ -451,10 +453,12 @@ const createManagerApi: CreateManagerApi = ({
         handleFieldError(name, false, syncError[name]);
       });
       state.errors = syncError;
+      state.hasValidationErrors = true;
       state.valid = false;
       state.invalid = true;
     } else {
       state.errors = {};
+      state.hasValidationErrors = false;
       state.valid = true;
       state.invalid = false;
       state.error = undefined;
@@ -795,13 +799,15 @@ const createManagerApi: CreateManagerApi = ({
       state.errors[name] = error;
       state.valid = false;
       state.invalid = true;
+      state.hasValidationErrors = true;
     } else {
       delete state.errors[name];
     }
 
     if (Object.keys(state.errors).length === 0) {
       state.valid = true;
       state.invalid = false;
+      state.hasValidationErrors = false;
     }
 
     render();