Skip to content

Commit f58a9b2

Browse files
committed
Fix error in validator by proper awaiting
1 parent 14866e1 commit f58a9b2

File tree

1 file changed

+43
-49
lines changed

1 file changed

+43
-49
lines changed

packages/react-form-renderer/src/tests/form-renderer/validator.test.js

Lines changed: 43 additions & 49 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import React from 'react';
2-
import { render, screen, act } from '@testing-library/react';
2+
import { render, screen } from '@testing-library/react';
33
import userEvent from '@testing-library/user-event';
44

55
import FormRenderer from '../../form-renderer';
@@ -84,68 +84,62 @@ describe('FormRenderer validator', () => {
8484
});
8585

8686
it('should convert object validator to warning', async () => {
87-
await act(async () => {
88-
render(
89-
<FormRenderer
90-
FormTemplate={FormTemplate}
91-
componentMapper={{
92-
[componentTypes.TEXT_FIELD]: TextFieldWarning,
93-
}}
94-
schema={{
95-
fields: [{ useWarnings: true, component: 'text-field', name: NAME, validate: [{ type: 'required', warning: true }] }],
96-
}}
97-
onSubmit={jest.fn()}
98-
/>
99-
);
100-
});
101-
102-
expect(screen.getByText('Required')).toBeInTheDocument();
87+
render(
88+
<FormRenderer
89+
FormTemplate={FormTemplate}
90+
componentMapper={{
91+
[componentTypes.TEXT_FIELD]: TextFieldWarning,
92+
}}
93+
schema={{
94+
fields: [{ useWarnings: true, component: 'text-field', name: NAME, validate: [{ type: 'required', warning: true }] }],
95+
}}
96+
onSubmit={jest.fn()}
97+
/>
98+
);
99+
100+
expect(await screen.findByText('Required')).toBeInTheDocument();
103101
});
104102

105103
it('should convert function validator to warning', async () => {
106104
const ERROR = 'SOME-ERROR';
107105

108106
const customValidator = () => ({ type: 'warning', error: ERROR });
109107

110-
await act(async () => {
111-
render(
112-
<FormRenderer
113-
FormTemplate={FormTemplate}
114-
componentMapper={{
115-
[componentTypes.TEXT_FIELD]: TextFieldWarning,
116-
}}
117-
schema={{
118-
fields: [{ useWarnings: true, component: 'text-field', name: NAME, validate: [customValidator] }],
119-
}}
120-
onSubmit={jest.fn()}
121-
/>
122-
);
123-
});
124-
125-
expect(screen.getByText(ERROR)).toBeInTheDocument();
108+
render(
109+
<FormRenderer
110+
FormTemplate={FormTemplate}
111+
componentMapper={{
112+
[componentTypes.TEXT_FIELD]: TextFieldWarning,
113+
}}
114+
schema={{
115+
fields: [{ useWarnings: true, component: 'text-field', name: NAME, validate: [customValidator] }],
116+
}}
117+
onSubmit={jest.fn()}
118+
/>
119+
);
120+
121+
expect(await screen.findByText(ERROR)).toBeInTheDocument();
126122
});
127123

128124
it('should convert async function validator to warning', async () => {
129125
const ERROR = 'SOME-ERROR';
130126

131127
const customValidator = () => new Promise((res, rej) => setTimeout(() => rej({ type: 'warning', error: ERROR })));
132128

133-
await act(async () => {
134-
render(
135-
<FormRenderer
136-
FormTemplate={FormTemplate}
137-
componentMapper={{
138-
[componentTypes.TEXT_FIELD]: TextFieldWarning,
139-
}}
140-
schema={{
141-
fields: [{ useWarnings: true, component: 'text-field', name: NAME, validate: [customValidator] }],
142-
}}
143-
onSubmit={jest.fn()}
144-
/>
145-
);
146-
});
147-
148-
expect(screen.getByText(ERROR)).toBeInTheDocument();
129+
render(
130+
<FormRenderer
131+
FormTemplate={FormTemplate}
132+
componentMapper={{
133+
[componentTypes.TEXT_FIELD]: TextFieldWarning,
134+
}}
135+
schema={{
136+
fields: [{ useWarnings: true, component: 'text-field', name: NAME, validate: [customValidator] }],
137+
}}
138+
onSubmit={jest.fn()}
139+
/>
140+
);
141+
142+
expect(await screen.findByText(ERROR)).toBeInTheDocument();
149143
});
150144
});
151145
});

0 commit comments

Comments
 (0)