Skip to content

Commit f74ca4d

Browse files
authored
refactor(react): added suggestions from @rvsia
- removed dependency arrays for `setRegisteredFields` - handled `undefined` instead of void expression for `handleSubmitCallback` return
1 parent 325b1dd commit f74ca4d

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

packages/react-form-renderer/src/form-renderer/form-renderer.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ const FormRenderer = ({
5050
]), [decorators]);
5151

5252
const handleSubmitCallback = useCallback((values, formApi, ...args) => {
53-
return !isFunc(onSubmit) ? void 0 : onSubmit(values, {...formApi, fileInputs}, ...args);
53+
return !isFunc(onSubmit) ? undefined : onSubmit(values, {...formApi, fileInputs}, ...args);
5454
}, [onSubmit, fileInputs]);
5555

5656
const handleCancelCallback = useCallback((getState) => (...args) => {
@@ -86,13 +86,13 @@ const FormRenderer = ({
8686
setRegisteredFields((prev) => (
8787
prev[name] ? {...prev, [name]: prev[name] + 1} : {...prev, [name]: 1})
8888
);
89-
}, [setRegisteredFields]);
89+
}, []);
9090

9191
const internalUnRegisterField = useCallback((name) => {
9292
setRegisteredFields(({[name]: currentField, ...prev}) => (
9393
currentField && currentField > 1 ? {[name]: currentField - 1, ...prev} : prev
9494
));
95-
}, [setRegisteredFields]);
95+
}, []);
9696

9797
const internalGetRegisteredFields = useCallback(() => {
9898
const fields = registeredFields.current;

0 commit comments

Comments
 (0)