Merge pull request #1211 from rvsia/makePF4SelectTabbable

Hyperkid123 · web-flow · commit f954fcab5af8 · 2022-02-24T09:13:29.000+01:00
fix(pf4): make select focusable on keyboard
diff --git a/packages/pf4-component-mapper/src/select/select/select.js b/packages/pf4-component-mapper/src/select/select/select.js
@@ -214,6 +214,7 @@ const InternalSelect = ({
               className={`pf-c-select__toggle${isDisabled ? ' pf-m-disabled' : ''}${
                 isSearchable ? ' pf-m-typeahead' : ''
               } ddorg__pf4-component-mapper__select-toggle`}
+              tabIndex={0}
               {...toggleButtonProps}
             >
               <div className="pf-c-select_toggle-wrapper ddorg__pf4-component-mapper__select-toggle-wrapper">

Original file line number	Diff line number	Diff line change
`@@ -214,6 +214,7 @@ const InternalSelect = ({`
`214`	`214`	className={`pf-c-select__toggle${isDisabled ? ' pf-m-disabled' : ''}${
`215`	`215`	`isSearchable ? ' pf-m-typeahead' : ''`
`216`	`216`	} ddorg__pf4-component-mapper__select-toggle`}
	`217`	`+ tabIndex={0}`
`217`	`218`	`{...toggleButtonProps}`
`218`	`219`	`>`
`219`	`220`	`<div className="pf-c-select_toggle-wrapper ddorg__pf4-component-mapper__select-toggle-wrapper">`