Merge pull request #39 from chrishavlin/handling_revsered_dims

handling revesred dimension arrays

Author: chrishavlin

.github/workflows/build-test.yml

@@ -11,9 +11,9 @@ jobs:
         python-version: ['3.8', '3.9', '3.10']
 
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v3
     - name: Set up Python ${{ matrix.python-version }}
-      uses: actions/setup-python@v2
+      uses: actions/setup-python@v4
       with:
         python-version: ${{ matrix.python-version }}
     - name: Install dependencies

.github/workflows/check-build.yml

@@ -6,9 +6,9 @@ jobs:
     name: twinecheck
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v3
     - name: Set up Python
-      uses: actions/setup-python@v2
+      uses: actions/setup-python@v4
       with:
         python-version: 3.9
     - name: Install dependencies

.github/workflows/check-manifest.yml

@@ -7,9 +7,9 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - name: Checkout Source
-      uses: actions/checkout@v2
+      uses: actions/checkout@v3
     - name: Setup Python
-      uses: actions/setup-python@v2
+      uses: actions/setup-python@v4
       with:
         python-version: 3.9
     - name: install check-manifest

.github/workflows/create-release.yml

@@ -13,7 +13,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout code
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
       - name: Create Release
         id: create_release
         uses: actions/create-release@v1

.github/workflows/publish-to-pypi.yml

@@ -11,9 +11,9 @@ jobs:
     name: Build and Publish
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@master
+    - uses: actions/checkout@v3
     - name: Set up Python 3.9
-      uses: actions/setup-python@v1
+      uses: actions/setup-python@v4
       with:
         python-version: 3.9
     - name: Install dependencies

.github/workflows/style-checks.yml

@@ -6,11 +6,11 @@ jobs:
     name: flake8
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@master
+    - uses: actions/checkout@v3
     - name: Setup Python
-      uses: actions/setup-python@master
+      uses: actions/setup-python@v4
       with:
-        python-version: 3.8
+        python-version: 3.9
     - name: install
       id: install
       run : pip install -r tests/lint_requirements.txt
@@ -25,11 +25,11 @@ jobs:
     name: black
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@master
+    - uses: actions/checkout@v3
     - name: Setup Python
-      uses: actions/setup-python@master
+      uses: actions/setup-python@v4
       with:
-        python-version: 3.8
+        python-version: 3.9
     - name: install
       id: install
       run : pip install -r tests/lint_requirements.txt
@@ -44,11 +44,11 @@ jobs:
     name: isort
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@master
+    - uses: actions/checkout@v3
     - name: Setup Python
-      uses: actions/setup-python@master
+      uses: actions/setup-python@v4
       with:
-        python-version: 3.8
+        python-version: 3.9
     - name: install
       id: install
       run : pip install -r tests/lint_requirements.txt

HISTORY.md

@@ -1,5 +1,14 @@
 # History
 
+## 0.1.2 (2022-02-27)
+
+Bug fix release.
+
+### Fixes:
+* fixes handling of xarray variables with dimensions in decreasing
+  order (e.g., latitude from 90 to -90) without
+having to re-index the whole variable (PR [39](https://github.com/data-exp-lab/yt_xarray/pull/39)).
+
 ## 0.1.1 (2022-02-07)
 
 This release builds out the loading functions introduced in v0.1.0 and includes

setup.cfg

@@ -1,5 +1,5 @@
 [bumpversion]
-current_version = 0.1.1
+current_version = 0.1.2
 commit = True
 tag = True
 

setup.py

@@ -37,6 +37,6 @@
     test_suite="tests",
     tests_require=test_requirements,
     url="https://github.com/data-exp-lab/yt_xarray",
-    version="0.1.1",
+    version="0.1.2",
     zip_safe=False,
 )

tests/test_xr_to_yt.py

@@ -479,3 +479,64 @@ def test_add_3rd_axis_name(yt_geom):
 
     with pytest.raises(ValueError, match="Unsupported geometry type"):
         _ = xr2yt._add_3rd_axis_name("bad_geometry", expected[:-1])
+
+
+def _get_pixelized_slice(yt_ds):
+    slc = yt_ds.slice(
+        yt_ds.coordinates.axis_id["depth"],
+        yt_ds.domain_center[yt_ds.coordinates.axis_id["depth"]],
+        center=yt_ds.domain_center,
+    )
+    vals = yt_ds.coordinates.pixelize(
+        0,
+        slc,
+        ("stream", "test_field"),
+        yt_ds.arr([1, 359, -89, 89], "code_length"),
+        (400, 400),
+    )
+    return slc, vals
+
+
+def _get_ds_for_reverse_tests(stretched, use_callable, chunksizes):
+    ds = construct_minimal_ds(
+        min_x=1,
+        max_x=359,
+        min_z=50,
+        max_z=650,
+        min_y=89,
+        max_y=-89,
+        n_x=50,
+        n_y=100,
+        n_z=30,
+        z_stretched=stretched,
+        npseed=True,
+    )
+    yt_ds = ds.yt.load_grid(use_callable=use_callable, chunksizes=chunksizes)
+    return yt_ds
+
+
+@pytest.mark.parametrize(
+    "stretched,use_callable,chunksizes",
+    [
+        (True, False, None),
+        (False, False, None),
+        (False, True, None),
+        (False, True, 20),
+        (False, False, 20),
+    ],
+)
+def test_reversed_axis(stretched, use_callable, chunksizes):
+    # tests for when the incoming data is not positive-monotonic
+
+    yt_ds = _get_ds_for_reverse_tests(stretched, use_callable, chunksizes)
+
+    if stretched:
+        grid_obj = yt_ds.index.grids[0]
+        ax_id = yt_ds.coordinates.axis_id["latitude"]
+        assert np.all(grid_obj.cell_widths[ax_id] > 0)
+
+    slc, vals = _get_pixelized_slice(yt_ds)
+
+    pdy_lats = slc._generate_container_field("pdy")
+    assert np.all(pdy_lats > 0)
+    assert np.all(np.isfinite(vals))