Add strings isNullOrEmpty check

Author: psainics

database-commons/src/main/java/io/cdap/plugin/db/DBErrorDetailsProvider.java

@@ -25,7 +25,6 @@
 import io.cdap.cdap.api.exception.ProgramFailureException;
 import io.cdap.cdap.etl.api.exception.ErrorContext;
 import io.cdap.cdap.etl.api.exception.ErrorDetailsProvider;
-import io.cdap.plugin.util.DBUtils;
 
 import java.sql.SQLException;
 import java.util.List;
@@ -77,7 +76,7 @@ private ProgramFailureException getProgramFailureException(SQLException e, Error
       errorMessageWithDetails = String.format("%s For more details, see %s", errorMessageWithDetails,
         externalDocumentationLink);
     }
-    return ErrorUtils.getProgramFailureException(sqlState == null ?
+    return ErrorUtils.getProgramFailureException(!Strings.isNullOrEmpty(sqlState) ?
         new ErrorCategory(ErrorCategory.ErrorCategoryEnum.PLUGIN) : getErrorCategoryFromSqlState(sqlState),
       errorMessage, errorMessageWithDetails, getErrorTypeFromErrorCode(errorCode, sqlState), true,
       ErrorCodeType.SQLSTATE, sqlState, externalDocumentationLink, e);

postgresql-plugin/src/main/java/io/cdap/plugin/postgres/PostgresErrorDetailsProvider.java

@@ -16,6 +16,7 @@
 
 package io.cdap.plugin.postgres;
 
+import com.google.common.base.Strings;
 import io.cdap.cdap.api.exception.ErrorCategory;
 import io.cdap.cdap.api.exception.ErrorType;
 import io.cdap.plugin.db.DBErrorDetailsProvider;
@@ -77,15 +78,17 @@ protected String getExternalDocumentationLink() {
 
   @Override
   protected ErrorType getErrorTypeFromErrorCode(int errorCode, String sqlState) {
-    if (sqlState.length() >= 2 && ERROR_CODE_TO_ERROR_TYPE.containsKey(sqlState.substring(0, 2))) {
-       return ERROR_CODE_TO_ERROR_TYPE.get(sqlState.substring(0, 2));
+    if (!Strings.isNullOrEmpty(sqlState) && sqlState.length() >= 2 &&
+      ERROR_CODE_TO_ERROR_TYPE.containsKey(sqlState.substring(0, 2))) {
+      return ERROR_CODE_TO_ERROR_TYPE.get(sqlState.substring(0, 2));
     }
     return ErrorType.UNKNOWN;
   }
 
   @Override
   protected ErrorCategory getErrorCategoryFromSqlState(String sqlState) {
-    if (sqlState.length() >= 2 && ERROR_CODE_TO_ERROR_CATEGORY.containsKey(sqlState.substring(0, 2))) {
+    if (!Strings.isNullOrEmpty(sqlState) && sqlState.length() >= 2 &&
+      ERROR_CODE_TO_ERROR_CATEGORY.containsKey(sqlState.substring(0, 2))) {
       return ERROR_CODE_TO_ERROR_CATEGORY.get(sqlState.substring(0, 2));
     }
     return new ErrorCategory(ErrorCategory.ErrorCategoryEnum.PLUGIN);