Skip to content

Commit 35537d7

Browse files
committed
PLUGIN-1823: Add default value for external documentation
1 parent a2bd3a9 commit 35537d7

File tree

3 files changed

+14
-4
lines changed

3 files changed

+14
-4
lines changed

database-commons/src/main/java/io/cdap/plugin/db/action/AbstractDBArgumentSetter.java

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -114,10 +114,10 @@ private void processArguments(Class<? extends Driver> driverClass,
114114
private void executeWithRetry(FailureCollector failureCollector, SettableArguments settableArguments,
115115
Properties connectionProperties) throws SQLException {
116116
try (Connection connection = RetryUtils.createConnectionWithRetry((RetryPolicy<Connection>) retryPolicy,
117-
config.getConnectionString(), connectionProperties, null)) {
117+
config.getConnectionString(), connectionProperties, getExternalDocumentationLink())) {
118118
ResultSet resultSet;
119119
try (Statement statement = RetryUtils.createStatementWithRetry((RetryPolicy<Statement>) retryPolicy, connection,
120-
null)) {
120+
getExternalDocumentationLink())) {
121121
resultSet = RetryUtils.executeQueryWithRetry((RetryPolicy<ResultSet>) retryPolicy, statement,
122122
config.getQuery(), null);
123123
}
@@ -153,4 +153,14 @@ private void setArguments(ResultSet resultSet, FailureCollector failureCollector
153153
arguments.set(column, resultSet.getString(column));
154154
}
155155
}
156+
157+
/**
158+
* Returns the external documentation link.
159+
* Override this method to provide a custom external documentation link.
160+
*
161+
* @return external documentation link
162+
*/
163+
protected String getExternalDocumentationLink() {
164+
return "https://en.wikipedia.org/wiki/SQLSTATE";
165+
}
156166
}

database-commons/src/main/java/io/cdap/plugin/db/sink/AbstractDBSink.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@ protected String getErrorDetailsProviderClassName() {
187187
* @return external documentation link
188188
*/
189189
protected String getExternalDocumentationLink() {
190-
return null;
190+
return "https://en.wikipedia.org/wiki/SQLSTATE";
191191
}
192192

193193
@Override

database-commons/src/main/java/io/cdap/plugin/db/source/AbstractDBSource.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -368,7 +368,7 @@ protected Class<? extends DBWritable> getDBRecordType() {
368368
* @return external documentation link
369369
*/
370370
protected String getExternalDocumentationLink() {
371-
return null;
371+
return "https://en.wikipedia.org/wiki/SQLSTATE";
372372
}
373373

374374
@Override

0 commit comments

Comments
 (0)