bugfixes

Author: akhalymon

docker-compose/db-plugins-env/saphana-password-server.sh

@@ -1,3 +1,4 @@
+#!/bin/bash
 # Copyright © 2019 Cask Data, Inc.
 #
 # Licensed under the Apache License, Version 2.0 (the "License"); you may not
@@ -11,7 +12,6 @@
 # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
 # License for the specific language governing permissions and limitations under
 # the License.
-#!/usr/bin/env bash
 
 
 # Tested with Ubuntu 18.04

saphana-plugin/src/main/java/io/cdap/plugin/saphana/SapHanaAction.java

@@ -21,7 +21,7 @@
 import io.cdap.cdap.api.annotation.Plugin;
 import io.cdap.cdap.etl.api.action.Action;
 import io.cdap.plugin.db.batch.action.AbstractDBAction;
-import io.cdap.plugin.db.batch.action.QueryConfig;
+import io.cdap.plugin.db.batch.config.DBSpecificQueryConfig;
 
 /**
  * Action that runs SAP HANA command.
@@ -31,7 +31,18 @@
 @Description("Action that runs a SAP HANA command")
 public class SapHanaAction extends AbstractDBAction {
 
-  public SapHanaAction(QueryConfig config) {
+  SapHanaQueryActionConfig sapHanaQueryActionConfig;
+
+  public SapHanaAction(SapHanaQueryActionConfig config) {
     super(config, false);
+    this.sapHanaQueryActionConfig = config;
+  }
+
+  public static class SapHanaQueryActionConfig extends DBSpecificQueryConfig {
+
+    @Override
+    public String getConnectionString() {
+      return String.format(SapHanaConstants.SAPHANA_CONNECTION_STRING_FORMAT, host, port);
+    }
   }
 }

saphana-plugin/src/main/java/io/cdap/plugin/saphana/SapHanaSink.java

@@ -41,10 +41,17 @@
 @Description("Writes records to a SAP HANA table. Each record will be written in a row in the table")
 public class SapHanaSink extends AbstractDBSink {
 
+  private final SapHanaSinkConfig sapHanaSinkConfig;
   private static final Character ESCAPE_CHAR = '"';
 
+  public SapHanaSink(DBSinkConfig dbSinkConfig, SapHanaSinkConfig sapHanaSinkConfig) {
+    super(dbSinkConfig);
+    this.sapHanaSinkConfig = sapHanaSinkConfig;
+  }
+
   public SapHanaSink(SapHanaSinkConfig sapHanaSinkConfig) {
     super(sapHanaSinkConfig);
+    this.sapHanaSinkConfig = sapHanaSinkConfig;
   }
 
   @Override