PLUGIN-1823: Create object only once.

sgarg-CS · sgarg-CS · commit 5ef4f1523af0 · 2025-06-25T22:36:18.000+05:30
diff --git a/cloudsql-mysql-plugin/src/main/java/io/cdap/plugin/cloudsql/mysql/CloudSQLMySQLConnector.java b/cloudsql-mysql-plugin/src/main/java/io/cdap/plugin/cloudsql/mysql/CloudSQLMySQLConnector.java
@@ -53,6 +53,7 @@ public class CloudSQLMySQLConnector extends AbstractDBSpecificConnector<MysqlDBR
   
   public static final String NAME = CloudSQLMySQLConstants.PLUGIN_NAME;
   private final CloudSQLMySQLConnectorConfig config;
+  private CloudSQLMySQLErrorDetailsProvider cloudSQLMySQLErrorDetailsProvider;
 
   public CloudSQLMySQLConnector(CloudSQLMySQLConnectorConfig config) {
     super(config);
@@ -111,6 +112,9 @@ protected void setConnectorSpec(ConnectorSpecRequest request, DBConnectorPath pa
 
   @Override
   protected CloudSQLMySQLErrorDetailsProvider getErrorDetailsProvider() {
-    return new CloudSQLMySQLErrorDetailsProvider();
+    if (cloudSQLMySQLErrorDetailsProvider == null) {
+      cloudSQLMySQLErrorDetailsProvider = new CloudSQLMySQLErrorDetailsProvider();
+    }
+    return cloudSQLMySQLErrorDetailsProvider;
   }
 }
diff --git a/cloudsql-mysql-plugin/src/main/java/io/cdap/plugin/cloudsql/mysql/CloudSQLMySQLSink.java b/cloudsql-mysql-plugin/src/main/java/io/cdap/plugin/cloudsql/mysql/CloudSQLMySQLSink.java
@@ -59,6 +59,7 @@ public class CloudSQLMySQLSink extends AbstractDBSink<CloudSQLMySQLSink.CloudSQL
 
   private final CloudSQLMySQLSinkConfig cloudsqlMysqlSinkConfig;
   private static final Character ESCAPE_CHAR = '`';
+  private CloudSQLMySQLErrorDetailsProvider cloudSQLMySQLErrorDetailsProvider;
 
   public CloudSQLMySQLSink(CloudSQLMySQLSinkConfig cloudsqlMysqlSinkConfig) {
     super(cloudsqlMysqlSinkConfig);
@@ -111,7 +112,10 @@ protected String getErrorDetailsProviderClassName() {
 
   @Override
   protected CloudSQLMySQLErrorDetailsProvider getErrorDetailsProvider() {
-    return new CloudSQLMySQLErrorDetailsProvider();
+    if (cloudSQLMySQLErrorDetailsProvider == null) {
+      cloudSQLMySQLErrorDetailsProvider = new CloudSQLMySQLErrorDetailsProvider();
+    }
+    return cloudSQLMySQLErrorDetailsProvider;
   }
 
   @Override
diff --git a/cloudsql-mysql-plugin/src/main/java/io/cdap/plugin/cloudsql/mysql/CloudSQLMySQLSource.java b/cloudsql-mysql-plugin/src/main/java/io/cdap/plugin/cloudsql/mysql/CloudSQLMySQLSource.java
@@ -55,6 +55,7 @@
 public class CloudSQLMySQLSource extends AbstractDBSource<CloudSQLMySQLSource.CloudSQLMySQLSourceConfig> {
 
   private final CloudSQLMySQLSourceConfig cloudsqlMysqlSourceConfig;
+  private CloudSQLMySQLErrorDetailsProvider cloudSQLMySQLErrorDetailsProvider;
 
   public CloudSQLMySQLSource(CloudSQLMySQLSourceConfig cloudsqlMysqlSourceConfig) {
     super(cloudsqlMysqlSourceConfig);
@@ -140,7 +141,10 @@ protected String getErrorDetailsProviderClassName() {
 
   @Override
   protected CloudSQLMySQLErrorDetailsProvider getErrorDetailsProvider() {
-    return new CloudSQLMySQLErrorDetailsProvider();
+    if (cloudSQLMySQLErrorDetailsProvider == null) {
+      cloudSQLMySQLErrorDetailsProvider = new CloudSQLMySQLErrorDetailsProvider();
+    }
+    return cloudSQLMySQLErrorDetailsProvider;
   }
 
   /** CloudSQL MySQL source config. */
diff --git a/cloudsql-postgresql-plugin/src/main/java/io/cdap/plugin/cloudsql/postgres/CloudSQLPostgreSQLConnector.java b/cloudsql-postgresql-plugin/src/main/java/io/cdap/plugin/cloudsql/postgres/CloudSQLPostgreSQLConnector.java
@@ -52,6 +52,7 @@
 public class CloudSQLPostgreSQLConnector extends AbstractDBSpecificConnector<PostgresDBRecord> {
   public static final String NAME = CloudSQLPostgreSQLConstants.PLUGIN_NAME;
   private final CloudSQLPostgreSQLConnectorConfig config;
+  private CloudSQLPostgreSQLErrorDetailsProvider cloudSQLPostgreSQLErrorDetailsProvider;
 
   public CloudSQLPostgreSQLConnector(CloudSQLPostgreSQLConnectorConfig config) {
     super(config);
@@ -121,6 +122,9 @@ protected void setConnectorSpec(ConnectorSpecRequest request, DBConnectorPath pa
 
   @Override
   protected CloudSQLPostgreSQLErrorDetailsProvider getErrorDetailsProvider() {
-    return new CloudSQLPostgreSQLErrorDetailsProvider();
+    if (cloudSQLPostgreSQLErrorDetailsProvider == null) {
+      cloudSQLPostgreSQLErrorDetailsProvider = new CloudSQLPostgreSQLErrorDetailsProvider();
+    }
+    return cloudSQLPostgreSQLErrorDetailsProvider;
   }
 }
diff --git a/cloudsql-postgresql-plugin/src/main/java/io/cdap/plugin/cloudsql/postgres/CloudSQLPostgreSQLSink.java b/cloudsql-postgresql-plugin/src/main/java/io/cdap/plugin/cloudsql/postgres/CloudSQLPostgreSQLSink.java
@@ -66,6 +66,7 @@ public class CloudSQLPostgreSQLSink extends AbstractDBSink<CloudSQLPostgreSQLSin
   private static final Character ESCAPE_CHAR = '"';
 
   private final CloudSQLPostgreSQLSinkConfig cloudsqlPostgresqlSinkConfig;
+  private CloudSQLPostgreSQLErrorDetailsProvider cloudSQLPostgreSQLErrorDetailsProvider;
 
   public CloudSQLPostgreSQLSink(CloudSQLPostgreSQLSinkConfig cloudsqlPostgresqlSinkConfig) {
     super(cloudsqlPostgresqlSinkConfig);
@@ -155,7 +156,10 @@ protected String getErrorDetailsProviderClassName() {
 
   @Override
   protected CloudSQLPostgreSQLErrorDetailsProvider getErrorDetailsProvider() {
-    return new CloudSQLPostgreSQLErrorDetailsProvider();
+    if (cloudSQLPostgreSQLErrorDetailsProvider == null) {
+      cloudSQLPostgreSQLErrorDetailsProvider = new CloudSQLPostgreSQLErrorDetailsProvider();
+    }
+    return cloudSQLPostgreSQLErrorDetailsProvider;
   }
 
   @Override
diff --git a/cloudsql-postgresql-plugin/src/main/java/io/cdap/plugin/cloudsql/postgres/CloudSQLPostgreSQLSource.java b/cloudsql-postgresql-plugin/src/main/java/io/cdap/plugin/cloudsql/postgres/CloudSQLPostgreSQLSource.java
@@ -55,6 +55,7 @@ public class CloudSQLPostgreSQLSource
   extends AbstractDBSource<CloudSQLPostgreSQLSource.CloudSQLPostgreSQLSourceConfig> {
 
   private final CloudSQLPostgreSQLSourceConfig cloudsqlPostgresqlSourceConfig;
+  private CloudSQLPostgreSQLErrorDetailsProvider cloudSQLPostgreSQLErrorDetailsProvider;
 
   public CloudSQLPostgreSQLSource(CloudSQLPostgreSQLSourceConfig cloudsqlPostgresqlSourceConfig) {
     super(cloudsqlPostgresqlSourceConfig);
@@ -99,7 +100,10 @@ protected String getErrorDetailsProviderClassName() {
 
   @Override
   protected CloudSQLPostgreSQLErrorDetailsProvider getErrorDetailsProvider() {
-    return new CloudSQLPostgreSQLErrorDetailsProvider();
+    if (cloudSQLPostgreSQLErrorDetailsProvider == null) {
+      cloudSQLPostgreSQLErrorDetailsProvider = new CloudSQLPostgreSQLErrorDetailsProvider();
+    }
+    return cloudSQLPostgreSQLErrorDetailsProvider;
   }
 
   @Override
diff --git a/database-commons/src/main/java/io/cdap/plugin/db/action/AbstractDBArgumentSetter.java b/database-commons/src/main/java/io/cdap/plugin/db/action/AbstractDBArgumentSetter.java
@@ -45,6 +45,7 @@ public class AbstractDBArgumentSetter extends Action {
   private static final String JDBC_PLUGIN_ID = "driver";
   private final ArgumentSetterConfig config;
   private final RetryPolicy<?> retryPolicy;
+  private DBErrorDetailsProvider dbErrorDetailsProvider;
 
   public AbstractDBArgumentSetter(ArgumentSetterConfig config) {
     this.config = config;
@@ -172,6 +173,9 @@ protected String getExternalDocumentationLink() {
    * @return DBErrorDetailsProvider instance
    */
   protected DBErrorDetailsProvider getErrorDetailsProvider() {
-    return new DBErrorDetailsProvider();
+    if (dbErrorDetailsProvider == null) {
+      dbErrorDetailsProvider =  new DBErrorDetailsProvider();
+    }
+    return dbErrorDetailsProvider;
   }
 }
diff --git a/database-commons/src/main/java/io/cdap/plugin/db/action/DBRun.java b/database-commons/src/main/java/io/cdap/plugin/db/action/DBRun.java
@@ -38,6 +38,7 @@ public class DBRun {
   private final Class<? extends Driver> driverClass;
   private boolean enableAutoCommit;
   private final RetryPolicy<?> retryPolicy;
+  private DBErrorDetailsProvider dbErrorDetailsProvider;
 
   public DBRun(QueryConfig config, Class<? extends Driver> driverClass, Boolean enableAutocommit) {
     this.config = config;
@@ -55,7 +56,10 @@ public DBRun(QueryConfig config, Class<? extends Driver> driverClass, Boolean en
    * @return DBErrorDetailsProvider instance
    */
   protected DBErrorDetailsProvider getErrorDetailsProvider() {
-    return new DBErrorDetailsProvider();
+    if (dbErrorDetailsProvider == null) {
+      dbErrorDetailsProvider =  new DBErrorDetailsProvider();
+    }
+    return dbErrorDetailsProvider;
   }
 
   /**
diff --git a/database-commons/src/main/java/io/cdap/plugin/db/sink/AbstractDBSink.java b/database-commons/src/main/java/io/cdap/plugin/db/sink/AbstractDBSink.java
@@ -98,6 +98,7 @@ public abstract class AbstractDBSink<T extends PluginConfig & DatabaseSinkConfig
   private ConnectionConfigAccessor configAccessor;
   private Configuration configuration;
   private final RetryPolicy<?> retryPolicy;
+  private DBErrorDetailsProvider dbErrorDetailsProvider;
 
   public AbstractDBSink(T dbSinkConfig) {
     super(new ReferencePluginConfig(dbSinkConfig.getReferenceName()));
@@ -188,7 +189,10 @@ protected String getErrorDetailsProviderClassName() {
    * @return DBErrorDetailsProvider instance
    */
   protected DBErrorDetailsProvider getErrorDetailsProvider() {
-    return new DBErrorDetailsProvider();
+    if (dbErrorDetailsProvider == null) {
+      dbErrorDetailsProvider =  new DBErrorDetailsProvider();
+    }
+    return dbErrorDetailsProvider;
   }
 
   /**
diff --git a/database-commons/src/main/java/io/cdap/plugin/db/source/AbstractDBSource.java b/database-commons/src/main/java/io/cdap/plugin/db/source/AbstractDBSource.java
@@ -88,6 +88,7 @@ public abstract class AbstractDBSource<T extends PluginConfig & DatabaseSourceCo
                                                                   Pattern.CASE_INSENSITIVE);
   private final RetryPolicy<?> retryPolicy;
 
+  private DBErrorDetailsProvider dbErrorDetailsProvider;
   protected final T sourceConfig;
   protected Class<? extends Driver> driverClass;
 
@@ -235,7 +236,10 @@ protected String getErrorDetailsProviderClassName() {
    * @return DBErrorDetailsProvider instance
    */
   protected DBErrorDetailsProvider getErrorDetailsProvider() {
-    return new DBErrorDetailsProvider();
+    if (dbErrorDetailsProvider == null) {
+      dbErrorDetailsProvider =  new DBErrorDetailsProvider();
+    }
+    return dbErrorDetailsProvider;
   }
 
   private DriverCleanup loadPluginClassAndGetDriver(Class<? extends Driver> driverClass)
diff --git a/mariadb-plugin/src/main/java/io/cdap/plugin/mariadb/MariadbSink.java b/mariadb-plugin/src/main/java/io/cdap/plugin/mariadb/MariadbSink.java
@@ -41,6 +41,7 @@
 public class MariadbSink extends AbstractDBSink<MariadbSink.MariadbSinkConfig> {
 
   private final MariadbSinkConfig mariadbSinkConfig;
+  private MariadbErrorDetailsProvider mariadbErrorDetailsProvider;
 
   /**
    * This is the constructor for MariadbSink.
@@ -69,7 +70,10 @@ protected String getErrorDetailsProviderClassName() {
 
   @Override
   protected MariadbErrorDetailsProvider getErrorDetailsProvider() {
-    return new MariadbErrorDetailsProvider();
+    if (mariadbErrorDetailsProvider == null) {
+      mariadbErrorDetailsProvider = new MariadbErrorDetailsProvider();
+    }
+    return mariadbErrorDetailsProvider;
   }
 
   @Override
diff --git a/mariadb-plugin/src/main/java/io/cdap/plugin/mariadb/MariadbSource.java b/mariadb-plugin/src/main/java/io/cdap/plugin/mariadb/MariadbSource.java
@@ -46,6 +46,7 @@
 public class MariadbSource extends AbstractDBSource<MariadbSource.MariadbSourceConfig> {
 
   private final MariadbSourceConfig mariadbSourceConfig;
+  private MariadbErrorDetailsProvider mariadbErrorDetailsProvider;
 
   /**
    * This is the constructor for MariadbSource.
@@ -90,7 +91,10 @@ protected String getErrorDetailsProviderClassName() {
 
   @Override
   protected MariadbErrorDetailsProvider getErrorDetailsProvider() {
-    return new MariadbErrorDetailsProvider();
+    if (mariadbErrorDetailsProvider == null) {
+      mariadbErrorDetailsProvider = new MariadbErrorDetailsProvider();
+    }
+    return mariadbErrorDetailsProvider;
   }
 
   @Override
diff --git a/mssql-plugin/src/main/java/io/cdap/plugin/mssql/SqlServerConnector.java b/mssql-plugin/src/main/java/io/cdap/plugin/mssql/SqlServerConnector.java
@@ -53,6 +53,7 @@
 public class SqlServerConnector extends AbstractDBSpecificConnector<SqlServerSourceDBRecord> {
   public static final String NAME = "SQL Server";
   private final SqlServerConnectorConfig config;
+  private SqlServerErrorDetailsProvider sqlServerErrorDetailsProvider;
 
   public SqlServerConnector(SqlServerConnectorConfig config) {
     super(config);
@@ -151,7 +152,10 @@ protected String getStratifiedQuery(String tableName, int limit, String strata,
 
   @Override
   protected SqlServerErrorDetailsProvider getErrorDetailsProvider() {
-    return new SqlServerErrorDetailsProvider();
+    if (sqlServerErrorDetailsProvider == null) {
+      sqlServerErrorDetailsProvider = new SqlServerErrorDetailsProvider();
+    }
+    return sqlServerErrorDetailsProvider;
   }
 
 }
diff --git a/mssql-plugin/src/main/java/io/cdap/plugin/mssql/SqlServerSink.java b/mssql-plugin/src/main/java/io/cdap/plugin/mssql/SqlServerSink.java
@@ -57,6 +57,7 @@ public class SqlServerSink extends AbstractDBSink<SqlServerSink.SqlServerSinkCon
   private static final Logger LOG = LoggerFactory.getLogger(SqlServerSink.class);
 
   private final SqlServerSinkConfig sqlServerSinkConfig;
+  private SqlServerErrorDetailsProvider sqlServerErrorDetailsProvider;
 
   public SqlServerSink(SqlServerSinkConfig sqlServerSinkConfig) {
     super(sqlServerSinkConfig);
@@ -95,7 +96,10 @@ protected String getErrorDetailsProviderClassName() {
 
   @Override
   protected SqlServerErrorDetailsProvider getErrorDetailsProvider() {
-    return new SqlServerErrorDetailsProvider();
+    if (sqlServerErrorDetailsProvider == null) {
+      sqlServerErrorDetailsProvider = new SqlServerErrorDetailsProvider();
+    }
+    return sqlServerErrorDetailsProvider;
   }
 
   @Override
diff --git a/mssql-plugin/src/main/java/io/cdap/plugin/mssql/SqlServerSource.java b/mssql-plugin/src/main/java/io/cdap/plugin/mssql/SqlServerSource.java
@@ -54,6 +54,7 @@
 public class SqlServerSource extends AbstractDBSource<SqlServerSource.SqlServerSourceConfig> {
 
   private final SqlServerSourceConfig sqlServerSourceConfig;
+  private SqlServerErrorDetailsProvider sqlServerErrorDetailsProvider;
 
   public SqlServerSource(SqlServerSourceConfig sqlServerSourceConfig) {
     super(sqlServerSourceConfig);
@@ -82,7 +83,10 @@ protected String getErrorDetailsProviderClassName() {
 
   @Override
   protected SqlServerErrorDetailsProvider getErrorDetailsProvider() {
-    return new SqlServerErrorDetailsProvider();
+    if (sqlServerErrorDetailsProvider == null) {
+      sqlServerErrorDetailsProvider = new SqlServerErrorDetailsProvider();
+    }
+    return sqlServerErrorDetailsProvider;
   }
 
   @Override
diff --git a/mysql-plugin/src/main/java/io/cdap/plugin/mysql/MysqlConnector.java b/mysql-plugin/src/main/java/io/cdap/plugin/mysql/MysqlConnector.java
@@ -50,6 +50,7 @@
 public class MysqlConnector extends AbstractDBSpecificConnector<MysqlDBRecord> {
   public static final String NAME = "MySQL";
   private final MysqlConnectorConfig config;
+  private MysqlErrorDetailsProvider mysqlErrorDetailsProvider;
 
   public MysqlConnector(MysqlConnectorConfig config) {
     super(config);
@@ -132,6 +133,9 @@ public StructuredRecord transform(LongWritable longWritable, MysqlDBRecord mysql
 
   @Override
   protected MysqlErrorDetailsProvider getErrorDetailsProvider() {
-    return new MysqlErrorDetailsProvider();
+    if (mysqlErrorDetailsProvider == null) {
+      mysqlErrorDetailsProvider = new MysqlErrorDetailsProvider();
+    }
+    return mysqlErrorDetailsProvider;
   }
 }
diff --git a/mysql-plugin/src/main/java/io/cdap/plugin/mysql/MysqlSink.java b/mysql-plugin/src/main/java/io/cdap/plugin/mysql/MysqlSink.java
@@ -60,6 +60,7 @@ public class MysqlSink extends AbstractDBSink<MysqlSink.MysqlSinkConfig> {
 
   private final MysqlSinkConfig mysqlSinkConfig;
   private static final Character ESCAPE_CHAR = '`';
+  private MysqlErrorDetailsProvider mysqlErrorDetailsProvider;
 
   public MysqlSink(MysqlSinkConfig mysqlSinkConfig) {
     super(mysqlSinkConfig);
@@ -116,7 +117,10 @@ protected String getErrorDetailsProviderClassName() {
 
   @Override
   protected MysqlErrorDetailsProvider getErrorDetailsProvider() {
-    return new MysqlErrorDetailsProvider();
+    if (mysqlErrorDetailsProvider == null) {
+      mysqlErrorDetailsProvider = new MysqlErrorDetailsProvider();
+    }
+    return mysqlErrorDetailsProvider;
   }
 
   @Override
diff --git a/mysql-plugin/src/main/java/io/cdap/plugin/mysql/MysqlSource.java b/mysql-plugin/src/main/java/io/cdap/plugin/mysql/MysqlSource.java
@@ -53,6 +53,7 @@
 public class MysqlSource extends AbstractDBSource<MysqlSource.MysqlSourceConfig> {
 
   private final MysqlSourceConfig mysqlSourceConfig;
+  private MysqlErrorDetailsProvider mysqlErrorDetailsProvider;
 
   public MysqlSource(MysqlSourceConfig mysqlSourceConfig) {
     super(mysqlSourceConfig);
@@ -96,7 +97,10 @@ protected String getErrorDetailsProviderClassName() {
 
   @Override
   protected MysqlErrorDetailsProvider getErrorDetailsProvider() {
-    return new MysqlErrorDetailsProvider();
+    if (mysqlErrorDetailsProvider == null) {
+      mysqlErrorDetailsProvider = new MysqlErrorDetailsProvider();
+    }
+    return mysqlErrorDetailsProvider;
   }
 
   /**
diff --git a/oracle-plugin/src/main/java/io/cdap/plugin/oracle/OracleConnector.java b/oracle-plugin/src/main/java/io/cdap/plugin/oracle/OracleConnector.java
@@ -55,6 +55,7 @@ public class OracleConnector extends AbstractDBSpecificConnector<OracleSourceDBR
   public static final String NAME = "Oracle";
 
   private final OracleConnectorConfig config;
+  private OracleErrorDetailsProvider oracleErrorDetailsProvider;
 
   public OracleConnector(OracleConnectorConfig config) {
     super(config);
@@ -191,6 +192,9 @@ protected String generateSessionID() {
 
   @Override
   protected OracleErrorDetailsProvider getErrorDetailsProvider() {
-    return new OracleErrorDetailsProvider();
+    if (oracleErrorDetailsProvider == null) {
+      oracleErrorDetailsProvider = new OracleErrorDetailsProvider();
+    }
+    return oracleErrorDetailsProvider;
   }
 }
diff --git a/oracle-plugin/src/main/java/io/cdap/plugin/oracle/OracleSink.java b/oracle-plugin/src/main/java/io/cdap/plugin/oracle/OracleSink.java
@@ -51,6 +51,7 @@
 public class OracleSink extends AbstractDBSink<OracleSink.OracleSinkConfig> {
 
   private final OracleSinkConfig oracleSinkConfig;
+  private OracleErrorDetailsProvider oracleErrorDetailsProvider;
 
   public OracleSink(OracleSinkConfig oracleSinkConfig) {
     super(oracleSinkConfig);
@@ -89,7 +90,10 @@ protected String getErrorDetailsProviderClassName() {
 
   @Override
   protected OracleErrorDetailsProvider getErrorDetailsProvider() {
-    return new OracleErrorDetailsProvider();
+    if (oracleErrorDetailsProvider == null) {
+      oracleErrorDetailsProvider = new OracleErrorDetailsProvider();
+    }
+    return oracleErrorDetailsProvider;
   }
 
   @Override
diff --git a/oracle-plugin/src/main/java/io/cdap/plugin/oracle/OracleSource.java b/oracle-plugin/src/main/java/io/cdap/plugin/oracle/OracleSource.java
diff --git a/postgresql-plugin/src/main/java/io/cdap/plugin/postgres/PostgresConnector.java b/postgresql-plugin/src/main/java/io/cdap/plugin/postgres/PostgresConnector.java
diff --git a/postgresql-plugin/src/main/java/io/cdap/plugin/postgres/PostgresSink.java b/postgresql-plugin/src/main/java/io/cdap/plugin/postgres/PostgresSink.java
diff --git a/postgresql-plugin/src/main/java/io/cdap/plugin/postgres/PostgresSource.java b/postgresql-plugin/src/main/java/io/cdap/plugin/postgres/PostgresSource.java
