Skip to content

Commit 6de940c

Browse files
committed
Return null for ErrorDetailsProvider by default
1 parent 0228f18 commit 6de940c

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

database-commons/src/main/java/io/cdap/plugin/db/sink/AbstractDBSink.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ public void validateOperations(FailureCollector collector, T dbSinkConfig, @Null
172172
* @return ErrorDetailsProvider class name
173173
*/
174174
protected String getErrorDetailsProviderClassName() {
175-
return DBErrorDetailsProvider.class.getName();
175+
return null;
176176
}
177177

178178
@Override
@@ -240,7 +240,9 @@ public void prepareRun(BatchSinkContext context) {
240240
context.getArguments().get(ETLDBOutputFormat.COMMIT_BATCH_SIZE));
241241
}
242242
// set error details provider
243-
context.setErrorDetailsProvider(new ErrorDetailsProviderSpec(getErrorDetailsProviderClassName()));
243+
if (!Strings.isNullOrEmpty(getErrorDetailsProviderClassName())) {
244+
context.setErrorDetailsProvider(new ErrorDetailsProviderSpec(getErrorDetailsProviderClassName()));
245+
}
244246
addOutputContext(context);
245247
}
246248
protected void addOutputContext(BatchSinkContext context) {

database-commons/src/main/java/io/cdap/plugin/db/source/AbstractDBSource.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,7 @@ protected SchemaReader getSchemaReader() {
239239
* @return ErrorDetailsProvider class name
240240
*/
241241
protected String getErrorDetailsProviderClassName() {
242-
return DBErrorDetailsProvider.class.getName();
242+
return null;
243243
}
244244

245245
private DriverCleanup loadPluginClassAndGetDriver(Class<? extends Driver> driverClass)
@@ -299,7 +299,9 @@ public void prepareRun(BatchSourceContext context) throws Exception {
299299
schema.getFields().stream().map(Schema.Field::getName).collect(Collectors.toList()));
300300
}
301301
// set error details provider
302-
context.setErrorDetailsProvider(new ErrorDetailsProviderSpec(getErrorDetailsProviderClassName()));
302+
if (!Strings.isNullOrEmpty(getErrorDetailsProviderClassName())) {
303+
context.setErrorDetailsProvider(new ErrorDetailsProviderSpec(getErrorDetailsProviderClassName()));
304+
}
303305
context.setInput(Input.of(sourceConfig.getReferenceName(), new SourceInputFormatProvider(
304306
DataDrivenETLDBInputFormat.class, connectionConfigAccessor.getConfiguration())));
305307
}

0 commit comments

Comments
 (0)