Skip to content

Commit a881002

Browse files
authored
Merge pull request #542 from cloudsufi/cherry-pick/6de940cb40bf9dc23e2579dc40609147270ecadf
[🍒][PLUGIN-1845] Return null for ErrorDetailsProvider by default
2 parents d9493d9 + 7fdc40e commit a881002

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

database-commons/src/main/java/io/cdap/plugin/db/sink/AbstractDBSink.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ public void validateOperations(FailureCollector collector, T dbSinkConfig, @Null
176176
* @return ErrorDetailsProvider class name
177177
*/
178178
protected String getErrorDetailsProviderClassName() {
179-
return DBErrorDetailsProvider.class.getName();
179+
return null;
180180
}
181181

182182
/**
@@ -254,7 +254,9 @@ public void prepareRun(BatchSinkContext context) {
254254
context.getArguments().get(ETLDBOutputFormat.COMMIT_BATCH_SIZE));
255255
}
256256
// set error details provider
257-
context.setErrorDetailsProvider(new ErrorDetailsProviderSpec(getErrorDetailsProviderClassName()));
257+
if (!Strings.isNullOrEmpty(getErrorDetailsProviderClassName())) {
258+
context.setErrorDetailsProvider(new ErrorDetailsProviderSpec(getErrorDetailsProviderClassName()));
259+
}
258260
addOutputContext(context);
259261
}
260262
protected void addOutputContext(BatchSinkContext context) {

database-commons/src/main/java/io/cdap/plugin/db/source/AbstractDBSource.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,7 @@ protected SchemaReader getSchemaReader() {
239239
* @return ErrorDetailsProvider class name
240240
*/
241241
protected String getErrorDetailsProviderClassName() {
242-
return DBErrorDetailsProvider.class.getName();
242+
return null;
243243
}
244244

245245
private DriverCleanup loadPluginClassAndGetDriver(Class<? extends Driver> driverClass)
@@ -299,7 +299,9 @@ public void prepareRun(BatchSourceContext context) throws Exception {
299299
schema.getFields().stream().map(Schema.Field::getName).collect(Collectors.toList()));
300300
}
301301
// set error details provider
302-
context.setErrorDetailsProvider(new ErrorDetailsProviderSpec(getErrorDetailsProviderClassName()));
302+
if (!Strings.isNullOrEmpty(getErrorDetailsProviderClassName())) {
303+
context.setErrorDetailsProvider(new ErrorDetailsProviderSpec(getErrorDetailsProviderClassName()));
304+
}
303305
context.setInput(Input.of(sourceConfig.getReferenceName(), new SourceInputFormatProvider(
304306
DataDrivenETLDBInputFormat.class, connectionConfigAccessor.getConfiguration())));
305307
}

0 commit comments

Comments
 (0)