Merge pull request #276 from jster1357/develop

doc fixes for PLUGIN-1268, PLUGIN-1267

Author: itsankit-google

oracle-plugin/docs/Oracle-action.md

@@ -40,7 +40,7 @@ will be passed to the JDBC driver as connection arguments for JDBC drivers that
 
 Example
 -------
-Suppose you want to execute a query against Oracle database named "XE" that is running on "localhost" 
+Suppose you want to execute a query against Oracle database named (service name) "XE" that is running on "localhost" 
 port 1251 (Ensure that the driver for Oracle is installed. You can also provide driver name for some specific driver, 
 otherwise "oracle" will be used), then configure the plugin with:
 
@@ -49,7 +49,8 @@ Driver Name: "oracle"
 Database Command: "UPDATE table_name SET price = 20 WHERE ID = 6"
 Host: "localhost"
 Port: 1251
-Database: "XE"
+Connection Type: "Service Name"
+SID/Service Name/TNS Connect Descriptor: "XE"
 Username: "system"
 Password: "oracle"
 Default Batch Value: 10

oracle-plugin/docs/Oracle-batchsink.md

@@ -35,7 +35,7 @@ You also can use the macro function ${conn(connection-name)}.
 - TRANSACTION_SERIALIZABLE (default): No dirty reads. Non-repeatable and phantom reads are prevented.
 - Note: If the user role selected is SYSDBA or SYSOPER, the plugin will default to TRANSACTION_READ_COMMITTED to prevent ORA-08178 errors
 
-**Connection Type** Whether to use an SID or Service Name when connecting to the database.
+**Connection Type** Whether to use an SID, Service Name, or TNS Connect Descriptor when connecting to the database.
 
 **SID/Service Name/TNS Connect Descriptor:** Oracle connection point (Database name, Service name, or a TNS Connect Descriptor). When using TNS, place
 the full TNS Connect Descriptor in the text field. For example:
@@ -44,6 +44,8 @@ the full TNS Connect Descriptor in the text field. For example:
 
 **Table Name:** Name of the table to export to.
 
+**Schema:** Name of the database schema to write to. If left blank it will default to the database login user
+
 **Username:** User identity for connecting to the specified database.
 
 **Password:** Password to use to connect to the specified database.
@@ -91,17 +93,19 @@ Data Types Mapping
 
 Example
 -------
-Suppose you want to write output records to "users" table of Oracle database named "XE" that is running on "localhost", 
+Suppose you want to write output records to "users" table of Oracle database named (service name) "XE" that is running on "localhost", 
 port 1251, as "system" user with "oracle" password (Ensure that the driver for Oracle is installed. You can also provide 
-driver name for some specific driver, otherwise "oracle" will be used), then configure the plugin with: 
+driver name for some specific driver, otherwise "oracle" will be used). 
 
 ```
 Reference Name: "snk1"
 Driver Name: "oracle"
 Host: "localhost"
 Port: 1251
-Database: "XE"
+Connection Type: "Service Name"
+SID/Service Name/TNS Connect Descriptor: "XE"
 Table Name: "users"
+Schema Name: "myschema"
 Username: "system"
 Password: "oracle"
 ```

oracle-plugin/docs/Oracle-batchsource.md

@@ -116,7 +116,8 @@ Reference Name: "src1"
 Driver Name: "oracle"
 Host: "localhost"
 Port: 1251
-Database: "XE"
+Connection Type: "Service Name"
+SID/Service Name/TNS Connect Descriptor: "XE"
 Import Query: "select id, name, email, phone from users;"
 Number of Splits to Generate: 1
 Username: "system"

oracle-plugin/docs/Oracle-postaction.md

@@ -54,7 +54,7 @@ set to false. For drivers like those, you will need to set this to 'true'.
 
 Example
 -------
-Suppose you want to delete all records from Oracle table "userEvents" of database "XE" running on localhost, port 3306,
+Suppose you want to delete all records from Oracle table "userEvents" of database (service name) "XE" running on localhost, port 3306,
 without authentication using driver "oracle" if the pipeline completes successfully (Ensure that the driver for Oracle is 
 installed. You can also driver name for some specific driver, otherwise "oracle" will be used ), 
 then configure the plugin with:
@@ -65,7 +65,8 @@ Driver Name: "oracle"
 Query: "delete * from userEvents"
 Host: "localhost"
 Port: 1251
-Database: "XE"
+Connection Type: "Service Name"
+SID/Service Name/TNS Connect Descriptor: "XE"
 Username: "system"
 Password: "oracle"
 Default Batch Value: 10