Merge branch 'patch/errorCodeTypeExtention' into fem/postgresql

Author: psainics

database-commons/src/main/java/io/cdap/plugin/db/DBErrorDetailsProvider.java

@@ -19,11 +19,13 @@
 import com.google.common.base.Strings;
 import com.google.common.base.Throwables;
 import io.cdap.cdap.api.exception.ErrorCategory;
+import io.cdap.cdap.api.exception.ErrorCodeType;
 import io.cdap.cdap.api.exception.ErrorType;
 import io.cdap.cdap.api.exception.ErrorUtils;
 import io.cdap.cdap.api.exception.ProgramFailureException;
 import io.cdap.cdap.etl.api.exception.ErrorContext;
 import io.cdap.cdap.etl.api.exception.ErrorDetailsProvider;
+import io.cdap.plugin.util.DBUtils;
 
 import java.sql.SQLException;
 import java.util.List;
@@ -75,9 +77,9 @@ private ProgramFailureException getProgramFailureException(SQLException e, Error
       errorMessageWithDetails = String.format("%s For more details, see %s", errorMessageWithDetails,
         externalDocumentationLink);
     }
-
     return ErrorUtils.getProgramFailureException(getErrorCategoryFromSqlState(sqlState), errorMessage,
-      errorMessageWithDetails, getErrorTypeFromErrorCode(errorCode, sqlState), false, e);
+      errorMessageWithDetails, getErrorTypeFromErrorCode(errorCode, sqlState), false, ErrorCodeType.SQLSTATE,
+      sqlState, externalDocumentationLink, e);
   }
 
   /**

database-commons/src/main/java/io/cdap/plugin/db/DBRecord.java

@@ -17,7 +17,6 @@
 package io.cdap.plugin.db;
 
 import com.google.common.base.Preconditions;
-import com.google.common.base.Strings;
 import io.cdap.cdap.api.common.Bytes;
 import io.cdap.cdap.api.data.format.StructuredRecord;
 import io.cdap.cdap.api.data.schema.Schema;

database-commons/src/main/java/io/cdap/plugin/util/DBUtils.java

@@ -60,6 +60,7 @@ public final class DBUtils {
   private static final Logger LOG = LoggerFactory.getLogger(DBUtils.class);
 
   public static final Calendar PURE_GREGORIAN_CALENDAR = createPureGregorianCalender();
+  public static final String MYSQL_SUPPORTED_DOC_URL = "https://dev.mysql.com/doc/mysql-errors/9.0/en/";
 
   // Java by default uses October 15, 1582 as a Gregorian cut over date.
   // Any timestamp created with time less than this cut over date is treated as Julian date.

mysql-plugin/src/main/java/io/cdap/plugin/mysql/MysqlErrorDetailsProvider.java

@@ -18,6 +18,7 @@
 
 import io.cdap.cdap.api.exception.ErrorType;
 import io.cdap.plugin.db.DBErrorDetailsProvider;
+import io.cdap.plugin.util.DBUtils;
 
 /**
  * A custom ErrorDetailsProvider for MySQL plugins.
@@ -26,7 +27,7 @@ public class MysqlErrorDetailsProvider extends DBErrorDetailsProvider {
 
   @Override
   protected String getExternalDocumentationLink() {
-    return "https://dev.mysql.com/doc/mysql-errors/9.0/en/";
+    return DBUtils.MYSQL_SUPPORTED_DOC_URL;
   }
 
   @Override