Catch storage exception

Author: psainics

src/main/java/io/cdap/plugin/gcp/gcs/StorageClient.java

@@ -72,7 +72,14 @@ public Blob pickABlob(String path) {
       return null;
     }
     GCSPath gcsPath = GCSPath.from(path);
-    Page<Blob> blobPage = storage.list(gcsPath.getBucket(), Storage.BlobListOption.prefix(gcsPath.getName()));
+    Page<Blob> blobPage;
+    try {
+      blobPage = storage.list(gcsPath.getBucket(), Storage.BlobListOption.prefix(gcsPath.getName()));
+    } catch (Exception e) {
+      String errorReason = String.format("Unable to list objects in bucket %s.", gcsPath.getBucket());
+      throw GCPErrorDetailsProviderUtil.getHttpResponseExceptionDetailsFromChain(e, errorReason, ErrorType.UNKNOWN,
+        true, GCPUtils.GCS_SUPPORTED_DOC_URL);
+    }
     Iterator<Blob> iterator = blobPage.getValues().iterator();
     while (iterator.hasNext()) {
       Blob blob = iterator.next();
@@ -93,7 +100,13 @@ public void setMetaData(Blob blob, Map<String, String> metaData) {
     if (blob == null || metaData == null || metaData.isEmpty()) {
       return;
     }
-    storage.update(BlobInfo.newBuilder(blob.getBlobId()).setMetadata(metaData).build());
+    try {
+      storage.update(BlobInfo.newBuilder(blob.getBlobId()).setMetadata(metaData).build());
+    } catch (Exception e) {
+      String errorReason = String.format("Unable to update metadata for blob %s.", blob.getName());
+      throw GCPErrorDetailsProviderUtil.getHttpResponseExceptionDetailsFromChain(e, errorReason, ErrorType.UNKNOWN,
+        true, GCPUtils.GCS_SUPPORTED_DOC_URL);
+    }
   }
 
   /**
@@ -106,7 +119,14 @@ public void mapMetaDataForAllBlobs(String path, Consumer<Map<String, String>> fu
       return;
     }
     GCSPath gcsPath = GCSPath.from(path);
-    Page<Blob> blobPage = storage.list(gcsPath.getBucket(), Storage.BlobListOption.prefix(gcsPath.getName()));
+    Page<Blob> blobPage;
+    try {
+      blobPage = storage.list(gcsPath.getBucket(), Storage.BlobListOption.prefix(gcsPath.getName()));
+    } catch (Exception e) {
+      String errorReason = String.format("Unable to list objects in bucket %s.", gcsPath.getBucket());
+      throw GCPErrorDetailsProviderUtil.getHttpResponseExceptionDetailsFromChain(e, errorReason, ErrorType.UNKNOWN,
+        true, GCPUtils.GCS_SUPPORTED_DOC_URL);
+    }
     Iterator<Blob> blobIterator = blobPage.iterateAll().iterator();
     while (blobIterator.hasNext()) {
       Blob blob = blobIterator.next();
@@ -179,9 +199,16 @@ public void move(GCSPath sourcePath, GCSPath destPath, boolean recursive, boolea
    * Get all the matching wildcard paths given the regex input.
    */
   public List<GCSPath> getMatchedPaths(GCSPath sourcePath, boolean recursive, Pattern wildcardRegex) {
-    Page<Blob> blobPage = storage.list(sourcePath.getBucket(), Storage.BlobListOption.prefix(
+    Page<Blob> blobPage;
+    try {
+      blobPage = storage.list(sourcePath.getBucket(), Storage.BlobListOption.prefix(
         getWildcardPathPrefix(sourcePath, wildcardRegex)
-    ));
+      ));
+    } catch (Exception e) {
+      String errorReason = String.format("Unable to list objects in bucket %s.", sourcePath.getBucket());
+      throw GCPErrorDetailsProviderUtil.getHttpResponseExceptionDetailsFromChain(e, errorReason, ErrorType.UNKNOWN,
+        true, GCPUtils.GCS_SUPPORTED_DOC_URL);
+    }
     List<String> blobPageNames = new ArrayList<>();
     blobPage.getValues().forEach(blob -> blobPageNames.add(blob.getName()));
     return getFilterMatchedPaths(sourcePath, blobPageNames, recursive);
@@ -217,8 +244,7 @@ static List<GCSPath> getFilterMatchedPaths(GCSPath sourcePath, List<String> blob
    */
   private void pairTraverse(GCSPath sourcePath, GCSPath destPath, boolean recursive, boolean overwrite,
                             Consumer<BlobPair> consumer) {
-
-    Bucket sourceBucket = null;
+    Bucket sourceBucket;
     try {
       sourceBucket = storage.get(sourcePath.getBucket());
     } catch (Exception e) {
@@ -232,7 +258,7 @@ private void pairTraverse(GCSPath sourcePath, GCSPath destPath, boolean recursiv
       throw ErrorUtils.getProgramFailureException(new ErrorCategory(ErrorCategory.ErrorCategoryEnum.PLUGIN),
         errorReason, errorReason, ErrorType.USER, true, null);
     }
-    Bucket destBucket = null;
+    Bucket destBucket;
     try {
       destBucket = storage.get(destPath.getBucket());
     } catch (Exception e) {
@@ -250,24 +276,45 @@ private void pairTraverse(GCSPath sourcePath, GCSPath destPath, boolean recursiv
 
     boolean destinationBaseExists;
     String baseDestName = destPath.getName();
-    if (destPath.isBucket() || storage.get(BlobId.of(destPath.getBucket(), baseDestName)) != null) {
+    Blob storageBlob;
+     try {
+       storageBlob = storage.get(BlobId.of(destPath.getBucket(), baseDestName));
+     } catch (Exception e) {
+       String errorReason = String.format("Unable to access GCS object '%s'.", baseDestName);
+       throw GCPErrorDetailsProviderUtil.getHttpResponseExceptionDetailsFromChain(e, errorReason, ErrorType.UNKNOWN,
+         true, GCPUtils.GCS_SUPPORTED_DOC_URL);
+     }
+    if (destPath.isBucket() || storageBlob != null) {
       destinationBaseExists = true;
     } else {
       // if gs://bucket2/subdir doesn't exist, check if gs://bucket2/subdir/ exists
       // similarly, if gs://bucket2/subdir/ doesn't exist, check if gs://bucket2/subdir exists
       // this is because "cp dir0 subdir" and "cp dir0 subdir/" are equivalent if the 'subdir' directory exists
       String modifiedName = baseDestName.endsWith("/") ?
         baseDestName.substring(0, baseDestName.length() - 1) : baseDestName + "/";
-      destinationBaseExists = storage.get(BlobId.of(destPath.getBucket(), modifiedName)) != null;
+      try {
+        destinationBaseExists = storage.get(BlobId.of(destPath.getBucket(), modifiedName)) != null;
+      } catch (Exception e) {
+        String errorReason = String.format("Unable to access GCS object '%s'.", modifiedName);
+        throw GCPErrorDetailsProviderUtil.getHttpResponseExceptionDetailsFromChain(e, errorReason, ErrorType.UNKNOWN,
+          true, GCPUtils.GCS_SUPPORTED_DOC_URL);
+      }
     }
 
     List<BlobPair> copyList = new ArrayList<>();
     traverse(BlobId.of(sourcePath.getBucket(), sourcePath.getName()), recursive, sourceBlob -> {
       BlobId destBlobID = resolve(sourcePath.getName(), sourceBlob.getBlobId().getName(),
                                   destPath, destinationBaseExists);
       if (!overwrite) {
-        Blob destBlob = storage.get(destBlobID);
-        // we can't just use Blob's isDirectory() because the cloud console will create a 'directory' by creating
+        Blob destBlob;
+       try {
+         destBlob = storage.get(destBlobID);
+       } catch (Exception e) {
+         String errorReason = String.format("Unable to access GCS object '%s'.", destBlobID.getName());
+         throw GCPErrorDetailsProviderUtil.getHttpResponseExceptionDetailsFromChain(e, errorReason, ErrorType.UNKNOWN,
+           true, GCPUtils.GCS_SUPPORTED_DOC_URL);
+       }
+         // we can't just use Blob's isDirectory() because the cloud console will create a 'directory' by creating
         // a 0 size placeholder blob that ends with '/'. This placeholder blob's isDirectory() method returns false,
         // but we don't want the overwrite check to fail on it. So we explicitly ignore the check for these 0 size
         // placeholder blobs.
@@ -358,8 +405,15 @@ static String append(String base, String part) {
    * @param consumer the blob consumer
    */
   private void traverse(BlobId blobId, boolean recursive, Consumer<Blob> consumer) {
-    Page<Blob> blobList = storage.list(blobId.getBucket(), Storage.BlobListOption.currentDirectory(),
-                                       Storage.BlobListOption.prefix(blobId.getName()));
+    Page<Blob> blobList;
+    try {
+      blobList = storage.list(blobId.getBucket(), Storage.BlobListOption.currentDirectory(),
+        Storage.BlobListOption.prefix(blobId.getName()));
+    } catch (Exception e) {
+      String errorReason = String.format("");
+      throw GCPErrorDetailsProviderUtil.getHttpResponseExceptionDetailsFromChain(e, errorReason, ErrorType.UNKNOWN,
+        true, GCPUtils.GCS_SUPPORTED_DOC_URL);
+    }
     for (Blob blob : blobList.iterateAll()) {
       if (!blob.isDirectory()) {
         consumer.accept(blob);