Merge pull request #1388 from data-integrations/spanner_fixes

[🍒][PLUGIN-1761][PLUGIN-1748] Add information about no primary key table and improve error logging

Author: itsankit-google

docs/Spanner-batchsink.md

@@ -42,6 +42,10 @@ Each record is composed of columns (also called fields).
 Every table is defined by a schema that describes the column names, data types, and other information.
 If the table does not exist, it will get created.
 
+**Note**: A table with no primary key columns can have only one row.
+Only GoogleSQL-dialect databases can have tables without a primary key.
+Please click [here](https://cloud.google.com/spanner/docs/schema-and-data-model) for more details.
+
 **Primary Key**: If the table does not exist, a primary key must be provided in order to auto-create the table.
 The key can be a composite key of multiple fields in the schema. This is not required if the table already exists.
 

pom.xml

@@ -20,7 +20,7 @@
 
   <groupId>io.cdap.plugin</groupId>
   <artifactId>google-cloud</artifactId>
-  <version>0.22.7</version>
+  <version>0.22.8-SNAPSHOT</version>
   <name>Google Cloud Plugins</name>
   <packaging>jar</packaging>
   <description>Plugins for Google Big Query</description>

src/main/java/io/cdap/plugin/gcp/spanner/sink/SpannerSinkConfig.java

@@ -57,7 +57,10 @@ public class SpannerSinkConfig extends PluginConfig {
   private static final String NAME_CMEK_KEY = "cmekKey";
 
   @Name(NAME_TABLE)
-  @Description("Cloud Spanner table id. Uniquely identifies your table within the Cloud Spanner database")
+  @Description("Cloud Spanner table id. Uniquely identifies your table within the Cloud Spanner database."
+      + " Note: A table with no primary key columns can have only one row."
+      + " Only GoogleSQL-dialect databases can have tables without a primary key."
+      + " Please refer to https://cloud.google.com/spanner/docs/schema-and-data-model for more details.")
   @Macro
   private String table;
 

src/main/java/io/cdap/plugin/gcp/spanner/source/SpannerSource.java

@@ -129,9 +129,11 @@ public void configurePipeline(PipelineConfigurer pipelineConfigurer) {
     } catch (SpannerException e) {
       // this is because spanner exception error message is not very user friendly. It contains class names and new
       // lines in the error message.
-      collector.addFailure("Unable to connect to spanner instance.",
-                           "Verify spanner configurations such as instance, database, table, project, etc.")
-        .withStacktrace(e.getStackTrace());
+      collector.addFailure(String.format(
+                  "Unable to connect to spanner instance with error code: %s and error message: %s",
+                  e.getErrorCode().name(), e.getMessage()),
+              "Verify spanner configurations such as instance, database, table, project, etc.")
+          .withStacktrace(e.getStackTrace());
     }
   }