Skip to content

Commit 596aa57

Browse files
committed
Error Management catch known errors [GCSMove]
1 parent 60f3ba0 commit 596aa57

File tree

1 file changed

+10
-8
lines changed

1 file changed

+10
-8
lines changed

src/main/java/io/cdap/plugin/gcp/gcs/actions/GCSMove.java

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,6 @@
1717
package io.cdap.plugin.gcp.gcs.actions;
1818

1919
import com.google.cloud.kms.v1.CryptoKeyName;
20-
import com.google.cloud.storage.Bucket;
21-
import com.google.cloud.storage.Storage;
22-
import com.google.cloud.storage.StorageException;
23-
import com.google.common.base.Strings;
2420
import io.cdap.cdap.api.annotation.Description;
2521
import io.cdap.cdap.api.annotation.Macro;
2622
import io.cdap.cdap.api.annotation.Name;
@@ -30,13 +26,11 @@
3026
import io.cdap.cdap.etl.api.action.Action;
3127
import io.cdap.cdap.etl.api.action.ActionContext;
3228
import io.cdap.plugin.gcp.common.CmekUtils;
33-
import io.cdap.plugin.gcp.common.GCPUtils;
3429
import io.cdap.plugin.gcp.gcs.GCSPath;
3530
import io.cdap.plugin.gcp.gcs.StorageClient;
3631

3732
import java.io.IOException;
3833
import java.util.ArrayList;
39-
import java.util.Collections;
4034
import java.util.List;
4135
import javax.annotation.Nullable;
4236

@@ -68,8 +62,16 @@ public void run(ActionContext context) throws IOException {
6862
collector.getOrThrowException();
6963
return;
7064
}
71-
StorageClient storageClient = StorageClient.create(config.getProject(), config.getServiceAccount(),
72-
isServiceAccountFilePath, config.readTimeout);
65+
StorageClient storageClient = null;
66+
try {
67+
storageClient = StorageClient.create(config.getProject(), config.getServiceAccount(), isServiceAccountFilePath,
68+
config.readTimeout);
69+
} catch (IOException e) {
70+
String errorReason = "Failed to create storage client, unable to load service account credentials.";
71+
collector.addFailure(String.format("%s %s", errorReason, e.getMessage()), null)
72+
.withStacktrace(e.getStackTrace());
73+
collector.getOrThrowException();
74+
}
7375
GCSPath destPath = config.getDestPath();
7476
CryptoKeyName cmekKeyName = CmekUtils.getCmekKey(config.cmekKey, context.getArguments().asMap(), collector);
7577
collector.getOrThrowException();

0 commit comments

Comments
 (0)