Skip to content

Commit 1ef330c

Browse files
committed
PLUGIN-1928: Refactor code
1 parent 6394456 commit 1ef330c

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

src/main/java/io/cdap/plugin/servicenow/restapi/RestAPIClient.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ public abstract class RestAPIClient {
6060
/* Read Timeout in ms for waiting for data after the connection is established */
6161
private static final int DEFAULT_READ_TIMEOUT_MS = 3600;
6262

63-
private RequestConfig requestConfig = RequestConfig.custom()
63+
private static final RequestConfig requestConfig = RequestConfig.custom()
6464
.setConnectTimeout(DEFAULT_CONNECT_TIMEOUT_MS)
6565
.setSocketTimeout(DEFAULT_READ_TIMEOUT_MS)
6666
.build();

src/test/java/io/cdap/plugin/servicenow/restapi/RestAPIClientTest.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,6 @@ public void testExecuteGet_throwConnectTimeoutException_markAsRetryable() throws
114114
Mockito.when(httpClient.execute(Mockito.any()))
115115
.thenThrow(new ConnectTimeoutException("Connection timed out"));
116116

117-
118117
ServiceNowTableAPIRequestBuilder builder = new ServiceNowTableAPIRequestBuilder("url");
119118
RestAPIRequest request = builder.build();
120119

@@ -125,6 +124,6 @@ public void testExecuteGet_throwConnectTimeoutException_markAsRetryable() throws
125124
Assert.assertTrue(actualResponse.getException().isErrorRetryable());
126125
Throwable ex = actualResponse.getException().getCause();
127126
Assert.assertTrue("Expected ConnectTimeoutException or similar, got: " + ex,
128-
ex instanceof ConnectTimeoutException || ex.getMessage().toLowerCase().contains("Connection timed out"));
127+
ex instanceof ConnectTimeoutException || ex.getMessage().toLowerCase().contains("Connection timed out"));
129128
}
130129
}

0 commit comments

Comments
 (0)