Skip to content

Commit cf89907

Browse files
committed
PLUGIN-1936 : Remove commented code and unused imports
1 parent 5e99944 commit cf89907

File tree

2 files changed

+0
-21
lines changed

2 files changed

+0
-21
lines changed

src/main/java/io/cdap/plugin/servicenow/apiclient/ServiceNowTableAPIClientImpl.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
import com.google.common.base.Strings;
2626
import com.google.gson.Gson;
2727
import com.google.gson.JsonArray;
28-
import com.google.gson.JsonElement;
2928
import com.google.gson.JsonObject;
3029
import com.google.gson.reflect.TypeToken;
3130
import com.google.gson.stream.JsonReader;

src/main/java/io/cdap/plugin/servicenow/source/ServiceNowRecordReader.java

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@
3939
import java.lang.reflect.Type;
4040
import java.nio.charset.StandardCharsets;
4141
import java.util.ArrayList;
42-
import java.util.HashMap;
4342
import java.util.List;
4443
import java.util.Map;
4544

@@ -102,25 +101,6 @@ public boolean nextKeyValue() throws IOException {
102101
// At this point jsonReader is positioned inside the "result" array.
103102
JsonToken token = jsonReader.peek();
104103

105-
/*if (token == JsonToken.END_ARRAY) {
106-
// Current page exhausted. Close current page and try to open the next page.
107-
closeCurrentPage();
108-
109-
// Attempt to open next page; if none, we must return false (end of data)
110-
boolean openedNext;
111-
try {
112-
openedNext = openNextPage();
113-
LOG.info("Opened next page for table {} at offset {}: {}", tableName, split.getOffset(), openedNext);
114-
} catch (ServiceNowAPIException e) {
115-
throw new IOException("Exception in nextKeyValue " + tableName, e);
116-
}
117-
if (!openedNext) {
118-
// No more pages
119-
return false;
120-
}
121-
// continue loop to attempt to read from newly opened page
122-
}*/
123-
124104
if (token == JsonToken.BEGIN_OBJECT) {
125105
LOG.info("Reading record object for table {} at position {}", tableName, pos);
126106
// Read exactly one object from the stream into a Map<String,String>

0 commit comments

Comments
 (0)