Skip to content

Commit de9ecb0

Browse files
committed
PLUGIN-1927: Map fields ending with _stc to string type
1 parent 09ad478 commit de9ecb0

File tree

2 files changed

+15
-3
lines changed

2 files changed

+15
-3
lines changed

src/main/java/io/cdap/plugin/servicenow/apiclient/ServiceNowTableAPIClientImpl.java

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,8 @@
6565
import java.util.concurrent.TimeUnit;
6666
import javax.annotation.Nullable;
6767

68+
import static io.cdap.plugin.servicenow.util.ServiceNowConstants.STC;
69+
6870
/**
6971
* Implementation class for ServiceNow Table API.
7072
*/
@@ -393,9 +395,14 @@ private Schema prepareSchemaWithMetadataAPI(RestAPIResponse restAPIResponse, Lis
393395
}
394396

395397
for (MetadataAPISchemaField field : metadataAPISchemaResponse.getResult().getColumns().values()) {
396-
if (valueType.equals(SourceValueType.SHOW_DISPLAY_VALUE) &&
397-
!Objects.equals(field.getType(), field.getInternalType())) {
398-
columns.add(new ServiceNowColumn(field.getName(), field.getType()));
398+
if (valueType.equals(SourceValueType.SHOW_DISPLAY_VALUE)) {
399+
if (!Objects.equals(field.getType(), field.getInternalType())) {
400+
columns.add(new ServiceNowColumn(field.getName(), field.getType()));
401+
} else if (field.getName().endsWith(STC)) {
402+
columns.add(new ServiceNowColumn(field.getName(), Schema.Type.STRING.name()));
403+
} else {
404+
columns.add(new ServiceNowColumn(field.getName(), field.getInternalType()));
405+
}
399406
} else if (valueType.equals(SourceValueType.SHOW_ACTUAL_VALUE) &&
400407
GLIDE_TIME_DATATYPE.equalsIgnoreCase(field.getInternalType())) {
401408
columns.add(new ServiceNowColumn(field.getName(), GLIDE_DATE_TIME_DATATYPE));

src/main/java/io/cdap/plugin/servicenow/util/ServiceNowConstants.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -281,4 +281,9 @@ public interface ServiceNowConstants {
281281
* Default Precision supported by ServiceNow Rest API
282282
*/
283283
int DEFAULT_PRECISION = 20;
284+
285+
/**
286+
* ServiceNow Fields ending with '_stc'
287+
*/
288+
String STC = "_stc";
284289
}

0 commit comments

Comments
 (0)