Merge pull request #9 from data-platform-hq/refactor

feat: refactor conditions; support a records

Author: owlleg6

README.md

@@ -60,18 +60,18 @@ No modules.
 
 | Name | Type |
 |------|------|
+| [azurerm_private_dns_a_record.example](https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/private_dns_a_record) | resource |
 | [azurerm_private_dns_zone.this](https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/private_dns_zone) | resource |
 | [azurerm_private_dns_zone_virtual_network_link.this](https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/private_dns_zone_virtual_network_link) | resource |
 
 ## Inputs
 
 | Name | Description | Type | Default | Required |
 |------|-------------|------|---------|:--------:|
-| <a name="input_custom_dns_zone_vnet_link_name"></a> [custom\_dns\_zone\_vnet\_link\_name](#input\_custom\_dns\_zone\_vnet\_link\_name) | The name of the Private DNS Zone Virtual Network Link | `string` | `null` | no |
-| <a name="input_dns_zone_name"></a> [dns\_zone\_name](#input\_dns\_zone\_name) | Name of Private DNS Zone | `string` | `""` | no |
-| <a name="input_external_dns_zone_name"></a> [external\_dns\_zone\_name](#input\_external\_dns\_zone\_name) | Name of Imported Private DNS Zone. Provide value in case creation of new Private DNS Zone is disabled | `string` | `""` | no |
-| <a name="input_prefix"></a> [prefix](#input\_prefix) | Custom prefix to add to resource name | `string` | `""` | no |
-| <a name="input_resource_group"></a> [resource\_group](#input\_resource\_group) | Azure location | `string` | n/a | yes |
+| <a name="input_create_private_dns_zone"></a> [create\_private\_dns\_zone](#input\_create\_private\_dns\_zone) | Boolean flag that determines whether Private DNS Zones is created by this module | `bool` | `true` | no |
+| <a name="input_dns_zone_name"></a> [dns\_zone\_name](#input\_dns\_zone\_name) | The name of the Private DNS Zone that needs to be created or linked to the virtual network | `string` | n/a | yes |
+| <a name="input_private_dns_a_records"></a> [private\_dns\_a\_records](#input\_private\_dns\_a\_records) | List of objects with parameters to create A Record in Private DNS Zone | <pre>list(object({<br>    name    = string<br>    ttl     = optional(number, 300)<br>    records = list(string)<br>  }))</pre> | `[]` | no |
+| <a name="input_resource_group"></a> [resource\_group](#input\_resource\_group) | Resource group where Private DNS zone would be created or it is already exists | `string` | n/a | yes |
 | <a name="input_tags"></a> [tags](#input\_tags) | Resource tags | `map(string)` | `{}` | no |
 | <a name="input_vnet_map"></a> [vnet\_map](#input\_vnet\_map) | Map of Virtual Network Name to Id, used to create VNet Link to Private DNS | `map(string)` | `{}` | no |
 
@@ -80,9 +80,9 @@ No modules.
 | Name | Description |
 |------|-------------|
 | <a name="output_id"></a> [id](#output\_id) | Private DNS Zone Id |
-| <a name="output_link_id"></a> [link\_id](#output\_link\_id) | List of Virtual Network Link Ids |
 | <a name="output_name"></a> [name](#output\_name) | Private DNS Zone Name |
 | <a name="output_resource_group"></a> [resource\_group](#output\_resource\_group) | Private DNS Zone Resource Group |
+| <a name="output_vnet_link_name_to_id_map"></a> [vnet\_link\_name\_to\_id\_map](#output\_vnet\_link\_name\_to\_id\_map) | Map of Virtual Network Link names to it's ids |
 <!-- END_TF_DOCS -->
 
 ## License

main.tf

@@ -1,29 +1,30 @@
-locals {
-  prefix                     = length(var.prefix) == 0 ? "" : var.prefix
-  private_dns_zone_vnet_link = var.custom_dns_zone_vnet_link_name == null ? "link-${local.prefix}" : "${local.prefix}-${var.custom_dns_zone_vnet_link_name}"
-}
-
 resource "azurerm_private_dns_zone" "this" {
-  count = length(var.dns_zone_name) == 0 ? 0 : 1
+  count = var.create_private_dns_zone ? 1 : 0
 
   name                = var.dns_zone_name
   resource_group_name = var.resource_group
   tags                = var.tags
 }
 
+resource "azurerm_private_dns_a_record" "example" {
+  for_each = {
+    for object in var.private_dns_a_records :
+    object.name => object
+  }
+
+  name                = each.value.name
+  zone_name           = try(azurerm_private_dns_zone.this[0].name, var.dns_zone_name)
+  resource_group_name = try(azurerm_private_dns_zone.this[0].resource_group_name, var.resource_group)
+  ttl                 = each.value.ttl
+  records             = each.value.records
+}
+
 resource "azurerm_private_dns_zone_virtual_network_link" "this" {
   for_each = var.vnet_map
 
-  name                  = "${local.private_dns_zone_vnet_link}-${each.key}"
-  private_dns_zone_name = length(var.dns_zone_name) == 0 ? var.external_dns_zone_name : azurerm_private_dns_zone.this[0].name
-  resource_group_name   = var.resource_group
+  name                  = "vnet-link-${each.key}"
+  private_dns_zone_name = try(azurerm_private_dns_zone.this[0].name, var.dns_zone_name)
+  resource_group_name   = try(azurerm_private_dns_zone.this[0].resource_group_name, var.resource_group)
   virtual_network_id    = each.value
   tags                  = var.tags
-
-  lifecycle {
-    precondition {
-      condition     = alltrue([length(var.dns_zone_name) == 0, length(var.external_dns_zone_name) == 0]) ? false : true
-      error_message = "Provide either 'dns_zone_name' value to create new Private DNS Zone or 'external_dns_zone_name' value to create link with already existing Private DNS Zone"
-    }
-  }
 }

outputs.tf

@@ -1,19 +1,22 @@
 output "id" {
-  value       = length(var.dns_zone_name) == 0 ? "" : azurerm_private_dns_zone.this[0].id
+  value       = try(azurerm_private_dns_zone.this[0].id, null)
   description = "Private DNS Zone Id"
 }
 
 output "name" {
-  value       = length(var.dns_zone_name) == 0 ? "" : azurerm_private_dns_zone.this[0].name
+  value       = try(azurerm_private_dns_zone.this[0].name, null)
   description = "Private DNS Zone Name"
 }
 
 output "resource_group" {
-  value       = length(var.dns_zone_name) == 0 ? "" : azurerm_private_dns_zone.this[0].resource_group_name
+  value       = try(azurerm_private_dns_zone.this[0].resource_group_name, null)
   description = "Private DNS Zone Resource Group"
 }
 
-output "link_id" {
-  value       = length(var.vnet_map) == 0 ? [] : [for vnet_link in azurerm_private_dns_zone_virtual_network_link.this : vnet_link.id]
-  description = "List of Virtual Network Link Ids"
+output "vnet_link_name_to_id_map" {
+  value = {
+    for k, v in var.vnet_map :
+    azurerm_private_dns_zone_virtual_network_link.this[k].name => azurerm_private_dns_zone_virtual_network_link.this[k].id
+  }
+  description = "Map of Virtual Network Link names to it's ids"
 }

variables.tf

@@ -1,40 +1,37 @@
-variable "resource_group" {
+variable "dns_zone_name" {
   type        = string
-  description = "Azure location"
+  description = "The name of the Private DNS Zone that needs to be created or linked to the virtual network"
 }
 
-variable "custom_dns_zone_vnet_link_name" {
+variable "resource_group" {
   type        = string
-  description = "The name of the Private DNS Zone Virtual Network Link"
-  default     = null
+  description = "Resource group where Private DNS zone would be created or it is already exists"
 }
 
-variable "tags" {
-  type        = map(string)
-  description = "Resource tags"
-  default     = {}
+variable "create_private_dns_zone" {
+  type        = bool
+  description = "Boolean flag that determines whether Private DNS Zones is created by this module"
+  default     = true
 }
 
-variable "prefix" {
-  type        = string
-  description = "Custom prefix to add to resource name"
-  default     = ""
+variable "private_dns_a_records" {
+  type = list(object({
+    name    = string
+    ttl     = optional(number, 300)
+    records = list(string)
+  }))
+  description = "List of objects with parameters to create A Record in Private DNS Zone"
+  default     = []
 }
 
-variable "dns_zone_name" {
-  type        = string
-  description = "Name of Private DNS Zone"
-  default     = ""
+variable "tags" {
+  type        = map(string)
+  description = "Resource tags"
+  default     = {}
 }
 
 variable "vnet_map" {
   type        = map(string)
   description = "Map of Virtual Network Name to Id, used to create VNet Link to Private DNS"
   default     = {}
 }
-
-variable "external_dns_zone_name" {
-  type        = string
-  description = "Name of Imported Private DNS Zone. Provide value in case creation of new Private DNS Zone is disabled"
-  default     = ""
-}