Merge pull request #36 from data-solution-automation-engine/34-create-sps-do-not-set-success-indicator

set SuccessIndicator on successful conclusion

Author: RoelantVos

Direct_Framework/Stored Procedures/omd.CreateBatchInstance.sql

@@ -168,13 +168,17 @@ BEGIN TRY
 
   FailureEndOfProcedure:
 
+  SET @SuccessIndicator = 'N'
+
   SET @LogMessage = N'' + @SpName + ' ended in failure.';
   SET @MessageLog = [omd].[AddLogMessage]('ERROR', DEFAULT, DEFAULT, @LogMessage, @MessageLog)
 
   GOTO EndOfProcedure
 
   SuccessEndOfProcedure:
 
+  SET @SuccessIndicator = 'Y'
+
   SET @LogMessage = N'' + @SpName + ' completed succesfully.';
   SET @MessageLog = [omd].[AddLogMessage]('SUCCESS', DEFAULT, DEFAULT, @LogMessage, @MessageLog)
 

Direct_Framework/Stored Procedures/omd.CreateLoadWindow.sql

@@ -229,6 +229,8 @@ WHERE modinst.EXECUTION_STATUS_CODE = ''Succeeded''';
   -- End of procedure label
   EndOfProcedure:
 
+  SET @SuccessIndicator = 'Y'
+
   SET @EndTimestamp = SYSUTCDATETIME();
   SET @EndTimestampString = FORMAT(@EndTimestamp, 'yyyy-MM-dd HH:mm:ss.fffffff');
   SET @LogMessage = @EndTimestampString;

Direct_Framework/Stored Procedures/omd.CreateModuleInstance.sql

@@ -223,13 +223,17 @@ BEGIN TRY
 
   FailureEndOfProcedure:
 
+  SET @SuccessIndicator = 'N'
+
   SET @LogMessage = N'' + @SpName + ' ended in failure.';
   SET @MessageLog = [omd].[AddLogMessage]('ERROR', DEFAULT, DEFAULT, @LogMessage, @MessageLog)
 
   GOTO EndOfProcedure
 
   SuccessEndOfProcedure:
 
+  SET @SuccessIndicator = 'Y'
+
   SET @LogMessage = N'' + @SpName + ' completed succesfully.';
   SET @MessageLog = [omd].[AddLogMessage]('SUCCESS', DEFAULT, DEFAULT, @LogMessage, @MessageLog)
 

Direct_Framework/Stored Procedures/omd.EndDating.sql

@@ -192,6 +192,7 @@ WHERE NOT EXISTS
   -- End of procedure label
   EndOfProcedure:
 
+  SET @SuccessIndicator = 'Y'
   SET @EndTimestamp = SYSUTCDATETIME();
   SET @EndTimestampString = FORMAT(@EndTimestamp, 'yyyy-MM-dd HH:mm:ss.fffffff');
   SET @LogMessage = @EndTimestampString;

Direct_Framework/Stored Procedures/omd.GetConsistencyTimestamp.sql

@@ -398,6 +398,8 @@ BEGIN TRY
   -- End of procedure label
   EndOfProcedure:
 
+  SET @SuccessIndicator = 'Y'
+
   SET @EndTimestamp = SYSUTCDATETIME();
   SET @EndTimestampString = FORMAT(@EndTimestamp, 'yyyy-MM-dd HH:mm:ss.fffffff');
   SET @LogMessage = @EndTimestampString;

Direct_Framework/Stored Procedures/omd.InsertIntoEventLog.sql

@@ -129,6 +129,8 @@ BEGIN TRY
   -- End of procedure label
   EndOfProcedure:
 
+  SET @SuccessIndicator = 'Y'
+
   SET @EndTimestamp = SYSUTCDATETIME();
   SET @EndTimestampString = FORMAT(@EndTimestamp, 'yyyy-MM-dd HH:mm:ss.fffffff');
   SET @LogMessage = @EndTimestampString;

Direct_Framework/Stored Procedures/omd.ModuleEvaluation.sql

@@ -464,6 +464,7 @@ BEGIN TRY
 
   ModuleFailure:
   -- The procedure should not be able to end in this part, so this is just to be sure there is a failure reported when this happens.
+  SET @SuccessIndicator = 'N'
   EXEC [omd].[UpdateModuleInstance]
     @ModuleInstanceId   = @ModuleInstanceId,
     @Debug              = @Debug,
@@ -483,6 +484,7 @@ BEGIN TRY
   -- End of procedure label
   EndOfProcedure:
 
+  SET @SuccessIndicator = 'Y'
   SET @EndTimestamp = SYSUTCDATETIME();
   SET @EndTimestampString = FORMAT(@EndTimestamp, 'yyyy-MM-dd HH:mm:ss.fffffff');
   SET @LogMessage = @EndTimestampString;

Direct_Framework/Stored Procedures/omd.RegisterBatch.sql

@@ -196,6 +196,8 @@ BEGIN TRY
   -- End of procedure label
   EndOfProcedure:
 
+  SET @SuccessIndicator = 'Y'
+
   SET @EndTimestamp = SYSUTCDATETIME();
   SET @EndTimestampString = FORMAT(@EndTimestamp, 'yyyy-MM-dd HH:mm:ss.fffffff');
   SET @LogMessage = @EndTimestampString;

Direct_Framework/Stored Procedures/omd.RunBatch.sql

@@ -243,7 +243,8 @@ BEGIN TRY
         @Debug            = @Debug,
         @EventCode        = 'Failure';
 
-    SET @Result = 'Failure';
+      SET @Result = 'Failure';
+      SET @SuccessIndicator = 'N';
 
     THROW